Merge pull request 'Small bugfix for Power CTRL set handling' (#804) from power-ctrl-custom-tranisition into main

Reviewed-on: #804
Reviewed-by: Marius Eggert <eggertm@irs.uni-stuttgart.de>

CHANGELOG.md

@@ -16,6 +16,11 @@ will consitute of a breaking change warranting a new major release:
 
 # [unreleased]
 
+## Fixed
+
+- PL Enable set of the power controller is now set to invalid properly
+  if the power controller is not in normal mode.
+
 # [v7.1.0] 2023-10-11
 
 - Bumped `eive-tmtc` to v5.8.0.

mission/controller/PowerController.cpp

@@ -100,16 +100,17 @@ void PowerController::performControlOperation() {
       return;
     }
     case InternalState::READY: {
-      if (mode != MODE_OFF) {
-        calculateStateOfCharge();
-        if (mode == MODE_NORMAL) {
-          watchStateOfCharge();
-        } else {
+      if (mode != MODE_NORMAL) {
         PoolReadGuard pg(&enablePl);
         if (pg.getReadResult() == returnvalue::OK) {
           enablePl.setValidity(false, true);
         }
       }
+      if (mode != MODE_OFF) {
+        calculateStateOfCharge();
+        if (mode == MODE_NORMAL) {
+          watchStateOfCharge();
+        }
       }
       break;
     }