PL PCDU switch states like mode bitmask now

bsp_q7s/core/ObjectFactory.cpp

@@ -662,9 +662,9 @@ void ObjectFactory::createPayloadComponents(LinuxLibgpioIF* gpioComIF) {
   auto supvGpioCookie = new GpioCookie;
   supvGpioCookie->addGpio(gpioIds::ENABLE_SUPV_UART, gpioConfigSupv);
   gpioComIF->addGpios(supvGpioCookie);
-  auto supervisorCookie = new UartCookie(
-      objects::PLOC_SUPERVISOR_HANDLER, q7s::UART_PLOC_SUPERVSIOR_DEV, UartModes::NON_CANONICAL,
-      uart::PLOC_SUPERVISOR_BAUD, supv::MAX_PACKET_SIZE * 20);
+  auto supervisorCookie = new UartCookie(objects::PLOC_SUPERVISOR_HANDLER,
+                                         q7s::UART_PLOC_SUPERVSIOR_DEV, UartModes::NON_CANONICAL,
+                                         uart::PLOC_SUPERVISOR_BAUD, supv::MAX_PACKET_SIZE * 20);
   supervisorCookie->setNoFixedSizeReply();
   new PlocSupervisorHandler(objects::PLOC_SUPERVISOR_HANDLER, objects::UART_COM_IF,
                             supervisorCookie, Gpio(gpioIds::ENABLE_SUPV_UART, gpioComIF),

linux/devices/devicedefinitions/PlocSupervisorDefinitions.h

@@ -1541,6 +1541,6 @@ class LatchupStatusReport : public StaticLocalDataSet<LATCHUP_RPT_SET_ENTRIES> {
   lp_var_t<uint32_t> isSet =
       lp_var_t<uint32_t>(sid.objectId, PoolIds::LATCHUP_RPT_TIME_IS_SET, this);
 };
-}  // namespace PLOC_SPV
+}  // namespace supv
 
 #endif /* MISSION_DEVICES_DEVICEDEFINITIONS_PLOCSVPDEFINITIONS_H_ */

linux/devices/ploc/PlocMPSoCHandler.cpp

@@ -1,9 +1,9 @@
 #include "PlocMPSoCHandler.h"
-#include "linux/devices/devicedefinitions/PlocSupervisorDefinitions.h"
 
 #include "OBSWConfig.h"
 #include "fsfw/datapool/PoolReadGuard.h"
 #include "fsfw/globalfunctions/CRC.h"
+#include "linux/devices/devicedefinitions/PlocSupervisorDefinitions.h"
 
 PlocMPSoCHandler::PlocMPSoCHandler(object_id_t objectId, object_id_t uartComIFid,
                                    CookieIF* comCookie, PlocMPSoCHelper* plocMPSoCHelper,
@@ -87,8 +87,8 @@ void PlocMPSoCHandler::performOperationHook() {
     }
   }
   CommandMessage message;
-  for (ReturnValue_t result = commandActionHelperQueue->receiveMessage(&message); result == RETURN_OK;
-       result = commandActionHelperQueue->receiveMessage(&message)) {
+  for (ReturnValue_t result = commandActionHelperQueue->receiveMessage(&message);
+       result == RETURN_OK; result = commandActionHelperQueue->receiveMessage(&message)) {
     result = commandActionHelper.handleReply(&message);
     if (result == RETURN_OK) {
       continue;
@@ -133,31 +133,31 @@ ReturnValue_t PlocMPSoCHandler::executeAction(ActionId_t actionId, MessageQueueI
 }
 
 void PlocMPSoCHandler::doStartUp() {
-  switch(powerState) {
-  case PowerState::OFF:
+  switch (powerState) {
+    case PowerState::OFF:
       commandActionHelper.commandAction(supervisorHandler, supv::START_MPSOC);
       powerState = PowerState::BOOTING;
       break;
-  case PowerState::ON:
+    case PowerState::ON:
       setMode(_MODE_TO_ON);
       uartIsolatorSwitch.pullHigh();
       break;
-  default:
+    default:
       break;
   }
 }
 
 void PlocMPSoCHandler::doShutDown() {
-  switch(powerState) {
-  case PowerState::ON:
+  switch (powerState) {
+    case PowerState::ON:
       uartIsolatorSwitch.pullLow();
       commandActionHelper.commandAction(supervisorHandler, supv::SHUTDOWN_MPSOC);
       powerState = PowerState::SHUTDOWN;
       break;
-  case PowerState::OFF:
+    case PowerState::OFF:
       setMode(_MODE_POWER_DOWN);
       break;
-  default:
+    default:
       break;
   }
 }
@@ -703,64 +703,57 @@ size_t PlocMPSoCHandler::getNextReplyLength(DeviceCommandId_t commandId) {
   return replyLen;
 }
 
-MessageQueueIF* PlocMPSoCHandler::getCommandQueuePtr() {
-  return commandActionHelperQueue;
-}
+MessageQueueIF* PlocMPSoCHandler::getCommandQueuePtr() { return commandActionHelperQueue; }
 
-void PlocMPSoCHandler::stepSuccessfulReceived(ActionId_t actionId, uint8_t step) {
-    return;
-}
+void PlocMPSoCHandler::stepSuccessfulReceived(ActionId_t actionId, uint8_t step) { return; }
 
 void PlocMPSoCHandler::stepFailedReceived(ActionId_t actionId, uint8_t step,
-		ReturnValue_t returnCode) {
-	switch (actionId) {
-	case supv::START_MPSOC:
-		sif::warning << "PlocMPSoCHandler::stepFailedReceived: Failed to start MPSoC"
-				<< std::endl;
-		powerState = PowerState::OFF;
-		break;
-	case supv::SHUTDOWN_MPSOC:
-		triggerEvent(MPSOC_SHUTDOWN_FAILED);
-		sif::warning << "PlocMPSoCHandler::stepFailedReceived: Failed to shutdown MPSoC"
-				<< std::endl;
-		// TODO: Setting state to on or off here?
-		powerState = PowerState::ON;
-		break;
-	default:
-		sif::debug
-				<< "PlocMPSoCHandler::stepFailedReceived: Received unexpected action reply"
-				<< std::endl;
-		break;
-	}
+                                          ReturnValue_t returnCode) {
+  switch (actionId) {
+    case supv::START_MPSOC:
+      sif::warning << "PlocMPSoCHandler::stepFailedReceived: Failed to start MPSoC" << std::endl;
+      powerState = PowerState::OFF;
+      break;
+    case supv::SHUTDOWN_MPSOC:
+      triggerEvent(MPSOC_SHUTDOWN_FAILED);
+      sif::warning << "PlocMPSoCHandler::stepFailedReceived: Failed to shutdown MPSoC" << std::endl;
+      // TODO: Setting state to on or off here?
+      powerState = PowerState::ON;
+      break;
+    default:
+      sif::debug << "PlocMPSoCHandler::stepFailedReceived: Received unexpected action reply"
+                 << std::endl;
+      break;
+  }
 }
 
 void PlocMPSoCHandler::dataReceived(ActionId_t actionId, const uint8_t* data, uint32_t size) {
-    return;
+  return;
 }
 
 void PlocMPSoCHandler::completionSuccessfulReceived(ActionId_t actionId) {
-	if (actionId != supv::EXE_REPORT) {
-		sif::debug << "PlocMPSoCHandler::completionSuccessfulReceived: Did not expect this action "
-				<< "ID" << std::endl;
-		return;
-	}
-    switch(powerState) {
+  if (actionId != supv::EXE_REPORT) {
+    sif::debug << "PlocMPSoCHandler::completionSuccessfulReceived: Did not expect this action "
+               << "ID" << std::endl;
+    return;
+  }
+  switch (powerState) {
     case PowerState::BOOTING: {
-        powerState = PowerState::ON;
-        break;
+      powerState = PowerState::ON;
+      break;
     }
     case PowerState::SHUTDOWN: {
-        powerState = PowerState::OFF;
-        break;
+      powerState = PowerState::OFF;
+      break;
     }
     default: {
       break;
     }
-    }
+  }
 }
 
 void PlocMPSoCHandler::completionFailedReceived(ActionId_t actionId, ReturnValue_t returnCode) {
-    handleActionCommandFailure(actionId);
+  handleActionCommandFailure(actionId);
 }
 
 void PlocMPSoCHandler::handleDeviceTM(const uint8_t* data, size_t dataSize,
@@ -862,27 +855,27 @@ void PlocMPSoCHandler::handleActionCommandFailure(ActionId_t actionId) {
   switch (actionId) {
     case supv::ACK_REPORT:
     case supv::EXE_REPORT:
-    	break;
+      break;
     default:
-    	sif::debug << "PlocMPSoCHandler::handleActionCommandFailure: Did not expect this action ID "
-			<< std::endl;
-    	return;
+      sif::debug << "PlocMPSoCHandler::handleActionCommandFailure: Did not expect this action ID "
+                 << std::endl;
+      return;
   }
-  switch(powerState) {
-  case PowerState::BOOTING: {
-	  sif::warning << "PlocMPSoCHandler::handleActionCommandFailure: Failed to boot MPSoC"
-	  	  << std::endl;
-	  powerState = PowerState::OFF;
-	  break;
-  }
-  case PowerState::SHUTDOWN: {
-	  sif::warning << "PlocMPSoCHandler::handleActionCommandFailure: Failed to shutdown MPSoC"
-	  	  	  << std::endl;
-	  powerState = PowerState::ON;
-	  break;
-  }
-  default:
-	  break;
+  switch (powerState) {
+    case PowerState::BOOTING: {
+      sif::warning << "PlocMPSoCHandler::handleActionCommandFailure: Failed to boot MPSoC"
+                   << std::endl;
+      powerState = PowerState::OFF;
+      break;
+    }
+    case PowerState::SHUTDOWN: {
+      sif::warning << "PlocMPSoCHandler::handleActionCommandFailure: Failed to shutdown MPSoC"
+                   << std::endl;
+      powerState = PowerState::ON;
+      break;
+    }
+    default:
+      break;
   }
   return;
 }

linux/devices/ploc/PlocSupervisorHandler.cpp

@@ -384,7 +384,7 @@ ReturnValue_t PlocSupervisorHandler::scanForReply(const uint8_t* start, size_t r
 ReturnValue_t PlocSupervisorHandler::getSwitches(const uint8_t** switches,
                                                  uint8_t* numberOfSwitches) {
   if (powerSwitch == power::NO_SWITCH) {
-      return DeviceHandlerBase::NO_SWITCH;
+    return DeviceHandlerBase::NO_SWITCH;
   }
   *numberOfSwitches = 1;
   *switches = &powerSwitch;
@@ -489,8 +489,8 @@ ReturnValue_t PlocSupervisorHandler::enableReplyInReplyMap(DeviceCommandMap::ite
   switch (command->first) {
     case supv::GET_HK_REPORT: {
       enabledReplies = 3;
-      result = DeviceHandlerBase::enableReplyInReplyMap(command, enabledReplies, true,
-                                                        supv::HK_REPORT);
+      result =
+          DeviceHandlerBase::enableReplyInReplyMap(command, enabledReplies, true, supv::HK_REPORT);
       if (result != RETURN_OK) {
         sif::debug << "PlocSupervisorHandler::enableReplyInReplyMap: Reply with id "
                    << supv::HK_REPORT << " not in replyMap" << std::endl;
@@ -589,15 +589,15 @@ ReturnValue_t PlocSupervisorHandler::enableReplyInReplyMap(DeviceCommandMap::ite
   result =
       DeviceHandlerBase::enableReplyInReplyMap(command, enabledReplies, true, supv::ACK_REPORT);
   if (result != RETURN_OK) {
-    sif::debug << "PlocSupervisorHandler::enableReplyInReplyMap: Reply with id "
-               << supv::ACK_REPORT << " not in replyMap" << std::endl;
+    sif::debug << "PlocSupervisorHandler::enableReplyInReplyMap: Reply with id " << supv::ACK_REPORT
+               << " not in replyMap" << std::endl;
   }
 
   result =
       DeviceHandlerBase::enableReplyInReplyMap(command, enabledReplies, true, supv::EXE_REPORT);
   if (result != RETURN_OK) {
-    sif::debug << "PlocSupervisorHandler::enableReplyInReplyMap: Reply with id "
-               << supv::EXE_REPORT << " not in replyMap" << std::endl;
+    sif::debug << "PlocSupervisorHandler::enableReplyInReplyMap: Reply with id " << supv::EXE_REPORT
+               << " not in replyMap" << std::endl;
   }
 
   return RETURN_OK;
@@ -1013,7 +1013,7 @@ void PlocSupervisorHandler::prepareEmptyCmd(uint16_t apid) {
 
 void PlocSupervisorHandler::prepareSelBootImageCmd(const uint8_t* commandData) {
   supv::MPSoCBootSelect packet(*commandData, *(commandData + 1), *(commandData + 2),
-                                   *(commandData + 3));
+                               *(commandData + 3));
   packetToOutBuffer(packet.getWholeData(), packet.getFullSize());
 }
 
@@ -1459,9 +1459,8 @@ ReturnValue_t PlocSupervisorHandler::handleMramDumpFile(DeviceCommandId_t id) {
     return MRAM_FILE_NOT_EXISTS;
   }
   std::ofstream file(activeMramFile, std::ios_base::app | std::ios_base::out);
-  file.write(
-      reinterpret_cast<const char*>(spacePacketBuffer + supv::SPACE_PACKET_HEADER_LENGTH),
-      packetLen - 1);
+  file.write(reinterpret_cast<const char*>(spacePacketBuffer + supv::SPACE_PACKET_HEADER_LENGTH),
+             packetLen - 1);
   file.close();
   return RETURN_OK;
 }

linux/devices/ploc/PlocUpdater.cpp

@@ -262,12 +262,11 @@ void PlocUpdater::commandUpdateAvailable() {
   calcImageCrc();
 
   supv::UpdateInfo packet(supv::APID_UPDATE_AVAILABLE, static_cast<uint8_t>(image),
-                              static_cast<uint8_t>(partition), imageSize, imageCrc,
-                              numOfUpdatePackets);
+                          static_cast<uint8_t>(partition), imageSize, imageCrc, numOfUpdatePackets);
 
-  result = commandActionHelper.commandAction(objects::PLOC_SUPERVISOR_HANDLER,
-                                             supv::UPDATE_AVAILABLE, packet.getWholeData(),
-                                             packet.getFullSize());
+  result =
+      commandActionHelper.commandAction(objects::PLOC_SUPERVISOR_HANDLER, supv::UPDATE_AVAILABLE,
+                                        packet.getWholeData(), packet.getFullSize());
   if (result != RETURN_OK) {
     sif::warning << "PlocUpdater::commandUpdateAvailable: Failed to send update available"
                  << " packet to supervisor handler" << std::endl;
@@ -311,9 +310,9 @@ void PlocUpdater::commandUpdatePacket() {
   }
   packet.makeCrc();
 
-  result = commandActionHelper.commandAction(objects::PLOC_SUPERVISOR_HANDLER,
-                                             supv::UPDATE_IMAGE_DATA, packet.getWholeData(),
-                                             packet.getFullSize());
+  result =
+      commandActionHelper.commandAction(objects::PLOC_SUPERVISOR_HANDLER, supv::UPDATE_IMAGE_DATA,
+                                        packet.getWholeData(), packet.getFullSize());
 
   if (result != RETURN_OK) {
     sif::warning << "PlocUpdater::commandUpdateAvailable: Failed to send update"
@@ -335,12 +334,10 @@ void PlocUpdater::commandUpdateVerify() {
   ReturnValue_t result = RETURN_OK;
 
   supv::UpdateInfo packet(supv::APID_UPDATE_VERIFY, static_cast<uint8_t>(image),
-                              static_cast<uint8_t>(partition), imageSize, imageCrc,
-                              numOfUpdatePackets);
+                          static_cast<uint8_t>(partition), imageSize, imageCrc, numOfUpdatePackets);
 
-  result =
-      commandActionHelper.commandAction(objects::PLOC_SUPERVISOR_HANDLER, supv::UPDATE_VERIFY,
-                                        packet.getWholeData(), packet.getFullSize());
+  result = commandActionHelper.commandAction(objects::PLOC_SUPERVISOR_HANDLER, supv::UPDATE_VERIFY,
+                                             packet.getWholeData(), packet.getFullSize());
   if (result != RETURN_OK) {
     sif::warning << "PlocUpdater::commandUpdateAvailable: Failed to send update available"
                  << " packet to supervisor handler" << std::endl;

linux/devices/startracker/StarTrackerHandler.h

@@ -7,12 +7,12 @@
 #include "ArcsecJsonParamBase.h"
 #include "OBSWConfig.h"
 #include "StrHelper.h"
+#include "devices/powerSwitcherList.h"
 #include "fsfw/devicehandlers/DeviceHandlerBase.h"
 #include "fsfw/src/fsfw/serialize/SerializeAdapter.h"
 #include "fsfw/timemanager/Countdown.h"
 #include "linux/devices/devicedefinitions/StarTrackerDefinitions.h"
 #include "thirdparty/arcsec_star_tracker/common/SLIP.h"
-#include "devices/powerSwitcherList.h"
 
 /**
  * @brief	This is the device handler for the star tracker from arcsec.

mission/devices/P60DockHandler.cpp

@@ -441,6 +441,9 @@ ReturnValue_t P60DockHandler::initializeLocalDataPool(localpool::DataPool &local
   localDataPoolMap.emplace(P60System::P60DOCK_ANT6_DEPL, new PoolEntry<int8_t>({0}));
   localDataPoolMap.emplace(P60System::P60DOCK_AR6_DEPL, new PoolEntry<int8_t>({0}));
 
+#if OBSW_ENABLE_PERIODIC_HK == 1
+  poolManager.subscribeForPeriodicPacket(p60dockHkTableDataset.getSid(), false, 0.8, true);
+#endif
   return HasReturnvaluesIF::RETURN_OK;
 }
 

mission/devices/PayloadPcduHandler.cpp

@@ -66,7 +66,7 @@ void PayloadPcduHandler::doTransition(Mode_t modeFrom, Submode_t subModeFrom) {
 
 ReturnValue_t PayloadPcduHandler::stateMachineToNormal(Mode_t modeFrom, Submode_t subModeFrom) {
   using namespace plpcdu;
-  if (submode == NormalSubmodes::SOLID_STATE_RELAYS_ADC_ON) {
+  if (((submode >> SOLID_STATE_RELAYS_ADC_ON) & 0b1) == 1) {
     if (state == States::PL_PCDU_OFF) {
       sif::error << "PayloadPcduHandler::stateMachineToNormal: Unexpected state PL_PCDU_OFF"
                  << "detected" << std::endl;
@@ -116,7 +116,7 @@ ReturnValue_t PayloadPcduHandler::stateMachineToNormal(Mode_t modeFrom, Submode_
     }
   }
 
-  if (submode == NormalSubmodes::DRO_ON) {
+  if (((submode >> DRO_ON) & 1) == 1) {
 #if OBSW_VERBOSE_LEVEL >= 1
     sif::info << "Enabling PL PCDU DRO module" << std::endl;
 #endif
@@ -127,7 +127,7 @@ ReturnValue_t PayloadPcduHandler::stateMachineToNormal(Mode_t modeFrom, Submode_
     setMode(MODE_NORMAL, submode);
   }
 
-  if (submode == NormalSubmodes::X8_ON) {
+  if (((submode >> X8_ON) & 1) == 1) {
 #if OBSW_VERBOSE_LEVEL >= 1
     sif::info << "Enabling PL PCDU X8 module" << std::endl;
 #endif
@@ -138,7 +138,7 @@ ReturnValue_t PayloadPcduHandler::stateMachineToNormal(Mode_t modeFrom, Submode_
     setMode(MODE_NORMAL, submode);
   }
 
-  if (submode == NormalSubmodes::TX_ON) {
+  if (((submode >> TX_ON) & 1) == 1) {
 #if OBSW_VERBOSE_LEVEL >= 1
     sif::info << "Enabling PL PCDU TX module" << std::endl;
 #endif
@@ -149,7 +149,7 @@ ReturnValue_t PayloadPcduHandler::stateMachineToNormal(Mode_t modeFrom, Submode_
     setMode(MODE_NORMAL, submode);
   }
 
-  if (submode == NormalSubmodes::MPA_ON) {
+  if (((submode >> MPA_ON) & 1) == 1) {
 #if OBSW_VERBOSE_LEVEL >= 1
     sif::info << "Enabling PL PCDU MPA module" << std::endl;
 #endif
@@ -160,7 +160,7 @@ ReturnValue_t PayloadPcduHandler::stateMachineToNormal(Mode_t modeFrom, Submode_
     setMode(MODE_NORMAL, submode);
   }
 
-  if (submode == NormalSubmodes::HPA_ON) {
+  if (((submode >> HPA_ON) & 1) == 1) {
 #if OBSW_VERBOSE_LEVEL >= 1
     sif::info << "Enabling PL PCDU HPA module" << std::endl;
 #endif
@@ -549,24 +549,30 @@ ReturnValue_t PayloadPcduHandler::isModeCombinationValid(Mode_t mode, Submode_t
   using namespace plpcdu;
   if (mode == MODE_NORMAL) {
     // Also deals with the case where the mode is MODE_ON, submode should be 0 here
-    if (submode == NormalSubmodes::SOLID_STATE_RELAYS_ADC_ON and
-        (this->mode == MODE_NORMAL and this->submode != NormalSubmodes::ALL_OFF)) {
+    if ((((submode >> SOLID_STATE_RELAYS_ADC_ON) & 0b1) == SOLID_STATE_RELAYS_ADC_ON) and
+        (this->mode == MODE_NORMAL and this->submode != ALL_OFF_SUBMODE)) {
       return TRANS_NOT_ALLOWED;
     }
-    if ((submode == NormalSubmodes::DRO_ON and
-         this->submode != NormalSubmodes::SOLID_STATE_RELAYS_ADC_ON)) {
+    if (((((submode >> DRO_ON) & 1) == 1) and
+         (this->submode != (1 << SOLID_STATE_RELAYS_ADC_ON)))) {
       return TRANS_NOT_ALLOWED;
     }
-    if ((submode == NormalSubmodes::X8_ON and this->submode != NormalSubmodes::DRO_ON)) {
+    if ((((submode >> X8_ON) & 1) == 1) and
+        (this->submode != ((1 << SOLID_STATE_RELAYS_ADC_ON) | (1 << DRO_ON)))) {
       return TRANS_NOT_ALLOWED;
     }
-    if ((submode == NormalSubmodes::TX_ON and this->submode != NormalSubmodes::X8_ON)) {
+    if (((((submode >> TX_ON) & 1) == 1) and
+         (this->submode != ((1 << X8_ON) | (1 << DRO_ON) | (1 << SOLID_STATE_RELAYS_ADC_ON))))) {
       return TRANS_NOT_ALLOWED;
     }
-    if ((submode == NormalSubmodes::MPA_ON and this->submode != NormalSubmodes::TX_ON)) {
+    if ((((submode >> MPA_ON) & 1) == 1 and
+         (this->submode !=
+          ((1 << TX_ON) | (1 << X8_ON) | (1 << DRO_ON) | (1 << SOLID_STATE_RELAYS_ADC_ON))))) {
       return TRANS_NOT_ALLOWED;
     }
-    if ((submode == NormalSubmodes::HPA_ON and this->submode != NormalSubmodes::MPA_ON)) {
+    if ((((submode >> HPA_ON) & 1) == 1 and
+         (this->submode != ((1 << MPA_ON) | (1 << TX_ON) | (1 << X8_ON) | (1 << DRO_ON) |
+                            (1 << SOLID_STATE_RELAYS_ADC_ON))))) {
       return TRANS_NOT_ALLOWED;
     }
     return HasReturnvaluesIF::RETURN_OK;

mission/devices/RadiationSensorHandler.cpp

@@ -92,15 +92,15 @@ ReturnValue_t RadiationSensorHandler::buildCommandFromCommand(DeviceCommandId_t
       return RETURN_OK;
     }
     case RAD_SENSOR::ENABLE_DEBUG_OUTPUT: {
-		printPeriodicData = true;
-		rawPacketLen = 0;
-		return RETURN_OK;
-	}
-	case RAD_SENSOR::DISABLE_DEBUG_OUTPUT: {
-		rawPacketLen = 0;
-		printPeriodicData = false;
-		return RETURN_OK;
-	}
+      printPeriodicData = true;
+      rawPacketLen = 0;
+      return RETURN_OK;
+    }
+    case RAD_SENSOR::DISABLE_DEBUG_OUTPUT: {
+      rawPacketLen = 0;
+      printPeriodicData = false;
+      return RETURN_OK;
+    }
     default:
       return DeviceHandlerIF::COMMAND_NOT_IMPLEMENTED;
   }
@@ -123,7 +123,7 @@ ReturnValue_t RadiationSensorHandler::scanForReply(const uint8_t *start, size_t
   switch (*foundId) {
     case RAD_SENSOR::START_CONVERSION:
     case RAD_SENSOR::WRITE_SETUP:
-     *foundLen = remainingSize;
+      *foundLen = remainingSize;
       return IGNORE_REPLY_DATA;
     case RAD_SENSOR::READ_CONVERSIONS: {
       ReturnValue_t result = gpioIF->pullLow(gpioIds::ENABLE_RADFET);
@@ -138,8 +138,8 @@ ReturnValue_t RadiationSensorHandler::scanForReply(const uint8_t *start, size_t
     }
     case RAD_SENSOR::ENABLE_DEBUG_OUTPUT:
     case RAD_SENSOR::DISABLE_DEBUG_OUTPUT:
-    	sif::info << "RadiationSensorHandler::scanForReply: " << remainingSize << std::endl;
-    	break;
+      sif::info << "RadiationSensorHandler::scanForReply: " << remainingSize << std::endl;
+      break;
     default:
       break;
   }

mission/devices/SyrlinksHkHandler.cpp

@@ -139,42 +139,45 @@ ReturnValue_t SyrlinksHkHandler::buildCommandFromCommand(DeviceCommandId_t devic
       return RETURN_OK;
     }
     case (SYRLINKS::READ_TX_AGC_VALUE_HIGH_BYTE): {
-      readTxAgcValueHighByte.copy(reinterpret_cast<char*>(commandBuffer), readTxAgcValueHighByte.size(), 0);
+      readTxAgcValueHighByte.copy(reinterpret_cast<char*>(commandBuffer),
+                                  readTxAgcValueHighByte.size(), 0);
       rawPacketLen = readTxAgcValueHighByte.size();
       rememberCommandId = SYRLINKS::READ_TX_AGC_VALUE_HIGH_BYTE;
       rawPacket = commandBuffer;
       return RETURN_OK;
     }
     case (SYRLINKS::READ_TX_AGC_VALUE_LOW_BYTE): {
-      readTxAgcValueLowByte.copy(reinterpret_cast<char*>(commandBuffer), readTxAgcValueLowByte.size(), 0);
+      readTxAgcValueLowByte.copy(reinterpret_cast<char*>(commandBuffer),
+                                 readTxAgcValueLowByte.size(), 0);
       rawPacketLen = readTxAgcValueLowByte.size();
       rememberCommandId = SYRLINKS::READ_TX_AGC_VALUE_LOW_BYTE;
       rawPacket = commandBuffer;
       return RETURN_OK;
     }
     case (SYRLINKS::TEMP_POWER_AMPLIFIER_HIGH_BYTE):
-      tempPowerAmpBoardHighByte.copy(reinterpret_cast<char*>(commandBuffer), tempPowerAmpBoardHighByte.size(),
-                                     0);
+      tempPowerAmpBoardHighByte.copy(reinterpret_cast<char*>(commandBuffer),
+                                     tempPowerAmpBoardHighByte.size(), 0);
       rawPacketLen = tempPowerAmpBoardHighByte.size();
       rememberCommandId = SYRLINKS::TEMP_POWER_AMPLIFIER_HIGH_BYTE;
       rawPacket = commandBuffer;
       return RETURN_OK;
     case (SYRLINKS::TEMP_POWER_AMPLIFIER_LOW_BYTE):
-		tempPowerAmpBoardLowByte.copy(reinterpret_cast<char*>(commandBuffer), tempPowerAmpBoardLowByte.size(),
-                                     0);
+      tempPowerAmpBoardLowByte.copy(reinterpret_cast<char*>(commandBuffer),
+                                    tempPowerAmpBoardLowByte.size(), 0);
       rawPacketLen = tempPowerAmpBoardLowByte.size();
       rememberCommandId = SYRLINKS::TEMP_POWER_AMPLIFIER_LOW_BYTE;
       rawPacket = commandBuffer;
       return RETURN_OK;
     case (SYRLINKS::TEMP_BASEBAND_BOARD_HIGH_BYTE):
-      tempBasebandBoardHighByte.copy(reinterpret_cast<char*>(commandBuffer), tempBasebandBoardHighByte.size(),
-                                     0);
+      tempBasebandBoardHighByte.copy(reinterpret_cast<char*>(commandBuffer),
+                                     tempBasebandBoardHighByte.size(), 0);
       rawPacketLen = tempBasebandBoardHighByte.size();
       rememberCommandId = SYRLINKS::TEMP_BASEBAND_BOARD_HIGH_BYTE;
       rawPacket = commandBuffer;
       return RETURN_OK;
     case (SYRLINKS::TEMP_BASEBAND_BOARD_LOW_BYTE):
-      tempBasebandBoardLowByte.copy(reinterpret_cast<char*>(commandBuffer), tempBasebandBoardLowByte.size(), 0);
+      tempBasebandBoardLowByte.copy(reinterpret_cast<char*>(commandBuffer),
+                                    tempBasebandBoardLowByte.size(), 0);
       rawPacketLen = tempBasebandBoardLowByte.size();
       rememberCommandId = SYRLINKS::TEMP_BASEBAND_BOARD_LOW_BYTE;
       rawPacket = commandBuffer;
@@ -352,8 +355,8 @@ ReturnValue_t SyrlinksHkHandler::interpretDeviceReply(DeviceCommandId_t id, cons
       rawTempBasebandBoard |= convertHexStringToUint8(
           reinterpret_cast<const char*>(packet + SYRLINKS::MESSAGE_HEADER_SIZE));
       tempBasebandBoard = calcTempVal(rawTempBasebandBoard);
-		sif::info << "Syrlinks temperature baseband board: " << tempBasebandBoard << "  °C"
-				<< std::endl;
+      sif::info << "Syrlinks temperature baseband board: " << tempBasebandBoard << "  °C"
+                << std::endl;
       break;
     case (SYRLINKS::TEMP_POWER_AMPLIFIER_HIGH_BYTE):
       result = verifyReply(packet, SYRLINKS::READ_ONE_REGISTER_REPLY_SIE);
@@ -364,8 +367,8 @@ ReturnValue_t SyrlinksHkHandler::interpretDeviceReply(DeviceCommandId_t id, cons
       }
       rawTempPowerAmplifier = 0;
       rawTempPowerAmplifier = convertHexStringToUint8(reinterpret_cast<const char*>(
-                                 packet + SYRLINKS::MESSAGE_HEADER_SIZE))
-                             << 8;
+                                  packet + SYRLINKS::MESSAGE_HEADER_SIZE))
+                              << 8;
       break;
     case (SYRLINKS::TEMP_POWER_AMPLIFIER_LOW_BYTE):
       result = verifyReply(packet, SYRLINKS::READ_ONE_REGISTER_REPLY_SIE);
@@ -378,7 +381,7 @@ ReturnValue_t SyrlinksHkHandler::interpretDeviceReply(DeviceCommandId_t id, cons
           reinterpret_cast<const char*>(packet + SYRLINKS::MESSAGE_HEADER_SIZE));
       tempPowerAmplifier = calcTempVal(rawTempPowerAmplifier);
       sif::info << "Syrlinks temperature power amplifier board: " << tempPowerAmplifier << "  °C"
-      				<< std::endl;
+                << std::endl;
       break;
     default: {
       sif::debug << "SyrlinksHkHandler::interpretDeviceReply: Unknown device reply id" << std::endl;

mission/devices/SyrlinksHkHandler.h

@@ -1,10 +1,11 @@
 #ifndef MISSION_DEVICES_SYRLINKSHKHANDLER_H_
 #define MISSION_DEVICES_SYRLINKSHKHANDLER_H_
 
+#include <string.h>
+
 #include "devices/powerSwitcherList.h"
 #include "fsfw/devicehandlers/DeviceHandlerBase.h"
 #include "mission/devices/devicedefinitions/SyrlinksDefinitions.h"
-#include <string.h>
 
 /**
  * @brief	This is the device handler for the syrlinks transceiver. It handles the command

mission/devices/devicedefinitions/payloadPcduDefinitions.h

@@ -91,16 +91,17 @@ static constexpr DeviceCommandId_t SETUP_CMD = 1;
 static constexpr DeviceCommandId_t READ_TEMP_EXT = 2;
 static constexpr DeviceCommandId_t READ_WITH_TEMP_EXT = 3;
 
-enum NormalSubmodes {
-  ALL_OFF = 0,
-  SOLID_STATE_RELAYS_ADC_ON = 1,
-  DRO_ON = 2,
-  X8_ON = 3,
-  TX_ON = 4,
-  MPA_ON = 5,
-  HPA_ON = 6
+enum NormalSubmodeBits {
+  SOLID_STATE_RELAYS_ADC_ON = 0,
+  DRO_ON = 1,
+  X8_ON = 2,
+  TX_ON = 3,
+  MPA_ON = 4,
+  HPA_ON = 5
 };
 
+static constexpr Submode_t ALL_OFF_SUBMODE = 0;
+
 // 12 ADC values * 2 + trailing zero
 static constexpr size_t ADC_REPLY_SIZE = 25;
 // Conversion byte + 24 * zero

mission/system/AcsBoardAssembly.cpp

@@ -143,13 +143,13 @@ ReturnValue_t AcsBoardAssembly::handleNormalOrOnModeCmd(Mode_t mode, Submode_t s
       cmdSeq(helper.mgm1Rm3100IdSideA, helper.mgm1SideAMode, ModeTableIdx::MGM_1_A);
       if (gpsUsable) {
         gpioHandler(gpioIds::GNSS_0_NRESET, true,
-            "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull nReset pin"
-            "of GNSS 0 high (used GNSS)");
+                    "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull nReset pin"
+                    "of GNSS 0 high (used GNSS)");
         gpioHandler(gpioIds::GNSS_1_NRESET, false,
-            "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull nReset pin"
-             "of GNSS 1 low (unused GNSS)");
+                    "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull nReset pin"
+                    "of GNSS 1 low (unused GNSS)");
         gpioHandler(gpioIds::GNSS_SELECT, false,
-            "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull GNSS select low");
+                    "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull GNSS select low");
       }
       break;
     }
@@ -168,13 +168,13 @@ ReturnValue_t AcsBoardAssembly::handleNormalOrOnModeCmd(Mode_t mode, Submode_t s
       cmdSeq(helper.mgm3Rm3100IdSideB, helper.mgm3SideBMode, ModeTableIdx::MGM_3_B);
       if (gpsUsable) {
         gpioHandler(gpioIds::GNSS_0_NRESET, false,
-            "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull nReset pin"
-            "of GNSS 0 low (unused GNSS)");
+                    "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull nReset pin"
+                    "of GNSS 0 low (unused GNSS)");
         gpioHandler(gpioIds::GNSS_1_NRESET, true,
-            "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull nReset pin"
-             "of GNSS 1 high (used GNSS)");
+                    "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull nReset pin"
+                    "of GNSS 1 high (used GNSS)");
         gpioHandler(gpioIds::GNSS_SELECT, true,
-            "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull GNSS select high");
+                    "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull GNSS select high");
       }
       break;
     }
@@ -191,11 +191,11 @@ ReturnValue_t AcsBoardAssembly::handleNormalOrOnModeCmd(Mode_t mode, Submode_t s
       ReturnValue_t status = RETURN_OK;
       if (gpsUsable) {
         gpioHandler(gpioIds::GNSS_0_NRESET, true,
-            "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull nReset pin"
-            "of GNSS 0 high (used GNSS)");
+                    "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull nReset pin"
+                    "of GNSS 0 high (used GNSS)");
         gpioHandler(gpioIds::GNSS_1_NRESET, true,
-            "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull nReset pin"
-             "of GNSS 1 high (used GNSS)");
+                    "AcsBoardAssembly::handleNormalOrOnModeCmd: Could not pull nReset pin"
+                    "of GNSS 1 high (used GNSS)");
         if (defaultSubmode == Submodes::A_SIDE) {
           status = gpioIF->pullLow(gpioIds::GNSS_SELECT);
         } else {
@@ -245,7 +245,7 @@ void AcsBoardAssembly::selectGpsInDualMode(duallane::Submodes side) {
 
 void AcsBoardAssembly::gpioHandler(gpioId_t gpio, bool high, std::string error) {
   ReturnValue_t result = RETURN_OK;
-  if(high) {
+  if (high) {
     result = gpioIF->pullHigh(gpio);
   } else {
     result = gpioIF->pullLow(gpio);