Merge remote-tracking branch 'origin/develop' into feature_i2c_fatal_error_counter

bsp_q7s/core/CoreController.cpp

@@ -32,8 +32,15 @@ xsc::Chip CoreController::CURRENT_CHIP = xsc::Chip::NO_CHIP;
 xsc::Copy CoreController::CURRENT_COPY = xsc::Copy::NO_COPY;
 
 CoreController::CoreController(object_id_t objectId, const std::atomic_uint16_t& i2cErrors)
-    : ExtendedControllerBase(objectId, 5), opDivider5(5), opDivider10(10), hkSet(this),
+    : ExtendedControllerBase(objectId, 5),
+      cmdExecutor(4096),
+      cmdReplyBuf(4096, true),
+      cmdRepliesSizes(128),
+      opDivider5(5),
+      opDivider10(10),
+      hkSet(this),
       i2cErrors(i2cErrors) {
+  cmdExecutor.setRingBuffer(&cmdReplyBuf, &cmdRepliesSizes);
   try {
     sdcMan = SdCardManager::instance();
     if (sdcMan == nullptr) {
@@ -101,11 +108,26 @@ void CoreController::performControlOperation() {
   sdStateMachine();
   performMountedSdCardOperations();
   readHkData();
+<<<<<<< HEAD
   if(i2cErrors >= 5) {
     bool protOpPerformed = false;
     triggerEvent(I2C_UNAVAILABLE_REBOOT);
     gracefulShutdownTasks(CURRENT_CHIP, CURRENT_COPY, protOpPerformed);
     std::system("xsc_boot_copy -r");
+=======
+  if (shellCmdIsExecuting) {
+    bool replyReceived = false;
+    // TODO: We could read the data in the ring buffer and send it as an action data reply.
+    if (cmdExecutor.check(replyReceived) == CommandExecutor::EXECUTION_FINISHED) {
+      actionHelper.finish(true, successRecipient, EXECUTE_SHELL_CMD);
+      shellCmdIsExecuting = false;
+      cmdReplyBuf.clear();
+      while (not cmdRepliesSizes.empty()) {
+        cmdRepliesSizes.pop();
+      }
+      successRecipient = MessageQueueIF::NO_QUEUE;
+    }
+>>>>>>> origin/develop
   }
   opDivider5.checkAndIncrement();
   opDivider10.checkAndIncrement();
@@ -308,6 +330,21 @@ ReturnValue_t CoreController::executeAction(ActionId_t actionId, MessageQueueId_
       // Warning: This function will never return, because it reboots the system
       return actionReboot(data, size);
     }
+    case (EXECUTE_SHELL_CMD): {
+      std::string cmd = std::string(cmd, size);
+      if (cmdExecutor.getCurrentState() == CommandExecutor::States::PENDING or
+          shellCmdIsExecuting) {
+        return HasActionsIF::IS_BUSY;
+      }
+      cmdExecutor.load(cmd, false, false);
+      ReturnValue_t result = cmdExecutor.execute();
+      if (result != returnvalue::OK) {
+        return result;
+      }
+      shellCmdIsExecuting = true;
+      successRecipient = commandedBy;
+      return returnvalue::OK;
+    }
     default: {
       return HasActionsIF::INVALID_ACTION_ID;
     }

bsp_q7s/core/CoreController.h

@@ -1,6 +1,8 @@
 #ifndef BSP_Q7S_CORE_CORECONTROLLER_H_
 #define BSP_Q7S_CORE_CORECONTROLLER_H_
 
+#include <fsfw/container/DynamicFIFO.h>
+#include <fsfw/container/SimpleRingBuffer.h>
 #include <fsfw/globalfunctions/PeriodicOperationDivider.h>
 #include <libxiphos.h>
 
@@ -99,6 +101,8 @@ class CoreController : public ExtendedControllerBase {
   //! Reboot using the reboot command
   static constexpr ActionId_t REBOOT_OBC = 34;
 
+  static constexpr ActionId_t EXECUTE_SHELL_CMD = 40;
+
   static constexpr uint8_t SUBSYSTEM_ID = SUBSYSTEM_ID::CORE;
 
   static constexpr Event ALLOC_FAILURE = event::makeEvent(SUBSYSTEM_ID, 0, severity::MEDIUM);
@@ -229,6 +233,13 @@ class CoreController : public ExtendedControllerBase {
   } sdCommandingInfo;
 
   RebootFile rebootFile = {};
+
+  CommandExecutor cmdExecutor;
+  SimpleRingBuffer cmdReplyBuf;
+  DynamicFIFO<uint16_t> cmdRepliesSizes;
+  bool shellCmdIsExecuting = false;
+  MessageQueueId_t successRecipient = MessageQueueIF::NO_QUEUE;
+
   std::string currMntPrefix;
   bool timeFileInitDone = false;
   bool performOneShotSdCardOpsSwitch = false;

bsp_q7s/core/ObjectFactory.cpp

@@ -68,12 +68,17 @@
 #include "mission/tmtc/tmFilters.h"
 #include "mission/utility/GlobalConfigHandler.h"
 #include "tmtc/pusIds.h"
+
+using gpio::Direction;
+using gpio::Levels;
 #if OBSW_TEST_LIBGPIOD == 1
 #include "linux/boardtest/LibgpiodTest.h"
 #endif
 #include <mission/devices/GyrAdis1650XHandler.h>
 #include <mission/devices/ImtqHandler.h>
 #include <mission/devices/PcduHandler.h>
+#include <mission/devices/Pdu1Handler.h>
+#include <mission/devices/Pdu2Handler.h>
 #include <mission/devices/SyrlinksHandler.h>
 #include <mission/devices/devicedefinitions/rwHelpers.h>
 #include <mission/tmtc/VirtualChannelWithQueue.h>
@@ -102,8 +107,6 @@
 #include "mission/devices/HeaterHandler.h"
 #include "mission/devices/Max31865PT1000Handler.h"
 #include "mission/devices/P60DockHandler.h"
-#include "mission/devices/PDU1Handler.h"
-#include "mission/devices/PDU2Handler.h"
 #include "mission/devices/PayloadPcduHandler.h"
 #include "mission/devices/RadiationSensorHandler.h"
 #include "mission/devices/RwHandler.h"
@@ -194,17 +197,17 @@ void ObjectFactory::createPcduComponents(LinuxLibgpioIF* gpioComIF, PowerSwitchI
       new P60DockHandler(objects::P60DOCK_HANDLER, objects::CSP_COM_IF, p60DockCspCookie, p60Fdir);
 
   auto pdu1Fdir = new GomspacePowerFdir(objects::PDU1_HANDLER);
-  PDU1Handler* pdu1handler =
-      new PDU1Handler(objects::PDU1_HANDLER, objects::CSP_COM_IF, pdu1CspCookie, pdu1Fdir);
+  Pdu1Handler* pdu1handler =
+      new Pdu1Handler(objects::PDU1_HANDLER, objects::CSP_COM_IF, pdu1CspCookie, pdu1Fdir);
 
   auto pdu2Fdir = new GomspacePowerFdir(objects::PDU2_HANDLER);
-  PDU2Handler* pdu2handler =
-      new PDU2Handler(objects::PDU2_HANDLER, objects::CSP_COM_IF, pdu2CspCookie, pdu2Fdir);
+  Pdu2Handler* pdu2handler =
+      new Pdu2Handler(objects::PDU2_HANDLER, objects::CSP_COM_IF, pdu2CspCookie, pdu2Fdir);
 
   auto acuFdir = new GomspacePowerFdir(objects::ACU_HANDLER);
   ACUHandler* acuhandler =
       new ACUHandler(objects::ACU_HANDLER, objects::CSP_COM_IF, acuCspCookie, acuFdir);
-  auto pcduHandler = new PCDUHandler(objects::PCDU_HANDLER, 50);
+  auto pcduHandler = new PcduHandler(objects::PCDU_HANDLER, 50);
 
   /**
    * Setting PCDU devices to mode normal immediately after start up because PCDU is always
@@ -255,106 +258,110 @@ ReturnValue_t ObjectFactory::createRadSensorComponent(LinuxLibgpioIF* gpioComIF,
   return returnvalue::OK;
 }
 
-void ObjectFactory::createAcsBoardComponents(SpiComIF& spiComIF, LinuxLibgpioIF* gpioComIF,
-                                             SerialComIF* uartComIF, PowerSwitchIF& pwrSwitcher) {
-  using namespace gpio;
-  GpioCookie* gpioCookieAcsBoard = new GpioCookie();
-
+void ObjectFactory::createAcsBoardGpios(GpioCookie& cookie) {
   std::stringstream consumer;
   GpiodRegularByLineName* gpio = nullptr;
   consumer << "0x" << std::hex << objects::GYRO_0_ADIS_HANDLER;
   gpio = new GpiodRegularByLineName(q7s::gpioNames::GYRO_0_ADIS_CS, consumer.str(), Direction::OUT,
                                     Levels::HIGH);
-  gpioCookieAcsBoard->addGpio(gpioIds::GYRO_0_ADIS_CS, gpio);
+  cookie.addGpio(gpioIds::GYRO_0_ADIS_CS, gpio);
 
   consumer.str("");
   consumer << "0x" << std::hex << objects::GYRO_1_L3G_HANDLER;
   gpio = new GpiodRegularByLineName(q7s::gpioNames::GYRO_1_L3G_CS, consumer.str(), Direction::OUT,
                                     Levels::HIGH);
-  gpioCookieAcsBoard->addGpio(gpioIds::GYRO_1_L3G_CS, gpio);
+  cookie.addGpio(gpioIds::GYRO_1_L3G_CS, gpio);
 
   consumer.str("");
   consumer << "0x" << std::hex << objects::GYRO_2_ADIS_HANDLER;
   gpio = new GpiodRegularByLineName(q7s::gpioNames::GYRO_2_ADIS_CS, consumer.str(), Direction::OUT,
                                     Levels::HIGH);
-  gpioCookieAcsBoard->addGpio(gpioIds::GYRO_2_ADIS_CS, gpio);
+  cookie.addGpio(gpioIds::GYRO_2_ADIS_CS, gpio);
 
   consumer.str("");
   consumer << "0x" << std::hex << objects::GYRO_3_L3G_HANDLER;
   gpio = new GpiodRegularByLineName(q7s::gpioNames::GYRO_3_L3G_CS, consumer.str(), Direction::OUT,
                                     Levels::HIGH);
-  gpioCookieAcsBoard->addGpio(gpioIds::GYRO_3_L3G_CS, gpio);
+  cookie.addGpio(gpioIds::GYRO_3_L3G_CS, gpio);
 
   consumer.str("");
   consumer << "0x" << std::hex << objects::MGM_0_LIS3_HANDLER;
   gpio = new GpiodRegularByLineName(q7s::gpioNames::MGM_0_CS, consumer.str(), Direction::OUT,
                                     Levels::HIGH);
-  gpioCookieAcsBoard->addGpio(gpioIds::MGM_0_LIS3_CS, gpio);
+  cookie.addGpio(gpioIds::MGM_0_LIS3_CS, gpio);
 
   consumer.str("");
   consumer << "0x" << std::hex << objects::MGM_1_RM3100_HANDLER;
   gpio = new GpiodRegularByLineName(q7s::gpioNames::MGM_1_CS, consumer.str(), Direction::OUT,
                                     Levels::HIGH);
-  gpioCookieAcsBoard->addGpio(gpioIds::MGM_1_RM3100_CS, gpio);
+  cookie.addGpio(gpioIds::MGM_1_RM3100_CS, gpio);
 
   consumer.str("");
   consumer << "0x" << std::hex << objects::MGM_2_LIS3_HANDLER;
   gpio = new GpiodRegularByLineName(q7s::gpioNames::MGM_2_CS, consumer.str(), Direction::OUT,
                                     Levels::HIGH);
-  gpioCookieAcsBoard->addGpio(gpioIds::MGM_2_LIS3_CS, gpio);
+  cookie.addGpio(gpioIds::MGM_2_LIS3_CS, gpio);
 
   consumer.str("");
   consumer << "0x" << std::hex << objects::MGM_3_RM3100_HANDLER;
   gpio = new GpiodRegularByLineName(q7s::gpioNames::MGM_3_CS, consumer.str(), Direction::OUT,
                                     Levels::HIGH);
-  gpioCookieAcsBoard->addGpio(gpioIds::MGM_3_RM3100_CS, gpio);
+  cookie.addGpio(gpioIds::MGM_3_RM3100_CS, gpio);
 
   consumer.str("");
   consumer << "0x" << std::hex << objects::GPS_CONTROLLER;
   // GNSS reset pins are active low
   gpio = new GpiodRegularByLineName(q7s::gpioNames::RESET_GNSS_0, consumer.str(), Direction::OUT,
                                     Levels::HIGH);
-  gpioCookieAcsBoard->addGpio(gpioIds::GNSS_0_NRESET, gpio);
+  cookie.addGpio(gpioIds::GNSS_0_NRESET, gpio);
 
   consumer.str("");
   consumer << "0x" << std::hex << objects::GPS_CONTROLLER;
   gpio = new GpiodRegularByLineName(q7s::gpioNames::RESET_GNSS_1, consumer.str(), Direction::OUT,
                                     Levels::HIGH);
-  gpioCookieAcsBoard->addGpio(gpioIds::GNSS_1_NRESET, gpio);
+  cookie.addGpio(gpioIds::GNSS_1_NRESET, gpio);
 
   consumer.str("");
   consumer << "0x" << std::hex << objects::GYRO_0_ADIS_HANDLER;
   // Enable pins must be pulled low for regular operations
   gpio = new GpiodRegularByLineName(q7s::gpioNames::GYRO_0_ENABLE, consumer.str(), Direction::OUT,
                                     Levels::LOW);
-  gpioCookieAcsBoard->addGpio(gpioIds::GYRO_0_ENABLE, gpio);
+  cookie.addGpio(gpioIds::GYRO_0_ENABLE, gpio);
 
   consumer.str("");
   consumer << "0x" << std::hex << objects::GYRO_2_ADIS_HANDLER;
   gpio = new GpiodRegularByLineName(q7s::gpioNames::GYRO_2_ENABLE, consumer.str(), Direction::OUT,
                                     Levels::LOW);
-  gpioCookieAcsBoard->addGpio(gpioIds::GYRO_2_ENABLE, gpio);
+  cookie.addGpio(gpioIds::GYRO_2_ENABLE, gpio);
 
   // Enable pins for GNSS
   consumer.str("");
   consumer << "0x" << std::hex << objects::GPS_CONTROLLER;
   gpio = new GpiodRegularByLineName(q7s::gpioNames::GNSS_0_ENABLE, consumer.str(), Direction::OUT,
                                     Levels::LOW);
-  gpioCookieAcsBoard->addGpio(gpioIds::GNSS_0_ENABLE, gpio);
+  cookie.addGpio(gpioIds::GNSS_0_ENABLE, gpio);
 
   consumer.str("");
   consumer << "0x" << std::hex << objects::GPS_CONTROLLER;
   gpio = new GpiodRegularByLineName(q7s::gpioNames::GNSS_1_ENABLE, consumer.str(), Direction::OUT,
                                     Levels::LOW);
-  gpioCookieAcsBoard->addGpio(gpioIds::GNSS_1_ENABLE, gpio);
+  cookie.addGpio(gpioIds::GNSS_1_ENABLE, gpio);
 
   // Select pin. 0 for GPS side A, 1 for GPS side B
   consumer.str("");
   consumer << "0x" << std::hex << objects::GPS_CONTROLLER;
   gpio = new GpiodRegularByLineName(q7s::gpioNames::GNSS_SELECT, consumer.str(), Direction::OUT,
                                     Levels::LOW);
-  gpioCookieAcsBoard->addGpio(gpioIds::GNSS_SELECT, gpio);
+  cookie.addGpio(gpioIds::GNSS_SELECT, gpio);
+}
+
+void ObjectFactory::createAcsBoardComponents(SpiComIF& spiComIF, LinuxLibgpioIF* gpioComIF,
+                                             SerialComIF* uartComIF, PowerSwitchIF& pwrSwitcher) {
+  using namespace gpio;
+  GpioCookie* gpioCookieAcsBoard = new GpioCookie();
+  createAcsBoardGpios(*gpioCookieAcsBoard);
   gpioChecker(gpioComIF->addGpios(gpioCookieAcsBoard), "ACS Board");
+
   AcsBoardFdir* fdir = nullptr;
   static_cast<void>(fdir);
 
@@ -607,7 +614,7 @@ void ObjectFactory::createPayloadComponents(LinuxLibgpioIF* gpioComIF, PowerSwit
   std::stringstream consumer;
   auto* camSwitcher =
       new CamSwitcher(objects::CAM_SWITCHER, pwrSwitch, pcdu::PDU2_CH8_PAYLOAD_CAMERA);
-  camSwitcher->connectModeTreeParent(satsystem::pl::SUBSYSTEM);
+  camSwitcher->connectModeTreeParent(satsystem::payload::SUBSYSTEM);
 #if OBSW_ADD_PLOC_MPSOC == 1
   consumer << "0x" << std::hex << objects::PLOC_MPSOC_HANDLER;
   auto gpioConfigMPSoC = new GpiodRegularByLineName(q7s::gpioNames::ENABLE_MPSOC_UART,
@@ -623,7 +630,7 @@ void ObjectFactory::createPayloadComponents(LinuxLibgpioIF* gpioComIF, PowerSwit
   auto* mpsocHandler = new PlocMPSoCHandler(
       objects::PLOC_MPSOC_HANDLER, objects::UART_COM_IF, mpsocCookie, plocMpsocHelper,
       Gpio(gpioIds::ENABLE_MPSOC_UART, gpioComIF), objects::PLOC_SUPERVISOR_HANDLER);
-  mpsocHandler->connectModeTreeParent(satsystem::pl::SUBSYSTEM);
+  mpsocHandler->connectModeTreeParent(satsystem::payload::SUBSYSTEM);
 #endif /* OBSW_ADD_PLOC_MPSOC == 1 */
 #if OBSW_ADD_PLOC_SUPERVISOR == 1
   consumer << "0x" << std::hex << objects::PLOC_SUPERVISOR_HANDLER;
@@ -640,7 +647,7 @@ void ObjectFactory::createPayloadComponents(LinuxLibgpioIF* gpioComIF, PowerSwit
   auto* supvHandler = new PlocSupervisorHandler(objects::PLOC_SUPERVISOR_HANDLER, supervisorCookie,
                                                 Gpio(gpioIds::ENABLE_SUPV_UART, gpioComIF),
                                                 pcdu::PDU1_CH6_PLOC_12V, *supvHelper);
-  supvHandler->connectModeTreeParent(satsystem::pl::SUBSYSTEM);
+  supvHandler->connectModeTreeParent(satsystem::payload::SUBSYSTEM);
 #endif /* OBSW_ADD_PLOC_SUPERVISOR == 1 */
   static_cast<void>(consumer);
 }
@@ -895,7 +902,7 @@ void ObjectFactory::createPlPcduComponents(LinuxLibgpioIF* gpioComIF, SpiComIF*
   plPcduHandler->setToGoToNormalModeImmediately(true);
   plPcduHandler->enablePeriodicPrintout(true, 10);
 #endif
-  plPcduHandler->connectModeTreeParent(satsystem::pl::SUBSYSTEM);
+  plPcduHandler->connectModeTreeParent(satsystem::payload::SUBSYSTEM);
 }
 
 void ObjectFactory::createTestComponents(LinuxLibgpioIF* gpioComIF) {

bsp_q7s/core/ObjectFactory.h

@@ -58,6 +58,7 @@ void createPlPcduComponents(LinuxLibgpioIF* gpioComIF, SpiComIF* spiComIF,
                             PowerSwitchIF* pwrSwitcher, Stack5VHandler& stackHandler);
 void createTmpComponents();
 ReturnValue_t createRadSensorComponent(LinuxLibgpioIF* gpioComIF, Stack5VHandler& handler);
+void createAcsBoardGpios(GpioCookie& cookie);
 void createAcsBoardComponents(SpiComIF& spiComIF, LinuxLibgpioIF* gpioComIF, SerialComIF* uartComIF,
                               PowerSwitchIF& pwrSwitcher);
 void createHeaterComponents(GpioIF* gpioIF, PowerSwitchIF* pwrSwitcher, HealthTableIF* healthTable,

bsp_q7s/core/scheduling.cpp

@@ -337,9 +337,7 @@ void scheduling::initTasks() {
       "PL_TASK", 30, PeriodicTaskIF::MINIMUM_STACK_SIZE, 0.8, missedDeadlineFunc);
   plTask->addComponent(objects::CAM_SWITCHER);
   scheduling::addMpsocSupvHandlers(plTask);
-#if OBSW_ADD_SCEX_DEVICE == 1
   scheduling::scheduleScexDev(plTask);
-#endif
 
 #if OBSW_ADD_SCEX_DEVICE == 1
   PeriodicTaskIF* scexReaderTask;
@@ -472,9 +470,9 @@ void scheduling::createPstTasks(TaskFactory& factory, TaskDeadlineMissedFunction
 
   /* Polling Sequence Table Default */
 #if OBSW_ADD_SPI_TEST_CODE == 0
-  FixedTimeslotTaskIF* spiPst = factory.createFixedTimeslotTask(
-      "MAIN_SPI", 45, PeriodicTaskIF::MINIMUM_STACK_SIZE * 4, 0.5, missedDeadlineFunc);
-  result = pst::pstSpiAndSyrlinks(spiPst);
+  FixedTimeslotTaskIF* syrlinksPst = factory.createFixedTimeslotTask(
+      "SYRLINKS", 45, PeriodicTaskIF::MINIMUM_STACK_SIZE * 4, 0.5, missedDeadlineFunc);
+  result = pst::pstSyrlinks(syrlinksPst);
   if (result != returnvalue::OK) {
     if (result == FixedTimeslotTaskIF::SLOT_LIST_EMPTY) {
       sif::warning << "scheduling::initTasks: SPI PST is empty" << std::endl;
@@ -482,14 +480,14 @@ void scheduling::createPstTasks(TaskFactory& factory, TaskDeadlineMissedFunction
       sif::error << "scheduling::initTasks: Creating SPI PST failed!" << std::endl;
     }
   } else {
-    taskVec.push_back(spiPst);
+    taskVec.push_back(syrlinksPst);
   }
 #endif
 
 #if OBSW_ADD_I2C_TEST_CODE == 0
   FixedTimeslotTaskIF* i2cPst = factory.createFixedTimeslotTask(
-      "I2C_PST", 50, PeriodicTaskIF::MINIMUM_STACK_SIZE * 4, 0.2, missedDeadlineFunc);
-  result = pst::pstI2c(i2cPst);
+      "I2C_PST", 50, PeriodicTaskIF::MINIMUM_STACK_SIZE * 4, 0.4, missedDeadlineFunc);
+  result = pst::pstI2cProcessingSystem(i2cPst);
   if (result != returnvalue::OK) {
     if (result == FixedTimeslotTaskIF::SLOT_LIST_EMPTY) {
       sif::warning << "scheduling::initTasks: I2C PST is empty" << std::endl;
@@ -501,9 +499,8 @@ void scheduling::createPstTasks(TaskFactory& factory, TaskDeadlineMissedFunction
   }
 #endif
 
-#if OBSW_ADD_GOMSPACE_PCDU == 1
   FixedTimeslotTaskIF* gomSpacePstTask = factory.createFixedTimeslotTask(
-      "GS_PST_TASK", 65, PeriodicTaskIF::MINIMUM_STACK_SIZE * 4, 1.0, missedDeadlineFunc);
+      "GS_PST_TASK", 65, PeriodicTaskIF::MINIMUM_STACK_SIZE * 4, 0.5, missedDeadlineFunc);
   result = pst::pstGompaceCan(gomSpacePstTask);
   if (result != returnvalue::OK) {
     if (result != FixedTimeslotTaskIF::SLOT_LIST_EMPTY) {
@@ -511,7 +508,6 @@ void scheduling::createPstTasks(TaskFactory& factory, TaskDeadlineMissedFunction
     }
   }
   taskVec.push_back(gomSpacePstTask);
-#endif
 }
 
 void scheduling::createPusTasks(TaskFactory& factory, TaskDeadlineMissedFunction missedDeadlineFunc,