ACS board devs go to on first

CHANGELOG.md

@@ -16,6 +16,11 @@ will consitute of a breaking change warranting a new major release:
 
 # [unreleased]
 
+## Fixed
+
+- Proper Faulty/External Control handling for the dual lane assemblies.
+- ACS board devices: Go to ON mode instead of going to NORMAL mode directly.
+
 ## Changed
 
 - Enabled periodic hosuekeeping generation for release images.

mission/acs/GyrAdis1650XHandler.cpp

@@ -28,11 +28,7 @@ void GyrAdis1650XHandler::doStartUp() {
     }
     if (breakCountdown.hasTimedOut()) {
       updatePeriodicReply(true, adis1650x::REPLY);
-      if (goToNormalMode) {
+      setMode(MODE_ON);
-        setMode(MODE_NORMAL);
-      } else {
-        setMode(MODE_ON);
-      }
       internalState = InternalState::NONE;
     }
   }

mission/acs/GyrAdis1650XHandler.h

@@ -47,7 +47,6 @@ class GyrAdis1650XHandler : public DeviceHandlerBase {
   AdisGyroConfigDataset configDataset;
   double sensitivity = adis1650x::SENSITIVITY_UNSET;
 
-  bool goToNormalMode = false;
   bool warningSwitch = true;
 
   enum class InternalState { NONE, STARTUP, SHUTDOWN };

mission/acs/GyrL3gCustomHandler.cpp

@@ -23,11 +23,7 @@ void GyrL3gCustomHandler::doStartUp() {
 
   if (internalState == InternalState::STARTUP) {
     if (commandExecuted) {
-      if (goNormalModeImmediately) {
+      setMode(MODE_ON);
-        setMode(MODE_NORMAL);
-      } else {
-        setMode(_MODE_TO_ON);
-      }
       internalState = InternalState::NONE;
       commandExecuted = false;
     }

mission/acs/GyrL3gCustomHandler.h

@@ -69,7 +69,6 @@ class GyrL3gCustomHandler : public DeviceHandlerBase {
   bool commandExecuted = false;
 
   uint8_t statusReg = 0;
-  bool goNormalModeImmediately = false;
 
   uint8_t ctrlReg1Value = l3gd20h::CTRL_REG_1_VAL;
   uint8_t ctrlReg2Value = l3gd20h::CTRL_REG_2_VAL;

mission/acs/MgmLis3CustomHandler.cpp

@@ -20,7 +20,7 @@ void MgmLis3CustomHandler::doStartUp() {
   }
   if (internalState == InternalState::STARTUP) {
     if (commandExecuted) {
-      setMode(MODE_NORMAL);
+      setMode(MODE_ON);
       internalState = InternalState::NONE;
       commandExecuted = false;
     }

mission/acs/MgmRm3100CustomHandler.cpp

@@ -25,7 +25,7 @@ void MgmRm3100CustomHandler::doStartUp() {
     if (commandExecuted) {
       commandExecuted = false;
       internalState = InternalState::NONE;
-      setMode(MODE_NORMAL);
+      setMode(MODE_ON);
     }
   }
 }

tmtc

@@ -1 +1 @@
-Subproject commit f6fcb2fb282d79b1e250722eba46a319603b0232
+Subproject commit 333faaa5f70646bfde1101f8e0538505574d1d7e