Catch2 hotfix #177

muellerr · 2022-03-09T09:28:17+01:00

muellerr commented

2022-03-09 09:28:17 +01:00

The cleanest solution would be to specify in the build generation whether unittests or the primary OBSW is built. This is because the one generated Makefile now works for both unittest compilation and cross-compilation, but I don't think CMake was designed for this.

the project call will load the toolchain file, which messes up the regular search paths for CMake modules. Even when one configures the toolchain file to also search in the host path, CMake will rightfully not accept the Catch2 installation, probably because of the architecture missmatch. It probably assumes that the goal is the cross-compilation of the unittest.

Clean solution would be to only call find_package if unittests are built. For this, the cleanest soluton is the one suggested up top: Specify -DBUILD_UNITTESTS=ON during build generation and use that flag.

The cleanest solution would be to specify in the build generation whether unittests or the primary OBSW is built. This is because the one generated Makefile now works for both unittest compilation and cross-compilation, but I don't think CMake was designed for this. the `project` call will load the toolchain file, which messes up the regular search paths for CMake modules. Even when one configures the toolchain file to also search in the host path, CMake will rightfully not accept the Catch2 installation, probably because of the architecture missmatch. It probably assumes that the goal is the cross-compilation of the unittest. Clean solution would be to only call `find_package` if unittests are built. For this, the cleanest soluton is the one suggested up top: Specify `-DBUILD_UNITTESTS=ON` during build generation and use that flag.

muellerr added 1 commit 2022-03-09 09:28:21 +01:00

suppress Catch2 warning

EIVE/eive-obsw/pipeline/head Build queued...

Details

EIVE/eive-obsw/pipeline/pr-develop This commit looks good

Details

39b4393b13

muellerr requested review from meierj 2022-03-09 09:28:26 +01:00

muellerr changed title from ~~suppress Catch2 warning~~ to WIP: suppress Catch2 warning

2022-03-09 09:32:22 +01:00

muellerr removed review request for meierj 2022-03-09 09:32:27 +01:00

muellerr added 1 commit 2022-03-09 09:37:01 +01:00