Heater Handler should break if result != OK #388

New Issue

gaisser · 2023-02-19T15:51:04+01:00

gaisser commented

2023-02-19 15:51:04 +01:00

If receiveMessage is not return_ok (and not empty) it needs to break as well.

void HeaterHandler::readCommandQueue() {
  ReturnValue_t result = returnvalue::OK;
  CommandMessage command;
  do {
    result = commandQueue->receiveMessage(&command);
    if (result == MessageQueueIF::EMPTY) {
      break;
    } else if (result != returnvalue::OK) {
      sif::warning << "HeaterHandler::readCommandQueue: Message reception error" << std::endl;
    }
    result = actionHelper.handleActionMessage(&command);
    if (result == returnvalue::OK) {
      continue;
    }
  } while (result == returnvalue::OK);
}

If receiveMessage is not return_ok (and not empty) it needs to break as well. ``` c++ void HeaterHandler::readCommandQueue() { ReturnValue_t result = returnvalue::OK; CommandMessage command; do { result = commandQueue->receiveMessage(&command); if (result == MessageQueueIF::EMPTY) { break; } else if (result != returnvalue::OK) { sif::warning << "HeaterHandler::readCommandQueue: Message reception error" << std::endl; } result = actionHelper.handleActionMessage(&command); if (result == returnvalue::OK) { continue; } } while (result == returnvalue::OK); } ```

muellerr commented

2023-03-11 15:42:01 +01:00

Fixed

muellerr closed this issue

2023-03-11 15:42:02 +01:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#388