eive/eive-obsw
eive
/
eive-obsw
12
3
Fork 0
Code Issues 3 Pull Requests 1 Releases 117 Wiki Activity

Return value is not handled #534

New Issue
Closed
opened 2023-03-27 23:57:11 +02:00 by gaisser · 2 comments
gaisser commented 2023-03-27 23:57:11 +02:00
Member
Copy Link

6dbb9b5e37/mission/tmtc/VirtualChannelWithQueue.cpp (L43)

There is a missing result = before tmStore.deleteData

https://egit.irs.uni-stuttgart.de/eive/eive-obsw/src/commit/6dbb9b5e37a9586e971cc513cfb63e3028aea1a3/mission/tmtc/VirtualChannelWithQueue.cpp#L43 There is a missing ``result = `` before tmStore.deleteData
muellerr commented 2023-03-28 15:04:33 +02:00
Owner
Copy Link

The possible memory leak on write failures is more worrying. I think it is more important to propagate the write error, but the memory leak will definitely be fixed.

The possible memory leak on write failures is more worrying. I think it is more important to propagate the write error, but the memory leak will definitely be fixed.
muellerr commented 2023-04-04 14:53:28 +02:00
Owner
Copy Link

done

done
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
fix-mekf-inits
mpsoc-file-split
try-using-fixed-array-kalman
str-valid-fixes
auto-switch-image-feature
acs-ptg-strat
mohr/introspection
v8.0.0
v7.8.1
v7.8.0
v7.7.4
v7.7.3
v7.7.2
v7.7.1
v7.7.0
v7.6.1
v7.6.0
v7.5.5
v7.5.4
v7.5.3
v7.5.2
v7.5.1
v7.5.0
v7.4.1
v7.4.0
v7.3.0
v7.2.0
v7.1.0
v7.0.0
v6.6.0
v6.5.1
v6.5.0
v6.4.1
v6.4.0
v6.3.0
v6.2.0
v6.1.0
v6.0.0
v5.2.0
v5.1.0
v5.0.0
v3.3.1
v4.0.1
v4.0.0
v3.3.0
v3.2.0
v3.1.1
v3.1.0
v3.0.0
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v2.0.0
v1.45.0
v1.44.1
v1.44.0
v1.43.2
v1.43.1
v1.43.0
v1.42.0
v1.41.0
v1.40.0
v1.39.1
v1.39.0
v1.38.0
v1.37.2
v1.37.1
v1.37.0
v1.36.0
v1.35.1
v1.35.0
v1.34.0
v1.33.0
v1.32.0
v1.31.1
v1.31.0
v1.30.0
v1.29.1
v1.29.0
v1.28.1
v1.28.0
v1.27.2
v1.27.1
v1.27.0
v1.26.4
v1.26.3
v1.26.2
v1.26.1
v1.26.0
v1.25.0
v1.24.0
v1.23.1
v1.23.0
v1.22.1
v1.22.0
v1.21.0
v1.20.0
v1.19.0
v1.18.0
v1.17.0
v1.16.0
v1.15.0
v1.14.1
v1.14.0
v1.13.0
v1.12.1
v1.12.0
docker_d5
v1.11.0
v1.10.1
v1.10.0
docker_d4
docker_d3
v1.9.1
v1.9.0
docker_d2
v1.8.0
v1.7.0
v1.6.1
v1.6.0
v1.5.0
v1.4.0
v1.3.0
v1.2.0
v1.1.0
v1.0.0
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#534
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?