eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

TMP1075 two's complement bugfix #681

Merged
meggert merged 4 commits from tmp-sign-bugfix into main 2023-06-14 21:07:42 +02:00
Conversation 1 Commits 4 Files Changed 2 +12 -2
muellerr commented 2023-06-14 18:09:26 +02:00
Owner
Copy Link

The TMP1075 contained a datasheet with example values. The fixed conversion was verified using those example values. This is a regular two's complement conversion, but one actually has to know what they're doing because it's a retarded 12-bit MSB first two complement..

The TMP1075 contained a datasheet with example values. The fixed conversion was verified using those example values. This is a regular two's complement conversion, but one actually has to know what they're doing because it's a retarded 12-bit MSB first two complement..
muellerr added 2 commits 2023-06-14 18:09:28 +02:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
38305e723f
muellerr added 1 commit 2023-06-14 18:11:16 +02:00
Merge remote-tracking branch 'origin/main' into tmp-sign-bugfix
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
a05a8ffb50
muellerr requested review from meggert 2023-06-14 18:11:19 +02:00
muellerr added this to the v3.1.1 milestone 2023-06-14 18:11:41 +02:00
muellerr removed review request for meggert 2023-06-14 18:41:38 +02:00
muellerr changed title from TMP1075 two's complement bugfix to WIP: TMP1075 two's complement bugfix 2023-06-14 18:46:14 +02:00
muellerr added 1 commit 2023-06-14 18:51:04 +02:00
perform proper sign extension
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
12bc9268f7
muellerr changed title from WIP: TMP1075 two's complement bugfix to TMP1075 two's complement bugfix 2023-06-14 18:51:31 +02:00
muellerr requested review from meggert 2023-06-14 18:51:34 +02:00
muellerr added the
bug
 label 2023-06-14 19:10:55 +02:00
meggert approved these changes 2023-06-14 21:07:30 +02:00
meggert merged commit 05738d1e25 into main 2023-06-14 21:07:42 +02:00
meggert deleted branch tmp-sign-bugfix 2023-06-14 21:07:43 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
meggert
Labels
Clear labels
OPS TODO
Issues identified by OPS
api change
API change
breaking api change
API change which can break existing code
bug
Something is not working
documentation
Documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
bug
Milestone
No items
No Milestone v3.1.1
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eive/eive-obsw#681
No description provided.
Delete Branch "tmp-sign-bugfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?