eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

set dataset invalid on OFF mode #726

Merged
muellerr merged 3 commits from tmp-1075-set-sets-invalid into main 2023-07-06 14:27:06 +02:00
Conversation 0 Commits 3 Files Changed 3 +15 -3
muellerr commented 2023-07-05 16:46:41 +02:00
Owner
Copy Link
No description provided.
muellerr added 1 commit 2023-07-05 16:46:43 +02:00
set dataset invalid on OFF mode
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
cd9cb48b04
muellerr requested review from meggert 2023-07-05 16:49:48 +02:00
muellerr added this to the v6.1.0 milestone 2023-07-05 17:00:36 +02:00
muellerr added 1 commit 2023-07-05 17:20:49 +02:00
small fix/tweaks
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
52eba5cae6
meggert requested changes 2023-07-06 10:54:37 +02:00
mission/tcs/Tmp1075Handler.cpp Outdated
@ -19,6 +19,7 @@ void Tmp1075Handler::doStartUp() {
void Tmp1075Handler::doShutDown() {
communicationStep = CommunicationStep::START_ADC_CONVERSION;
dataset.setValidity(false, true);
meggert commented 2023-07-06 10:53:36 +02:00
Owner
Copy Link

PoolReadGuard missing for commit

`PoolReadGuard` missing for commit
meggert marked this conversation as resolved
muellerr added 1 commit 2023-07-06 13:57:08 +02:00
pool read guard
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
f4f365b110
meggert approved these changes 2023-07-06 14:08:29 +02:00
muellerr merged commit 0c47513e98 into main 2023-07-06 14:27:06 +02:00
muellerr deleted branch tmp-1075-set-sets-invalid 2023-07-06 14:27:06 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
meggert
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
v6.1.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#726
No description provided.
Delete Branch "tmp-1075-set-sets-invalid"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?