eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

EIVE System Reboot Logic #762

New Issue
Closed
opened 2023-07-31 10:45:43 +02:00 by meggert · 2 comments
meggert commented 2023-07-31 10:45:43 +02:00
Owner
Copy Link

The error handling within EIVE System leading to a reboot calls the sendFullRebootCommand() function. This function will not only reboot, but boot onto the image 0 0. I don't think this is actually what we want here. A reboot self should be sufficient, especially given that our image 0 0 will lag behind for the foreseeable future.

Maybe we should also add a delay between triggering the reboot event and the actual reboot, to ensure that the event can be triggered and stored before actaully rebooting.

The error handling within [EIVE System](https://egit.irs.uni-stuttgart.de/eive/eive-obsw/src/branch/main/mission/system/EiveSystem.cpp) leading to a reboot calls the `sendFullRebootCommand()` function. This function will not only reboot, but boot onto the image 0 0. I don't think this is actually what we want here. A reboot self should be sufficient, especially given that our image 0 0 will lag behind for the foreseeable future. Maybe we should also add a delay between triggering the reboot event and the actual reboot, to ensure that the event can be triggered and stored before actaully rebooting.
muellerr was assigned by meggert 2023-07-31 10:45:43 +02:00
muellerr commented 2023-08-01 09:06:11 +02:00
Owner
Copy Link

I think reboot self is better here as well. I would keep the reboot until the PDEC issue is understood bette. A delay sounds reasonable.

I think reboot self is better here as well. I would keep the reboot until the PDEC issue is understood bette. A delay sounds reasonable.
muellerr commented 2023-11-30 15:49:02 +01:00
Owner
Copy Link

This was fixed, including the PDEC bug itself.

This was fixed, including the PDEC bug itself.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
muellerr
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#762
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?