eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

PL PCDU tweaks #766

Merged
muellerr merged 12 commits from pl-pcdu-tweaks into main 2023-08-03 13:07:11 +02:00
Conversation 1 Commits 12 Files Changed 9 +110 -77
muellerr commented 2023-08-02 14:10:55 +02:00
Owner
Copy Link
No description provided.
muellerr added 3 commits 2023-08-02 14:10:57 +02:00
tweaks for pin handling
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
0bbcfb34e8
more robust code
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
a88725070b
add PL PCDU for EM
Some checks are pending
EIVE/eive-obsw/pipeline/head Build started...
Details
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
eae63a8dc9
muellerr added 1 commit 2023-08-02 14:17:38 +02:00
logiically it works..
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
b23ae2e152
muellerr added 1 commit 2023-08-02 15:29:18 +02:00
that should do the job
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
d2c0c1709e
muellerr added this to the v6.3.0 milestone 2023-08-02 15:30:59 +02:00
muellerr added 1 commit 2023-08-03 09:23:56 +02:00
Merge branch 'main' into pl-pcdu-tweaks
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
a0e4f0a438
muellerr added 1 commit 2023-08-03 09:59:30 +02:00
re-introduce proper bounds checking
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
093f7f3a31
muellerr added 1 commit 2023-08-03 10:05:17 +02:00
set set to 0 for OFF cmd
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
1f02c0ef57
muellerr added 1 commit 2023-08-03 10:06:12 +02:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
6f8ad08e9b
muellerr changed title from WIP: PL PCDU tweaks to PL PCDU tweaks 2023-08-03 10:13:26 +02:00
muellerr requested review from meggert 2023-08-03 10:13:30 +02:00
muellerr added 1 commit 2023-08-03 10:16:15 +02:00
this is more correct
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
7c3329abb2
muellerr added 1 commit 2023-08-03 10:16:56 +02:00
changelog typo
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
97f40232d7
meggert approved these changes 2023-08-03 11:49:28 +02:00
mission/payload/PayloadPcduHandler.cpp Outdated
@ -67,0 +69,4 @@
{
PoolReadGuard pg(&adcSet);
adcSet.setReportingEnabled(false);
adcSet.tempC = 0;
meggert commented 2023-08-03 11:46:31 +02:00
Owner
Copy Link

use the invalid temp constexpr instead?

use the invalid temp constexpr instead?
muellerr marked this conversation as resolved
mission/payload/PayloadPcduHandler.cpp Outdated
@ -379,2 +386,3 @@
adcState = AdcStates::OFF;
adcState = AdcState::OFF;
if (startTransitionToOff) {
sif::debug << "transition back to off" << std::endl;
meggert commented 2023-08-03 11:48:10 +02:00
Owner
Copy Link

do we want to keep the debug printout?

do we want to keep the debug printout?
muellerr marked this conversation as resolved
mission/payload/PayloadPcduHandler.cpp Outdated
@ -380,2 +387,4 @@
if (startTransitionToOff) {
sif::debug << "transition back to off" << std::endl;
startTransition(MODE_OFF, 0);
sif::debug << "blubwapfwa" << std::endl;
meggert commented 2023-08-03 11:48:41 +02:00
Owner
Copy Link

blabliblub

blabliblub
muellerr marked this conversation as resolved
muellerr added 1 commit 2023-08-03 13:04:29 +02:00
tweaks
Some checks are pending
EIVE/eive-obsw/pipeline/pr-main Build started...
Details
e746c151d3
muellerr merged commit 1267097368 into main 2023-08-03 13:07:11 +02:00
muellerr deleted branch pl-pcdu-tweaks 2023-08-03 13:07:12 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
meggert
Labels
Clear labels
OPS TODO
Issues identified by OPS
api change
API change
breaking api change
API change which can break existing code
bug
Something is not working
documentation
Documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone v6.3.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eive/eive-obsw#766
No description provided.
Delete Branch "pl-pcdu-tweaks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?