eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

Disable Order Check PL PCDU #825

Merged
muellerr merged 10 commits from disable-order-check-plpcdu into main 2023-11-29 15:13:58 +01:00
Conversation 0 Commits 10 Files Changed 5 +112 -63
muellerr commented 2023-11-21 11:30:36 +01:00
Owner
Copy Link

TMTC PR: eive/eive-tmtc#260

TMTC PR: https://egit.irs.uni-stuttgart.de/eive/eive-tmtc/pulls/260
muellerr added 1 commit 2023-11-21 11:30:37 +01:00
this should do the job
Some checks are pending
EIVE/eive-obsw/pipeline/head Build started...
Details
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
ed8f2c75bf
muellerr changed title from Disable Order Check PL PCDU to WIP: Disable Order Check PL PCDU 2023-11-21 11:30:48 +01:00
muellerr added 1 commit 2023-11-21 12:51:45 +01:00
less trashy mode checker
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
949401e247
muellerr added 1 commit 2023-11-21 12:54:40 +01:00
bugfix
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
bd383cfe04
muellerr added this to the v7.4.0 milestone 2023-11-21 16:37:01 +01:00
muellerr added 1 commit 2023-11-27 11:22:47 +01:00
smaller bugfixes
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
c0b4761ba0
muellerr added 1 commit 2023-11-27 12:05:02 +01:00
this should fix the param setting
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
b0f81d1cce
muellerr changed title from WIP: Disable Order Check PL PCDU to Disable Order Check PL PCDU 2023-11-27 12:18:10 +01:00
muellerr requested review from meggert 2023-11-27 12:18:13 +01:00
muellerr added 1 commit 2023-11-27 12:19:05 +01:00
bump tmtc
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
aef8db62b1
muellerr added 1 commit 2023-11-27 12:20:19 +01:00
bump tmtc again
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
f321d7f0b6
muellerr added 1 commit 2023-11-27 15:42:03 +01:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
b987566947
meggert requested changes 2023-11-29 13:14:33 +01:00
mission/payload/PayloadPcduHandler.cpp
@ -428,20 +429,20 @@ void PayloadPcduHandler::checkAdcValues() {
params.getValue(PARAM_KEY_MAP[NEG_V_UPPER_BOUND], upperBound);
if (not checkVoltage(adcSet.processed[U_NEG_V_FB], lowerBound, upperBound,
NEG_V_OUT_OF_BOUNDS)) {
sif::warning << "Negative voltage was out of bounds, went back to OFF" << std::endl;
meggert commented 2023-11-29 13:11:31 +01:00
Owner
Copy Link

shouldn't these also be events?

shouldn't these also be events?
muellerr commented 2023-11-29 14:19:10 +01:00
Author
Owner
Copy Link

I think an event gets triggered in the checker function, checking again..

I think an event gets triggered in the checker function, checking again..
muellerr commented 2023-11-29 14:20:06 +01:00
Author
Owner
Copy Link

can confirm the events already get triggered in checkVoltage and checkCurrent

can confirm the events already get triggered in `checkVoltage` and `checkCurrent`
meggert marked this conversation as resolved
meggert approved these changes 2023-11-29 14:23:54 +01:00
muellerr added 1 commit 2023-11-29 14:56:50 +01:00
Merge remote-tracking branch 'origin/main' into disable-order-check-plpcdu
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
6b6793d93f
muellerr added 1 commit 2023-11-29 15:13:40 +01:00
Merge branch 'main' into disable-order-check-plpcdu
Some checks are pending
EIVE/eive-obsw/pipeline/pr-main Build queued...
Details
e1e8b525b3
muellerr merged commit 4d21d2761f into main 2023-11-29 15:13:58 +01:00
muellerr deleted branch disable-order-check-plpcdu 2023-11-29 15:13:58 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
meggert
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
v7.4.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#825
No description provided.
Delete Branch "disable-order-check-plpcdu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?