GNNS Controller #863

New Issue

meggert · 2024-02-18T13:10:40+01:00

meggert commented

2024-02-18 13:10:40 +01:00

fix has changed event is too spammy
cannot get fix timer handling is just plain wrong as the countdown is only reset on mode change to MODE_ON
GNNS Controller should never be set to MODE_OFF, just because no fix is available
- the GNSS device should be, but the Controller by itself does not know which one is used (also for our broken GNSS this would result in ACS board being in dual side forever)
- changing the mode variable is just plain wrong
- as this controller runs a while-true loop, any mode changes are irrelevant

- fix has changed event is too spammy - cannot get fix timer handling is just plain wrong as the countdown is only reset on mode change to MODE_ON - GNNS Controller should never be set to MODE_OFF, just because no fix is available - the GNSS device should be, but the Controller by itself does not know which one is used (also for our broken GNSS this would result in ACS board being in dual side forever) - changing the mode variable is just plain wrong - as this controller runs a while-true loop, any mode changes are irrelevant

meggert self-assigned this 2024-02-18 13:10:40 +01:00

meggert commented

2024-04-10 08:59:52 +02:00

done in #871

meggert closed this issue

2024-04-10 08:59:53 +02:00

Sign in to join this conversation.