eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

Fused Rotation Rate for Safe Mode #867

Merged
meggert merged 5 commits from fused-rot-rate-safe into main 2024-02-26 13:11:42 +01:00
Conversation 0 Commits 5 Files Changed 5 +18 -12
meggert commented 2024-02-23 14:56:54 +01:00
Owner
Copy Link
No description provided.
meggert added this to the v7.7.0 milestone 2024-02-23 14:56:54 +01:00
meggert added 3 commits 2024-02-23 14:56:55 +01:00
changelog
Some checks are pending
EIVE/eive-obsw/pipeline/head Build started...
Details
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
3313f58905
meggert changed title from WIP: Fused Rotation Rate for Safe Mode to Fused Rotation Rate for Safe Mode 2024-02-26 09:55:57 +01:00
meggert requested review from muellerr 2024-02-26 09:56:03 +01:00
muellerr reviewed 2024-02-26 10:03:05 +01:00
mission/controller/AcsController.cpp Outdated
@ -914,6 +914,9 @@ void AcsController::modeChanged(Mode_t mode, Submode_t submode) {
PoolReadGuard pg(&rw4SpeedSet);
rw4SpeedSet.setRwSpeed(0, 10);
}
modeIsSafe = true;
muellerr commented 2024-02-26 10:02:36 +01:00
Owner
Copy Link

can we use a member function which simply does mode == SAFE to avoid another state variable or would that not work for some reason?

can we use a member function which simply does `mode == SAFE` to avoid another state variable or would that not work for some reason?
meggert commented 2024-02-26 10:15:15 +01:00
Author
Owner
Copy Link

how about this

how about this
muellerr commented 2024-02-26 10:23:09 +01:00
Owner
Copy Link

nice

nice
meggert marked this conversation as resolved
meggert added 1 commit 2024-02-26 10:14:29 +01:00
removed redundant variable
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
96acca4847
muellerr approved these changes 2024-02-26 10:22:53 +01:00
meggert added 1 commit 2024-02-26 13:11:13 +01:00
meggert merged commit 8df720e940 into main 2024-02-26 13:11:42 +01:00
meggert deleted branch fused-rot-rate-safe 2024-02-26 13:11:46 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
muellerr
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
v7.7.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#867
No description provided.
Delete Branch "fused-rot-rate-safe"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?