eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 121 Wiki Activity

TMP1075 two's complement bugfix #681

Merged
meggert merged 4 commits from tmp-sign-bugfix into main 2023-06-14 21:07:42 +02:00
Conversation 1 Commits 4 Files Changed 2 +4 -8
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 12bc9268f7 - Show all commits

12
mission/tcs/Tmp1075Handler.cpp
View File

@ -86,14 +86,10 @@ ReturnValue_t Tmp1075Handler::scanForReply(const uint8_t *start, size_t remainin
ReturnValue_t Tmp1075Handler::interpretDeviceReply(DeviceCommandId_t id, const uint8_t *packet) {
switch (id) {
case TMP1075::GET_TEMP: {
// Ignore the sign bit, subtract it later when applicable.
int16_t tempValueRaw = static_cast<uint16_t>((packet[0] << 8) | packet[1]) & 0x7fff;
// 12 bit value, so perform the shift for correct values.
tempValueRaw >>= 4;
if(((packet[0] >> 7) & 0b1) == 0b1) {
// Perform two's complement by subtracting the sign
tempValueRaw -= 0x800;
}
// Convert 12 bit MSB first raw temperature to 16 bit first.
int16_t tempValueRaw = static_cast<uint16_t>((packet[0] << 8) | packet[1]) >> 4;
// Sign extension to 16 bits: If the sign bit is set, fill up with ones on the left.
tempValueRaw = (packet[0] & 0x80) ? (tempValueRaw | 0xF000) : tempValueRaw;
// 0.0625 is the sensor sensitivity.
float tempValue = ((static_cast<float>(tempValueRaw)) * 0.0625);
#if OBSW_DEBUG_TMP1075 == 1