eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 121 Wiki Activity

PL PCDU tweaks #766

Merged
muellerr merged 12 commits from pl-pcdu-tweaks into main 2023-08-03 13:07:11 +02:00
Conversation 1 Commits 12 Files Changed 9 +110 -77
9 changed files with 110 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e746c151d3 - Show all commits

7
mission/payload/PayloadPcduHandler.cpp
View File

@@ -1,4 +1,5 @@
#include <fsfw/src/fsfw/datapool/PoolReadGuard.h> #include <fsfw/datapool/PoolReadGuard.h>
#include "fsfw/thermal/tcsDefinitions.h"
#include <fsfw/tasks/TaskFactory.h> #include <fsfw/tasks/TaskFactory.h>
#include <mission/payload/PayloadPcduHandler.h> #include <mission/payload/PayloadPcduHandler.h>
@@ -69,7 +70,7 @@ void PayloadPcduHandler::doShutDown() {
{ {
PoolReadGuard pg(&adcSet); PoolReadGuard pg(&adcSet);
adcSet.setReportingEnabled(false); adcSet.setReportingEnabled(false);
muellerr marked this conversation as resolved Outdated
meggert commented 2023-08-03 11:46:31 +02:00
Outdated
Review
Copy Link

use the invalid temp constexpr instead?

use the invalid temp constexpr instead?
adcSet.tempC = 0; adcSet.tempC = thermal::INVALID_TEMPERATURE;
std::memset(adcSet.channels.value, 0, sizeof(adcSet.channels.value)); std::memset(adcSet.channels.value, 0, sizeof(adcSet.channels.value));
std::memset(adcSet.processed.value, 0, sizeof(adcSet.processed.value)); std::memset(adcSet.processed.value, 0, sizeof(adcSet.processed.value));
@@ -385,9 +386,7 @@ void PayloadPcduHandler::quickTransitionBackToOff(bool startTransitionToOff, boo
state = States::STACK_5V_SWITCHING; state = States::STACK_5V_SWITCHING;
adcState = AdcState::OFF; adcState = AdcState::OFF;
if (startTransitionToOff) { if (startTransitionToOff) {
muellerr marked this conversation as resolved Outdated
meggert commented 2023-08-03 11:48:10 +02:00
Outdated
Review
Copy Link

do we want to keep the debug printout?

do we want to keep the debug printout?
sif::debug << "transition back to off" << std::endl;
startTransition(MODE_OFF, 0); startTransition(MODE_OFF, 0);
sif::debug << "blubwapfwa" << std::endl;
} }
muellerr marked this conversation as resolved Outdated
meggert commented 2023-08-03 11:48:41 +02:00
Outdated
Review
Copy Link

blabliblub

blabliblub
if (notifyFdir) { if (notifyFdir) {
triggerEvent(TRANSITION_BACK_TO_OFF, static_cast<uint32_t>(currentState)); triggerEvent(TRANSITION_BACK_TO_OFF, static_cast<uint32_t>(currentState));