eive/fsfw
eive/fsfw
15
1
Fork 0
forked from fsfw/fsfw
Code Issues Pull Requests Releases 1 Wiki Activity

fix unittests

Browse Source
This commit is contained in:
Robin Müller 2022-08-08 18:36:10 +02:00
parent 904abfba28
commit 4f1fe39182
No known key found for this signature in database
GPG Key ID: 71B58F8A3CDFA9AC
3 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
unittests/cfdp/testKeepAlivePdu.cpp
View File

@ -71,9 +71,11 @@ TEST_CASE("Keep Alive PDU", "[cfdp][pdu]") {
// invalid max size // invalid max size
for (size_t invalidMaxSz = 0; invalidMaxSz < sz; invalidMaxSz++) { for (size_t invalidMaxSz = 0; invalidMaxSz < sz; invalidMaxSz++) {
deserializer.setData(kaBuffer.data(), invalidMaxSz); ReturnValue_t setResult = deserializer.setData(kaBuffer.data(), invalidMaxSz);
result = deserializer.parseData(); if (setResult == HasReturnvaluesIF::RETURN_OK) {
REQUIRE(result != HasReturnvaluesIF::RETURN_OK); result = deserializer.parseData();
REQUIRE(result != HasReturnvaluesIF::RETURN_OK);
}
} }
} }
} }

7
unittests/cfdp/testMetadataPdu.cpp
View File

@ -2,6 +2,7 @@
#include <array> #include <array>
#include <catch2/catch_test_macros.hpp> #include <catch2/catch_test_macros.hpp>
#include <iostream>
#include "fsfw/cfdp/pdu/MetadataPduCreator.h" #include "fsfw/cfdp/pdu/MetadataPduCreator.h"
#include "fsfw/cfdp/pdu/MetadataPduReader.h" #include "fsfw/cfdp/pdu/MetadataPduReader.h"
@ -172,8 +173,10 @@ TEST_CASE("Metadata PDU", "[cfdp][pdu]") {
info.setOptionsArray(options.data(), &sizeOfOptions, nullptr); info.setOptionsArray(options.data(), &sizeOfOptions, nullptr);
for (size_t maxSz = 0; maxSz < 46; maxSz++) { for (size_t maxSz = 0; maxSz < 46; maxSz++) {
MetadataPduReader invalidSzDeser(mdBuffer.data(), maxSz, info); MetadataPduReader invalidSzDeser(mdBuffer.data(), maxSz, info);
result = invalidSzDeser.parseData(); if (not invalidSzDeser.isNull()) {
REQUIRE(result == SerializeIF::STREAM_TOO_SHORT); result = invalidSzDeser.parseData();
REQUIRE(result == SerializeIF::STREAM_TOO_SHORT);
}
} }
} }
} }

8
unittests/cfdp/testPromptPdu.cpp
View File

@ -59,9 +59,11 @@ TEST_CASE("Prompt PDU", "[cfdp][pdu]") {
rawBuf[2] = 2; rawBuf[2] = 2;
for (size_t invalidMaxSz = 0; invalidMaxSz < sz; invalidMaxSz++) { for (size_t invalidMaxSz = 0; invalidMaxSz < sz; invalidMaxSz++) {
deserializer.setData(rawBuf.data(), invalidMaxSz); ReturnValue_t setResult = deserializer.setData(rawBuf.data(), invalidMaxSz);
result = deserializer.parseData(); if (setResult == result::OK) {
REQUIRE(result != HasReturnvaluesIF::RETURN_OK); result = deserializer.parseData();
REQUIRE(result != HasReturnvaluesIF::RETURN_OK);
}
} }
} }
} }