fsfw/fsfw-hal
14
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

meier/master #3

Merged
gaisser merged 2 commits from meier/master into master 2021-05-12 10:57:04 +02:00
Conversation 3 Commits 2 Files Changed 3
+18 -9
meierj commented 2021-05-12 10:41:44 +02:00
Owner
Copy Link
Copy Source
No description provided.
meierj added 2 commits 2021-05-12 10:41:45 +02:00
spi mutex only blocked when gpio != NO_GPIO 8a38c7958b
Merge branch 'master' into meier/master 425cfd2aba
gaisser approved these changes 2021-05-12 10:56:53 +02:00
gaisser added the bug label 2021-05-12 10:56:59 +02:00
gaisser merged commit 99ba9d9346 into master 2021-05-12 10:57:04 +02:00
muellerr commented 2021-05-12 17:05:57 +02:00
Owner
Copy Link
Copy Source

The Mutex unlocks as soon as the the scope around the guard ends. This does not protect the whole slave select operation. It would be better to use lock manually (while not forgetting unlock)

The Mutex unlocks as soon as the the scope around the guard ends. This does not protect the whole slave select operation. It would be better to use lock manually (while not forgetting unlock)
gaisser commented 2021-05-12 17:36:16 +02:00
Owner
Copy Link
Copy Source

I thought this was on purpose.

I thought this was on purpose.
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
ahinkel (Andy Hinkel) gaisser (Steffen Gaisser) jenkins_buildfix meierj (Jakob Meier) mohr (Ulrich Mohr) mspahr muellerr (Robin Müller) tbaumgartl (Tobias Baumgartl)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw-hal#3