DHB: Extra PST step #129

New Issue

muellerr · 2020-07-06T16:40:19+02:00

muellerr commented

2020-07-06 16:40:19 +02:00

Maybe I understood something wrong, but I have a qeustion concerning the Polling Sequence Table (PST) for Device handler base (DHB).

If I understood correctly, if there is a device like a gyro which is polled very frequently to satisfy some physical criteria, this is performed in the PST by adding mutliple SEND_READ, GET_READ ... steps in the PST.

But if I see it correctly, SEND_READ does two things here: It performs the communicatinon part (doSendRead()) and also the periodic part of the device handler (e.g. message handling):

if (getComAction() == SEND_WRITE) {
		cookieInfo.state = COOKIE_UNUSED;
		readCommandQueue();
		doStateMachine();
		checkSwitchState();
		decrementDeviceReplyMap();
		fdirInstance->checkForFailures();
		hkSwitcher.performOperation();
		performOperationHook();
	}

Is there a specific reason why the periodic part is not a distinct PST step, for example PERIODIC_OPERATION ?

Maybe I understood something wrong, but I have a qeustion concerning the Polling Sequence Table (PST) for Device handler base (DHB). If I understood correctly, if there is a device like a gyro which is polled very frequently to satisfy some physical criteria, this is performed in the PST by adding mutliple SEND_READ, GET_READ ... steps in the PST. But if I see it correctly, SEND_READ does two things here: It performs the communicatinon part (doSendRead()) and also the periodic part of the device handler (e.g. message handling): ```cpp if (getComAction() == SEND_WRITE) { cookieInfo.state = COOKIE_UNUSED; readCommandQueue(); doStateMachine(); checkSwitchState(); decrementDeviceReplyMap(); fdirInstance->checkForFailures(); hkSwitcher.performOperation(); performOperationHook(); } ``` Is there a specific reason why the periodic part is not a distinct PST step, for example PERIODIC_OPERATION ?

muellerr added the

question

label 2020-07-06 16:40:19 +02:00

gaisser referenced this issue

2020-10-27 15:04:43 +01:00

DHB update #237

gaisser commented

2020-12-01 15:53:22 +01:00

Part of #281

gaisser referenced this issue

2020-12-01 15:53:41 +01:00

DHB additional step for performOperation #281