fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Collect related headers in single task specific headers #148

New Issue
Open
opened 2020-07-21 12:08:15 +02:00 by mohr · 2 comments
mohr commented 2020-07-21 12:08:15 +02:00
Owner
Copy Link

Create headers which include common other headers for a common task, ie create datapool/datapool.h which includes all the headers usually needed if you use the datapool.

This would clean up the include lists.

Create headers which include common other headers for a common task, ie create datapool/datapool.h which includes all the headers usually needed if you use the datapool. This would clean up the include lists.
gaisser changed title from Collect related headers in single trask specific headers to Collect related headers in single task specific headers 2020-10-27 15:08:08 +01:00
gaisser added the
feature
 label 2020-10-27 15:08:15 +01:00
muellerr commented 2021-03-10 16:32:52 +01:00
Owner
Copy Link

I implemented this for the local data pools.

I implemented this for the local data pools.
muellerr commented 2021-07-22 11:11:04 +02:00
Owner
Copy Link

This is being extended as part of #445 . Following files have been added so far

  • fsfw/action.h
  • fsfw/health.h
  • fsfw/datapoollocal.h
  • fsfw/housekeeping.h
  • fsfw/objectmanager.h
  • fsfw/serialize.h
  • fsfw/serviceinterface.h

There is still the architectural question whether these header files are in a separate inc folder our in src. The src folder still needs to be included because the ability to include single files is still required for internal and external purposes (e.g. including containers) so I see no issue putting it into src

This is being extended as part of #445 . Following files have been added so far - `fsfw/action.h` - `fsfw/health.h` - `fsfw/datapoollocal.h` - `fsfw/housekeeping.h` - `fsfw/objectmanager.h` - `fsfw/serialize.h` - `fsfw/serviceinterface.h` There is still the architectural question whether these header files are in a separate `inc` folder our in `src`. The `src` folder still needs to be included because the ability to include single files is still required for internal and external purposes (e.g. including containers) so I see no issue putting it into `src`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
feature
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#148
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?