ServiceInterface changes from #93 do allocate memory at runtime #149

New Issue

gaisser · 2020-07-21T15:10:43+02:00

gaisser commented

2020-07-21 15:10:43 +02:00

The Service Interface stream allocates memory at runtime. It allocates 41 Bytes by returning a copy of a std::string in "getPreamble".

auto preamble = getPreamble(&preambleSize);

The preamble is allocated at construction time as a member of the ServiceInterfaceBuffer so we can return a pointer to it. So, the fix would be to change getPreamble in the ServiceInterfaceBuffer to:

std::string* getPreamble(size_t * preambleSize = nullptr)

The Service Interface stream allocates memory at runtime. It allocates 41 Bytes by returning a copy of a std::string in "getPreamble". ``` C++ auto preamble = getPreamble(&preambleSize); ``` The preamble is allocated at construction time as a member of the ServiceInterfaceBuffer so we can return a pointer to it. So, the fix would be to change getPreamble in the ServiceInterfaceBuffer to: ```C++ std::string* getPreamble(size_t * preambleSize = nullptr) ```

gaisser added the

bug

label 2020-07-21 15:10:43 +02:00

gaisser referenced this issue from a commit

2020-07-21 15:16:31 +02:00

Fixes #149

gaisser referenced a pull request that will close this issue

2020-07-21 15:18:12 +02:00

ServiceInterfaceBuffer Bugfix #149 #150

muellerr closed this issue

2020-07-28 12:51:29 +02:00

Sign in to join this conversation.