fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

Parameter Improvements #250

Merged
gaisser merged 18 commits from KSat/fsfw:mueller/parameter-convergence into development 2020-12-10 17:09:55 +01:00
Conversation 3 Commits 18 Files Changed 7 +265 -130
muellerr commented 2020-11-02 16:02:11 +01:00
Owner
Copy Link

I still need to adapt some documentation. This improves the interface and makes it a lot less confusing (unfortunately, API change..).

Fixes #153 .

I still need to adapt some documentation. This improves the interface and makes it a lot less confusing (unfortunately, API change..). Fixes #153 .
muellerr added the
feature
API Change
 labels 2020-11-02 16:02:11 +01:00
muellerr changed title from WIP: Parameter Improvements to Parameter Improvements 2020-11-10 11:17:32 +01:00
muellerr changed title from Parameter Improvements to WIP: Parameter Improvements 2020-12-01 14:01:58 +01:00
muellerr commented 2020-12-01 14:03:03 +01:00
Author
Owner
Copy Link

UPDATE: I will write API changes into new CHANGELOG file.

UPDATE: I will write API changes into new CHANGELOG file.
gaisser added this to the ASTP 1.0.0 Local pools milestone 2020-12-01 15:39:00 +01:00
muellerr added 1 commit 2020-12-03 13:05:14 +01:00
muellerr added 1 commit 2020-12-03 13:10:43 +01:00
muellerr changed title from WIP: Parameter Improvements to Parameter Improvements 2020-12-03 13:10:59 +01:00
muellerr commented 2020-12-03 13:11:07 +01:00
Author
Owner
Copy Link

CHANGELOG updated

CHANGELOG updated
muellerr added 1 commit 2020-12-03 13:12:03 +01:00
gaisser commented 2020-12-03 18:40:51 +01:00
Owner
Copy Link

Related to #153

Related to #153
muellerr added 1 commit 2020-12-05 11:49:49 +01:00
gaisser added 1 commit 2020-12-08 14:52:23 +01:00
muellerr added 1 commit 2020-12-08 15:51:38 +01:00
muellerr added 1 commit 2020-12-08 15:55:57 +01:00
gaisser added 1 commit 2020-12-10 16:24:21 +01:00
gaisser reviewed 2020-12-10 16:32:42 +01:00
parameters/ParameterWrapper.cpp Outdated
@ -125,3 +125,2 @@
//get the start element of this row in data
T *dataWithDataType = ((T*) data)
+ (((startingRow + fromRow) * columns) + startingColumn);
uint16_t offset = (((startingRow + fromRow) * columns) + startingColumn);
gaisser commented 2020-12-10 16:32:42 +01:00
Owner
Copy Link

The addition on the right side might have an 8bit overflow.

The addition on the right side might have an 8bit overflow.
gaisser marked this conversation as resolved
muellerr added 1 commit 2020-12-10 17:01:12 +01:00
muellerr added 1 commit 2020-12-10 17:02:12 +01:00
muellerr added 1 commit 2020-12-10 17:05:51 +01:00
gaisser merged commit 2c7936cecd into development 2020-12-10 17:09:55 +01:00
gaisser deleted branch mueller/parameter-convergence 2020-12-10 17:10:01 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
ASTP 1.0.0 Local pools
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#250
No description provided.
Delete Branch "KSat/fsfw:mueller/parameter-convergence"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?