Datapool Updates, fixes and improvements #334

muellerr · 2020-12-28T17:57:43+01:00

muellerr commented

2020-12-28 17:57:43 +01:00

Also, new RAII conformant reader class to read and commit to datapool variables and datasets.

muellerr added the

feature

label 2020-12-28 17:57:43 +01:00

muellerr added 1 commit 2020-12-28 17:57:43 +01:00

datapool updates, fixes, pool read helper 91cb061da9

muellerr referenced this pull request

2020-12-28 18:03:27 +01:00

FSFW Update #333

muellerr referenced this pull request

2020-12-28 18:16:55 +01:00

Bundled FSFW Update #337

gaisser approved these changes 2021-01-12 13:26:04 +01:00

gaisser left a comment

A few questions:

setReadCommitProtectionBehaviour is ment to be called by the user in LocalDataPoolManager? Who wants to call that? Who doesn't?

A few questions: setReadCommitProtectionBehaviour is ment to be called by the user in LocalDataPoolManager? Who wants to call that? Who doesn't?

datapool/PoolDataSetBase.cpp

						
				@ -39,3 +41,3 @@

							result = readVariable(count);

							if(result != RETURN_OK) {

								break;

								error = result;

gaisser commented

2021-01-12 12:47:39 +01:00

This reports only the last error in the loop. Is any value valid in the set after reading one with an error? We still don't know where the error happened.

datapool/PoolDataSetBase.cpp

						
				@ -112,3 +129,3 @@

								&& registeredVariables[count]->getDataPoolId()

								!= PoolVariableIF::NO_PARAMETER) {

							registeredVariables[count]->commitWithoutLock();

							if(protectEveryReadCommitCall) {

gaisser commented

2021-01-12 12:51:13 +01:00

"protectEveryReadCommitCall" but this is a write call.

datapool/ReadCommitIF.h

						
				@ -0,0 +19,4 @@

					//! members with commit and read semantics where the lock is only necessary

					//! once.

					virtual ReturnValue_t readWithoutLock()  {

						return read(20);