fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Datapool Updates, fixes and improvements #334

Manually merged
muellerr merged 2 commits from mueller/datapool-update into development 2021-01-12 15:27:15 +01:00
Conversation 1 Commits 2 Files Changed 12 +191 -92
muellerr commented 2020-12-28 17:57:43 +01:00
Owner
Copy Link

Also, new RAII conformant reader class to read and commit to datapool variables and datasets.

Also, new RAII conformant reader class to read and commit to datapool variables and datasets.
muellerr added the
feature
 label 2020-12-28 17:57:43 +01:00
muellerr added 1 commit 2020-12-28 17:57:43 +01:00
datapool updates, fixes, pool read helper 91cb061da9
gaisser approved these changes 2021-01-12 13:26:04 +01:00
gaisser left a comment
Owner
Copy Link

A few questions:

setReadCommitProtectionBehaviour is ment to be called by the user in LocalDataPoolManager? Who wants to call that? Who doesn't?

A few questions: setReadCommitProtectionBehaviour is ment to be called by the user in LocalDataPoolManager? Who wants to call that? Who doesn't?
datapool/PoolDataSetBase.cpp
@ -39,3 +41,3 @@
result = readVariable(count);
if(result != RETURN_OK) {
break;
error = result;
gaisser commented 2021-01-12 12:47:39 +01:00
Owner
Copy Link

This reports only the last error in the loop. Is any value valid in the set after reading one with an error? We still don't know where the error happened.

This reports only the last error in the loop. Is any value valid in the set after reading one with an error? We still don't know where the error happened.
datapool/PoolDataSetBase.cpp
@ -112,3 +129,3 @@
&& registeredVariables[count]->getDataPoolId()
!= PoolVariableIF::NO_PARAMETER) {
registeredVariables[count]->commitWithoutLock();
if(protectEveryReadCommitCall) {
gaisser commented 2021-01-12 12:51:13 +01:00
Owner
Copy Link

"protectEveryReadCommitCall" but this is a write call.

"protectEveryReadCommitCall" but this is a write call.
datapool/ReadCommitIF.h
@ -0,0 +19,4 @@
//! members with commit and read semantics where the lock is only necessary
//! once.
virtual ReturnValue_t readWithoutLock() {
return read(20);
gaisser commented 2021-01-12 12:58:13 +01:00
Owner
Copy Link

I don't get that. This looks like a call with a lock with a fixed 20 (ms) timeout.

I don't get that. This looks like a call with a lock with a fixed 20 (ms) timeout.
gaisser added 1 commit 2021-01-12 15:07:07 +01:00
Merge branch 'development' into mueller/datapool-update a89d9eab36
gaisser added this to the ASTP 1.0.0 Local pools milestone 2021-01-12 15:08:27 +01:00
gaisser self-assigned this 2021-01-12 15:08:30 +01:00
muellerr manually merged commit 7a3ba06b01 into development 2021-01-12 15:27:15 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
feature
Milestone
No items
No Milestone ASTP 1.0.0 Local pools
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees gaisser
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#334
No description provided.
Delete Branch "mueller/datapool-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?