Update SerialBufferAdapter #37

New Issue

mohr · 2020-04-17T17:47:43+02:00

mohr commented

2020-04-17 17:47:43 +02:00

Add Template parameter for element type.
This would allow (de)serializing arrays of arbitrary type but also need to respect endianness.

Add Template parameter for element type. This would allow (de)serializing arrays of arbitrary type but also need to respect endianness.

mohr added the

feature

label 2020-04-17 17:58:01 +02:00

mohr commented

2020-04-17 17:58:13 +02:00

If the proposed parameter is added as second parameter with a default value, existing code should be still correct.

The current implementation is not header-only, which would need to be changed to allow arbitrary and not only preselected types. Right now, I do not see a reason not to change it to header-only.

If the proposed parameter is added as second parameter with a default value, existing code should be still correct. The current implementation is **not** header-only, which would need to be changed to allow arbitrary and not only preselected types. Right now, I do not see a reason not to change it to header-only.

mohr commented

2020-04-21 11:25:14 +02:00

Also, use SerializeAdapter for all access to stored elements.

And fix deserialize to deserialize the length field.

Also, use SerializeAdapter for all access to stored elements. And fix deserialize to deserialize the length field.

mohr changed title from ~~Add template Parameter to SerialBufferAdapter to change the type of the Array~~ to Update SerialBufferAdapter

2020-04-21 11:25:40 +02:00

muellerr commented

2020-07-03 16:42:53 +02:00

I made some slight SerialBufferAdapter changes, for example providing a setter function to set the internal buffer without ctor. Maybe this could be useful.

I'll create a pull request as soon as SerializeIF changes have been integrated.

I made some slight SerialBufferAdapter changes, for example providing a setter function to set the internal buffer without ctor. Maybe this could be useful. I'll create a pull request as soon as SerializeIF changes have been integrated.

muellerr commented

2020-09-27 19:19:02 +02:00

I think this can be closed..

gaisser commented

2020-09-29 14:09:46 +02:00

I don't think so. "Add Template parameter for element type." is not implemented

muellerr commented

2021-02-01 10:51:03 +01:00

I guess this means making SerialBufferAdapter header-only?

gaisser commented

2021-02-09 17:15:54 +01:00

It is a template for count_t at the moment.

template<typename count_t>
class SerialBufferAdapter: public SerializeIF

vs

template<typename T, typename count_t>
class SerialBufferAdapter: public SerializeIF

I'm not sure if we need arbitrary or just the typical integer/float/double variants. More complex types can use linked lists or so.

It is a template for count_t at the moment. ``` c++ template<typename count_t> class SerialBufferAdapter: public SerializeIF ``` vs ``` c++ template<typename T, typename count_t> class SerialBufferAdapter: public SerializeIF ``` I'm not sure if we need arbitrary or just the typical integer/float/double variants. More complex types can use linked lists or so.

Sign in to join this conversation.