Introduce SerializeIF::Endianness::NETWORK #379

New Issue

muellerr · 2021-03-04T18:56:35+01:00

muellerr commented

2021-03-04 18:56:35 +01:00

Just something I saw in the Python struct library: A explicit endianness specifier for network endianness, which is of course equal to big endian.

Just something I saw in the Python `struct` library: A explicit endianness specifier for network endianness, which is of course equal to big endian.

muellerr added the

feature

label 2021-03-04 18:56:35 +01:00

gaisser commented

2021-03-04 21:12:05 +01:00

Hm "The Internet has established a standard “network byte order,” which happens to be Big Endian" so this would be

enum class Endianness : uint8_t {
		NETWORK, BIG, LITTLE, MACHINE
	};

where Network means the same as BIG, so every check looks like:

			switch (streamEndianness) {
				case SerializeIF::Endianness::NETWORK:
				case SerializeIF::Endianness::BIG:
					tmp = EndianConverter::convertBigEndian<T>(*object);
					break;
				case SerializeIF::Endianness::LITTLE:
					tmp = EndianConverter::convertLittleEndian<T>(*object);
					break;
				default:
				case SerializeIF::Endianness::MACHINE:
					tmp = *object;
					break;
				}

I'm not sure about that. BIG is even more explicit than NETWORK which kind of hides what is going on with the same effect.

Hm "The Internet has established a standard “network byte order,” which happens to be Big Endian" so this would be ``` c++ enum class Endianness : uint8_t { NETWORK, BIG, LITTLE, MACHINE }; ``` where Network means the same as BIG, so every check looks like: ``` c++ switch (streamEndianness) { case SerializeIF::Endianness::NETWORK: case SerializeIF::Endianness::BIG: tmp = EndianConverter::convertBigEndian<T>(*object); break; case SerializeIF::Endianness::LITTLE: tmp = EndianConverter::convertLittleEndian<T>(*object); break; default: case SerializeIF::Endianness::MACHINE: tmp = *object; break; } ``` I'm not sure about that. BIG is even more explicit than NETWORK which kind of hides what is going on with the same effect.

muellerr commented

2021-03-09 11:10:23 +01:00

so you don't like it?

gaisser commented

2021-03-16 18:08:19 +01:00

Ah I'm stupid. We could just introduce somehting like that

Class SerializeIF {
....
namespace Endianness{
  static const uint8_t NETWORK = SerializeIF::Endianness::BIG;
  }
....
}

But still... I'm not sure if this is needed.

Ah I'm stupid. We could just introduce somehting like that ``` c++ Class SerializeIF { .... namespace Endianness{ static const uint8_t NETWORK = SerializeIF::Endianness::BIG; } .... } ``` But still... I'm not sure if this is needed.

gaisser referenced a pull request that will close this issue

2021-05-11 15:32:29 +02:00

Implements Network Endianness #419

gaisser added this to the ASTP 1.1.0 milestone 2021-05-11 16:32:39 +02:00

gaisser self-assigned this 2021-05-11 16:32:42 +02:00

muellerr closed this issue

2021-05-12 17:25:14 +02:00

Sign in to join this conversation.