fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Turn ObjectManager to Singleton #426

New Issue
Closed
opened 2021-06-07 09:47:18 +02:00 by muellerr · 1 comment
muellerr commented 2021-06-07 09:47:18 +02:00
Owner
Copy Link

I think this would be an architectural improvement and I implemented it.
Unfortunately also an external and internal API change. Following adaptions are necessary for user code:

  1. #include <fsfw/objectmanager/ObjectManagerIF.h needs to be replaced by #include <fsfw/objectmanager/ObjectManager.h
  2. objectManager-> needs to be replaced by ObjectManager::instance()-> . Alternatively, the user can store an own instance with external ObjectManager* objectManager somewhere in application code in a special header and assign it at startup. Then, this header needs to be included.
I think this would be an architectural improvement and I implemented it. Unfortunately also an external and internal API change. Following adaptions are necessary for user code: 1. `#include <fsfw/objectmanager/ObjectManagerIF.h` needs to be replaced by `#include <fsfw/objectmanager/ObjectManager.h` 2. `objectManager->` needs to be replaced by `ObjectManager::instance()->` . Alternatively, the user can store an own instance with `external ObjectManager* objectManager` somewhere in application code in a special header and assign it at startup. Then, this header needs to be included.
muellerr added the featureAPI Change labels 2021-06-07 09:47:18 +02:00
gaisser added this to the ASTP 1.1.0 milestone 2021-06-08 14:42:16 +02:00
muellerr was assigned by gaisser 2021-06-08 15:01:41 +02:00
gaisser commented 2021-06-08 15:01:47 +02:00
Owner
Copy Link

Part of #424.

Part of #424.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 Documentation
Improvement of code documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 wontfix
This won't be fixed
No Label API Change feature
Milestone
No items
No Milestone ASTP 1.1.0
Assignees
Clear assignees
ahinkel gaisser jenkins_buildfix meierj mohr muellerr tbaumgartl
No Assignees muellerr
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#426
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?