QueueMapManager bugfix #444
Labels
No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Blocks
#445 FSFW Restructuring
fsfw/fsfw
Reference: fsfw/fsfw#444
Loading…
Reference in New Issue
No description provided.
Delete Branch "mueller/queuemapmanager-bugfix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This bug slipped the SOURCE tests and the internal unit tests. But surfaced on the STM32 FSFW example. The post-increment operator was used by accident instead of the pre-increment operator which caused the first MessageQueue ID assigned by the QueueMapManager to be 0. This is the current value for
NO_QUEUE
.I suspect that the first queue created that way was not used during the SOURCE tests or in the internal unit tests in a way that would have caught this bug.
Solution is to start at 1 now, clarify via comment, and continue using the post-increment operator.
Furthermore, the NO_QUEUE value is skipped now