fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

Compare osal/linux/Timer and timemanager/Countdown #473

New Issue
Closed
opened 2021-09-13 18:26:03 +02:00 by mohr · 1 comment
mohr commented 2021-09-13 18:26:03 +02:00
Owner
Copy Link

I just saw #462 and wondered where the difference to (an slightly updated version of) the Countdown is in using an OS specific function to implement it. As far as I can tell, using an OS timer does not bring any advantage as its ability to throw an event is not used.

By extending, if that helps also renaming, Countdown I think the same functionality can be achieved by relating the work to the already implemented Clock class.

I just saw #462 and wondered where the difference to (an slightly updated version of) the `Countdown` is in using an OS specific function to implement it. As far as I can tell, using an OS timer does not bring any advantage as its ability to throw an event is not used. By extending, if that helps also renaming, `Countdown` I think the same functionality can be achieved by relating the work to the already implemented `Clock` class.
muellerr was assigned by mohr 2021-09-13 18:26:03 +02:00
muellerr was unassigned by mohr 2021-09-20 15:13:52 +02:00
gaisser was assigned by mohr 2021-09-20 15:13:52 +02:00
mohr commented 2021-09-27 15:14:15 +02:00
Author
Owner
Copy Link

Developer meeting consens:

  • Delete osal/linux/timer
  • check Feature completeness of Countdown
  • Name "Countdown" shall be used
Developer meeting consens: * Delete osal/linux/timer * check Feature completeness of Countdown * Name "Countdown" shall be used
mohr closed this issue 2021-10-04 14:44:56 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
development
mohr/romeo
development-doc-deployment
development-doc-test0
switch-doc-theme-to-rtd
action-update
obj-manager-tweak
mohr_introspection
mohr/windows
mohr/GCC13
mohr/timetag_fix
mohr/relsease_helper
mohr/warnings
mohr/rtems
mohr/freeRTOS
mueller/new-cfdp-update-with-handlers
mohr/dhb2normal
mueller/obj-man-remove-weird-proc-func
mohr/documentation_ci
mueller/fsfw-from-zero
mueller/data-wrapper
mueller/dhb-handle-device-tm
mueller/refactor-tmtc-stack-with-retval-refactoring
mueller/refactor-logging-with-fmt
meier/upstream-pus-distributor-bugfix
mueller/clang-improvements
docker_d12
docker_d11
docker_d10
v6.0.0
docker_d9
docker_d8
docker_d7
docker_d6
docker_d5
docker_d4
v5.0.0
docker_d3
docker_d2
v4.0.0
docker_d1
v3.0.1
v3.0.0
v2.0.1
v2.0.0
ASTP_1.1.0
ASTP_1.0.0
ASTP_0.0.1
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
gaisser
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#473
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?