fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

Increased TM stack robustness #483

Closed
muellerr wants to merge 11 commits from eive:mueller/tm-stack-robustness into development
pull from: eive:mueller/tm-stack-robustness
merge into: fsfw:development
Conversation 4 Commits 11 Files Changed 10 +353 -283
muellerr commented 2021-09-27 11:07:52 +02:00
Owner
Copy Link

Fixes #478

  1. More nullptr checks and printouts to quickly determine small store size issue
  2. returnvalue for inititalize function which can fail
Fixes #478 1. More `nullptr` checks and printouts to quickly determine small store size issue 2. returnvalue for inititalize function which can fail
muellerr added 1 commit 2021-09-27 11:07:53 +02:00
ba6cbde28a
Increased TM stack robustness 
1. More nullptr check
2. returnvalue for inititalize function which can fail
muellerr requested review from mohr 2021-09-27 11:09:51 +02:00
muellerr added this to the v2.0.0 milestone 2021-09-27 11:10:38 +02:00
muellerr modified the milestone from v2.0.0 to (deleted) 2021-09-27 15:00:38 +02:00
gaisser modified the milestone from v2.0.0 to v2.0.0 2021-09-27 15:01:39 +02:00
muellerr added the
bug
 label 2021-09-27 15:36:43 +02:00
muellerr added 1 commit 2021-09-27 15:37:00 +02:00
gaisser was assigned by mohr 2021-09-27 15:37:42 +02:00
gaisser commented 2021-09-27 22:16:53 +02:00
Owner
Copy Link

The PusA Implementation has the same issue. Aren't we duplicating a lot of code here between A and C?

The PusA Implementation has the same issue. Aren't we duplicating a lot of code here between A and C?
muellerr added 1 commit 2021-09-29 16:17:45 +02:00
muellerr commented 2021-09-29 16:18:02 +02:00
Author
Owner
Copy Link

Maybe some code can be moved into a private function of the base class

Maybe some code can be moved into a private function of the base class
muellerr added 1 commit 2021-10-02 15:51:09 +02:00
gaisser removed this from the v2.0.0 milestone 2021-10-04 14:29:18 +02:00
muellerr added 1 commit 2021-10-04 14:45:39 +02:00
muellerr added 1 commit 2021-10-05 12:27:46 +02:00
muellerr commented 2021-10-05 12:30:13 +02:00
Author
Owner
Copy Link

The code can not be refactored in a sensible way because the function used are mostly member functions.

The code can not be refactored in a sensible way because the function used are mostly member functions.
muellerr added this to the v2.0.1 milestone 2021-10-05 12:30:20 +02:00
muellerr modified the milestone from v2.0.1 to v3.0.0 2021-10-05 12:32:09 +02:00
muellerr modified the milestone from v3.0.0 to v2.0.1 2021-10-05 12:32:12 +02:00
muellerr added 1 commit 2021-10-05 12:36:28 +02:00
muellerr added 1 commit 2021-10-05 12:39:06 +02:00
muellerr added 1 commit 2021-10-05 12:49:33 +02:00
muellerr added 1 commit 2021-10-05 18:27:41 +02:00
muellerr added 1 commit 2021-10-09 13:36:25 +02:00
muellerr commented 2021-10-11 16:44:04 +02:00
Author
Owner
Copy Link

Replaced by #501 which will be merged directly into master for revision

Replaced by #501 which will be merged directly into master for revision
muellerr closed this pull request 2021-10-11 16:44:05 +02:00
muellerr removed this from the v2.0.1 milestone 2021-10-11 18:02:11 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
mohr
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
gaisser
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#483
No description provided.
Delete Branch "eive:mueller/tm-stack-robustness"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?