fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

FSFW.h.in more default values #491

Merged
muellerr merged 10 commits from mueller/fsfw-default-value-pus-c-cfg into development 2021-10-05 18:27:13 +02:00
Conversation 2 Commits 10 Files Changed 1 +29 -1
muellerr commented 2021-09-29 12:06:15 +02:00
Owner
Copy Link
No description provided.
muellerr added 4 commits 2021-09-29 12:06:16 +02:00
muellerr added 1 commit 2021-09-29 12:07:11 +02:00
muellerr added 1 commit 2021-09-29 14:27:21 +02:00
muellerr added 1 commit 2021-09-29 16:16:13 +02:00
mohr commented 2021-10-01 14:04:36 +02:00
Owner
Copy Link

How did this work before? Was the user code supposed to set all these?
And, are we not using -Wundef (which would give a warning if undefined macros are used in #if statements)?

How did this work before? Was the user code supposed to set all these? And, are we not using `-Wundef` (which would give a warning if undefined macros are used in `#if` statements)?
muellerr commented 2021-10-02 15:44:43 +02:00
Author
Owner
Copy Link

Yes, those were supposed to be set by the user.
The FSFW.h.in file is new and is able to set default values for undefined defines. This is how projects like FreeRTOS and LwIP sanitize the user configuration header file.

And as far as i know this warning is not used

Yes, those were supposed to be set by the user. The `FSFW.h.in` file is new and is able to set default values for undefined defines. This is how projects like FreeRTOS and LwIP sanitize the user configuration header file. And as far as i know this warning is not used
muellerr added 1 commit 2021-10-02 15:44:48 +02:00
mohr approved these changes 2021-10-04 11:13:01 +02:00
mohr left a comment
Owner
Copy Link

Thanks for the clarification

Thanks for the clarification
muellerr added 1 commit 2021-10-04 14:45:16 +02:00
muellerr added this to the v3.0.0 milestone 2021-10-05 12:32:32 +02:00
muellerr added 1 commit 2021-10-05 18:26:36 +02:00
muellerr modified the milestone from v3.0.0 to v2.0.1 2021-10-05 18:26:41 +02:00
muellerr merged commit 85a90a6ec5 into development 2021-10-05 18:27:13 +02:00
muellerr deleted branch mueller/fsfw-default-value-pus-c-cfg 2021-10-05 18:27:14 +02:00
muellerr modified the milestone from v2.0.1 to v3.0.0 2021-10-11 18:02:16 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
mohr
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v3.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#491
No description provided.
Delete Branch "mueller/fsfw-default-value-pus-c-cfg"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?