Commands which share the same reply might get Handler Stuck #547

New Issue

gaisser · 2022-02-04T18:26:39+01:00

gaisser commented

2022-02-04 18:26:39 +01:00

As happened with the PAMCAM Handler of Flying Laptop:

There are two Commands in a DH which use the same Reply
The first command was sent
Before the reply was received or a timeout happened the other command was sent
The first command will be stuck forever as the Reply Map was set to the other command.

Note:
The implementation had to overwrite enableReplyInReplyMap to call the default DHB implementation with "useAlternativeId = True". The DHB function does not check if the reply is currently in use.

Implementations can solve this by checking that a command with the same reply is executing before commanding. I think, that the DHB function enableReplyInReplyMap should not overwrite info->command = command; if isExecuting is True.

As happened with the PAMCAM Handler of Flying Laptop: 1. There are two Commands in a DH which use the same Reply 2. The first command was sent 3. Before the reply was received or a timeout happened the other command was sent 4. The first command will be stuck forever as the Reply Map was set to the other command. Note: The implementation had to overwrite `` enableReplyInReplyMap `` to call the default DHB implementation with ```"useAlternativeId = True"```. The DHB function does not check if the reply is currently in use. Implementations can solve this by checking that a command with the same reply is executing before commanding. I think, that the DHB function `` enableReplyInReplyMap `` should not overwrite `` info->command = command;`` if ``isExecuting `` is True.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#547