fsfw/fsfw
fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

TmPacketMinimal casts const away from data in its constructor #567

New Issue
Closed
opened 2022-02-23 18:01:12 +01:00 by gaisser · 2 comments
gaisser commented 2022-02-23 18:01:12 +01:00
Owner
Copy Link
TmPacketMinimal::TmPacketMinimal(const uint8_t* set_data) : SpacePacketBase(set_data) {
  this->tm_data = (TmPacketMinimalPointer*)set_data;
}

Either introduce a constructor with non-const data or rewrite everything.

``` c++ TmPacketMinimal::TmPacketMinimal(const uint8_t* set_data) : SpacePacketBase(set_data) { this->tm_data = (TmPacketMinimalPointer*)set_data; } ``` Either introduce a constructor with non-const data or rewrite everything.
muellerr commented 2022-10-17 15:13:29 +02:00
Owner
Copy Link

I think this is not an issue with the new packet stack anymore.

I think this is not an issue with the new packet stack anymore.
gaisser commented 2022-10-17 15:14:31 +02:00
Author
Owner
Copy Link

Fixed by #655

Fixed by #655
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#567
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?