fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Thoughts on DataSet #61

New Issue
Closed
opened 2020-04-29 18:33:59 +02:00 by muellerr · 2 comments
muellerr commented 2020-04-29 18:33:59 +02:00
Owner
Copy Link

As part of my investigation for distributed datapools, I had a look at the DataSet class.
This class has serialization/deserialization calls and is a good candidate to store pool data thread-safe with the PoolManager

I suggest to add an ID and a valid flag for the dataset.

Thoughts about ways to access the pool data:

  • PUS structue ID consists of object ID and the set ID now.
  • If a controller or another class needs access to a full dataset (raw or message based), it could provide a dataset ID.
  • Same principle would be applied for commanding with the HK service.
  • Each DeviceHandler has a public enum with pool variable IDs for data that is possibly interesting for housekeeping purposes. These IDs can be used to pack new datasets and change existing ones if required. Can propably be used for MIB parsing too in some way.
As part of my investigation for distributed datapools, I had a look at the DataSet class. This class has serialization/deserialization calls and is a good candidate to store pool data thread-safe with the PoolManager I suggest to add an ID and a valid flag for the dataset. Thoughts about ways to access the pool data: - PUS structue ID consists of object ID and the set ID now. - If a controller or another class needs access to a full dataset (raw or message based), it could provide a dataset ID. - Same principle would be applied for commanding with the HK service. - Each DeviceHandler has a public enum with pool variable IDs for data that is possibly interesting for housekeeping purposes. These IDs can be used to pack new datasets and change existing ones if required. Can propably be used for MIB parsing too in some way.
muellerr added the
feature
 label 2020-04-29 18:33:59 +02:00
muellerr changed title from Though about DataSet to Thoughts about DataSet 2020-04-29 18:41:11 +02:00
muellerr changed title from Thoughts about DataSet to Thoughts on DataSet 2020-04-29 18:41:29 +02:00
muellerr added the
API Change
 label 2020-04-29 18:41:50 +02:00
muellerr commented 2020-07-06 13:00:04 +02:00
Author
Owner
Copy Link

Related to #97

Related to #97
gaisser commented 2020-10-27 14:39:23 +01:00
Owner
Copy Link

Part of local data pool changes.

Part of local data pool changes.
gaisser added this to the ASTP 1.0.0 Local pools milestone 2020-12-01 15:51:08 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
API Change
feature
Milestone
No items
No Milestone ASTP 1.0.0 Local pools
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#61
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?