fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Refactor Heater class #615

New Issue
Open
opened 2022-05-02 18:20:00 +02:00 by muellerr · 0 comments
muellerr commented 2022-05-02 18:20:00 +02:00
Owner
Copy Link

The heater class is not generic enough to be re-used properly. This is probably because it was programmed specifically for FLP. There are some important points to make this class usable for EIVE specifically:

  • There will not always be two switches, and the information that there is a second switch does not really belong in a generic Heater class in my opinion
  • Heaters are not always controlled by a Power Switcher. They can be controlled by
    GPIO pins as well
  • Sometimes, a power switcher and a GPIO is used

It would be good to define a generic HeaterBase class which provides adaptions points like checkHeaterState(... targetState), setHeater(... targetState) which allow to write custom code being able to handle any combination of GPIO pins or power switches.

The heater class is not generic enough to be re-used properly. This is probably because it was programmed specifically for FLP. There are some important points to make this class usable for EIVE specifically: - There will not always be two switches, and the information that there is a second switch does not really belong in a generic `Heater` class in my opinion - Heaters are not always controlled by a Power Switcher. They can be controlled by GPIO pins as well - Sometimes, a power switcher and a GPIO is used It would be good to define a generic HeaterBase class which provides adaptions points like `checkHeaterState(... targetState)`, `setHeater(... targetState)` which allow to write custom code being able to handle any combination of GPIO pins or power switches.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#615
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?