fsfw/fsfw
12
3 Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

PUS Service 11: Additional Safety Check #666

Merged
gaisser merged 3 commits from eive/fsfw:mueller/service-11-tweak into development 2022-08-29 14:59:25 +02:00
Conversation 1 Commits 3 Files Changed 1
+3 -2
muellerr commented 2022-08-29 13:19:18 +02:00
Owner
Copy link
Copy source

Got a warning when compiling for release that this is a potential nullptr dereference. This check can be problematic if the iterators are not checked to be valid.

Got a warning when compiling for release that this is a potential nullptr dereference. This check can be problematic if the iterators are not checked to be valid.
muellerr added 1 commit 2022-08-29 13:19:21 +02:00
additional safety check
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
fd278e410b
muellerr changed title from mueller/service-11-tweak to PUS Service 11: Additional Safety Check 2022-08-29 13:20:00 +02:00
muellerr added this to the v6.0.0 milestone 2022-08-29 14:21:11 +02:00
mohr added 1 commit 2022-08-29 14:55:04 +02:00
Revert "additional safety check" e2e0190cae 
This reverts commit fd278e410b.
mohr force-pushed mueller/service-11-tweak from 144a7aae51 to 6605ffb6b1 2022-08-29 14:55:57 +02:00 Compare
gaisser approved these changes 2022-08-29 14:59:11 +02:00
gaisser left a comment
Owner
Copy link
Copy source

LGTM

LGTM
gaisser merged commit a7039bad41 into development 2022-08-29 14:59:25 +02:00
gaisser deleted branch mueller/service-11-tweak 2022-08-29 14:59:27 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 Documentation
Improvement of code documentation
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone v6.0.0
Assignees
Clear assignees
ahinkel (Andy Hinkel) gaisser (Steffen Gaisser) jenkins_buildfix meierj (Jakob Meier) mohr (Ulrich Mohr) mspahr muellerr (Robin Müller) tbaumgartl (Tobias Baumgartl)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#666