fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

PUS Service 11: Additional Safety Check #666

Merged
gaisser merged 3 commits from eive/fsfw:mueller/service-11-tweak into development 2022-08-29 14:59:25 +02:00
Conversation 1 Commits 3 Files Changed 1 +3 -2
muellerr commented 2022-08-29 13:19:18 +02:00
Owner
Copy Link

Got a warning when compiling for release that this is a potential nullptr dereference. This check can be problematic if the iterators are not checked to be valid.

Got a warning when compiling for release that this is a potential nullptr dereference. This check can be problematic if the iterators are not checked to be valid.
muellerr added 1 commit 2022-08-29 13:19:21 +02:00
additional safety check
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
fd278e410b
muellerr changed title from mueller/service-11-tweak to PUS Service 11: Additional Safety Check 2022-08-29 13:20:00 +02:00
muellerr added this to the v6.0.0 milestone 2022-08-29 14:21:11 +02:00
mohr added 1 commit 2022-08-29 14:55:04 +02:00 
This reverts commit fd278e410b943efeb30435b9a5fb00988c171be9.
mohr force-pushed mueller/service-11-tweak from 144a7aae51 to 6605ffb6b1 2022-08-29 14:55:57 +02:00 Compare
gaisser approved these changes 2022-08-29 14:59:11 +02:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
gaisser merged commit a7039bad41 into development 2022-08-29 14:59:25 +02:00
gaisser deleted branch mueller/service-11-tweak 2022-08-29 14:59:27 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone v6.0.0
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#666
No description provided.
Delete Branch "eive/fsfw:mueller/service-11-tweak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?