fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Srv 11 should check CRC of TT packet #719

New Issue
Closed
opened 2023-01-12 19:17:33 +01:00 by gaisser · 1 comment
gaisser commented 2023-01-12 19:17:33 +01:00
Owner
Copy Link

Incoming packets as data in the packet should be checked before inserting.

There was a wrong TcPacket sent without a timestamp and it still got inserted in the Schedule successful.

Incoming packets as data in the packet should be checked before inserting. There was a wrong TcPacket sent without a timestamp and it still got inserted in the Schedule successful.
gaisser added the
bug
 label 2023-01-12 19:17:33 +01:00
muellerr was assigned by gaisser 2023-01-12 19:17:33 +01:00
muellerr commented 2023-01-13 09:42:26 +01:00
Owner
Copy Link

I will try to fix this today.

The new code should also probably check that the received packet has the minimum size required for a TC packet. A min length check is required anyway before performing the CRC check.

I will try to fix this today. The new code should also probably check that the received packet has the minimum size required for a TC packet. A min length check is required anyway before performing the CRC check.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
bug
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees muellerr
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#719
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?