ModeMessage Improvements #86

New Issue

2020-05-25T15:52:45+02:00

muellerr commented

2020-05-25 15:52:45 +02:00

This is related to the following reply: Reply for wrong mode:

//! Reply to a CMD_MODE_COMMAND, indicating that a mode was commanded and a transition started but was aborted; the parameters contain the mode that was reached
static const Command_t REPLY_WRONG_MODE_REPLY = MAKE_COMMAND_ID(0x05);

I will just copy the SHOULDDO text here:

//SHOULDDO is there a way we can transmit a returnvalue when responding that the mode is wrong, so we can give a nice failure code when commanded by PUS?
(Robin)
// shouldn't that possible with parameter 2 when submode only takes 1 byte?

It should be possible to store the return value in parameter 2.

This is related to the following reply: Reply for wrong mode: ```cpp //! Reply to a CMD_MODE_COMMAND, indicating that a mode was commanded and a transition started but was aborted; the parameters contain the mode that was reached static const Command_t REPLY_WRONG_MODE_REPLY = MAKE_COMMAND_ID(0x05); ``` I will just copy the SHOULDDO text here: ```cpp //SHOULDDO is there a way we can transmit a returnvalue when responding that the mode is wrong, so we can give a nice failure code when commanded by PUS? (Robin) // shouldn't that possible with parameter 2 when submode only takes 1 byte? ``` It should be possible to store the return value in parameter 2.

muellerr added the feature label 2020-05-25 15:53:13 +02:00

gaisser referenced a pull request that will close this issue

2020-09-29 15:43:10 +02:00

Returns failed now in Service 200 when mode answer is negative #217

muellerr referenced this issue from a commit

2020-09-29 16:02:03 +02:00

Fixes #86

muellerr closed this issue

2020-09-29 16:02:03 +02:00

Sign in to join this conversation.