fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

Colored prefix option only if colored output is enabled #449

Merged
muellerr merged 6 commits from meier/ColeredDebugOutput into development 2021-07-27 13:07:16 +02:00
Conversation 0 Commits 6 Files Changed 6 +4 -4
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3d80d5d036 - Show all commits

6
serviceinterface/ServiceInterfaceBuffer.cpp
View File

@ -172,9 +172,9 @@ bool ServiceInterfaceBuffer::crAdditionEnabled() const {
}
#if FSFW_COLORED_OUTPUT == 1
void ServiceInterfaceBuffer::setAsciiColorPrefix(std::string colorPrefix) {
this->colorPrefix = colorPrefix;
}
void ServiceInterfaceBuffer::setAsciiColorPrefix(std::string colorPrefix) {
meierj marked this conversation as resolved Outdated
muellerr commented 2021-07-27 10:05:20 +02:00
Outdated
Review
Copy Link

Usually code in preprocessor defines has not been indented yet. I'd keep it consistent

Usually code in preprocessor defines has not been indented yet. I'd keep it consistent
this->colorPrefix = colorPrefix;
}
#endif
#ifdef UT699

2
unittest/tests/mocks/MessageQueueMockBase.h
View File

@ -3,7 +3,7 @@
#include <fsfw/ipc/MessageQueueIF.h>
#include <fsfw/ipc/MessageQueueMessage.h>
#include <unittest/user/unittest/core/CatchDefinitions.h>
#include <unittest/core/CatchDefinitions.h>
meierj marked this conversation as resolved Outdated
muellerr commented 2021-07-27 10:07:40 +02:00
Outdated
Review
Copy Link

I think this needs to remain #include <unittest/core/CatchDefinitions.h> but I'd need to check fsfw-test for that again.. Unless you are sure this is the correct include, I'd leave it the old way

I think this needs to remain `#include <unittest/core/CatchDefinitions.h>` but I'd need to check `fsfw-test` for that again.. Unless you are sure this is the correct include, I'd leave it the old way
#include <cstring>
#include <queue>