fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

DLE Encoder Improvements #467

Merged
muellerr merged 22 commits from KSat/fsfw:mueller/dle-improvements into development 2021-09-13 15:25:02 +02:00
Conversation 5 Commits 22 Files Changed 5 -9
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 28f2db2c11 - Show all commits

9
src/fsfw/globalfunctions/DleEncoder.cpp
View File

@ -80,19 +80,10 @@ ReturnValue_t DleEncoder::encode(const uint8_t* sourceStream,
}
}
ReturnValue_t DleEncoder::encodeEscaped(const uint8_t *sourceStream, size_t sourceLen,
uint8_t *destStream, size_t maxDestLen, size_t *encodedLen, bool addStxEtx) {
}
ReturnValue_t DleEncoder::encodeNonEscaped(const uint8_t *sourceStream, size_t sourceLen,
uint8_t *destStream, size_t maxDestLen, size_t *encodedLen, bool addStxEtx) {
}
ReturnValue_t DleEncoder::decode(const uint8_t *sourceStream,
size_t sourceStreamLen, size_t *readLen, uint8_t *destStream,
size_t maxDestStreamlen, size_t *decodedLen) {
mohr marked this conversation as resolved Outdated
mohr commented 2021-09-10 11:51:50 +02:00
Outdated
Review
Copy Link

bug in the original implementation: If addStxEtx is false, encodedIndex==maxDestLen is valid.

bug in the original implementation: If addStxEtx is false, encodedIndex==maxDestLen is valid.
size_t encodedIndex = 0, decodedIndex = 0;
uint8_t nextByte;
if(not escapeStxEtx) {
if (*sourceStream != DLE_CHAR) {
return DECODING_ERROR;