DHB set action commander before buildCommandFromCommand #672

Merged
mohr merged 2 commits from eive/fsfw:mueller/dhb-set-action-commander-before-building-cmd into development 2022-09-01 11:18:34 +02:00
Owner

Allows to immediately call actionHelper.finish in buildCommandFromCommand

Allows to immediately call `actionHelper.finish` in `buildCommandFromCommand`
muellerr added 1 commit 2022-08-31 16:50:56 +02:00
small fix which allows sending action reply immediately
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
7345c18b04
muellerr changed title from mueller/dhb-set-action-commander-before-building-cmd to DHB set action commander before buildCommandFromCommand 2022-08-31 16:51:44 +02:00
muellerr requested review from mohr 2022-08-31 16:51:53 +02:00
muellerr added this to the v6.0.0 milestone 2022-08-31 16:51:57 +02:00
mohr requested changes 2022-08-31 17:15:34 +02:00
mohr left a comment
Owner

After reading through DHB, I think we do not need to cache the previous state of iter->second.sendReplyTo. It will be set before it is being accessed again.

After reading through DHB, I think we do not need to cache the previous state of `iter->second.sendReplyTo`. It will be set before it is being accessed again.
Author
Owner

okay, i was not sure about that.

okay, i was not sure about that.
muellerr added 1 commit 2022-09-01 08:58:20 +02:00
do not cache previous recipient
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
7ae82a5cb4
mohr approved these changes 2022-09-01 10:56:03 +02:00
mohr merged commit 3010f2f925 into development 2022-09-01 11:18:34 +02:00
mohr deleted branch mueller/dhb-set-action-commander-before-building-cmd 2022-09-01 11:18:36 +02:00
Sign in to join this conversation.
No description provided.