fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

DHB set action commander before buildCommandFromCommand #672

Merged
mohr merged 2 commits from eive/fsfw:mueller/dhb-set-action-commander-before-building-cmd into development 2022-09-01 11:18:34 +02:00
Conversation 1 Commits 2 Files Changed 1 +1 -1
muellerr commented 2022-08-31 16:50:54 +02:00
Owner
Copy Link

Allows to immediately call actionHelper.finish in buildCommandFromCommand

Allows to immediately call `actionHelper.finish` in `buildCommandFromCommand`
muellerr added 1 commit 2022-08-31 16:50:56 +02:00
small fix which allows sending action reply immediately
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
7345c18b04
muellerr changed title from mueller/dhb-set-action-commander-before-building-cmd to DHB set action commander before buildCommandFromCommand 2022-08-31 16:51:44 +02:00
muellerr requested review from mohr 2022-08-31 16:51:53 +02:00
muellerr added this to the v6.0.0 milestone 2022-08-31 16:51:57 +02:00
mohr requested changes 2022-08-31 17:15:34 +02:00
mohr left a comment
Owner
Copy Link

After reading through DHB, I think we do not need to cache the previous state of iter->second.sendReplyTo. It will be set before it is being accessed again.

After reading through DHB, I think we do not need to cache the previous state of `iter->second.sendReplyTo`. It will be set before it is being accessed again.
muellerr commented 2022-08-31 17:53:38 +02:00
Author
Owner
Copy Link

okay, i was not sure about that.

okay, i was not sure about that.
muellerr added 1 commit 2022-09-01 08:58:20 +02:00
do not cache previous recipient
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
7ae82a5cb4
mohr approved these changes 2022-09-01 10:56:03 +02:00
mohr merged commit 3010f2f925 into development 2022-09-01 11:18:34 +02:00
mohr deleted branch mueller/dhb-set-action-commander-before-building-cmd 2022-09-01 11:18:36 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
mohr
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v6.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#672
No description provided.
Delete Branch "eive/fsfw:mueller/dhb-set-action-commander-before-building-cmd"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?