downlink_logfile #21

Merged
lkoester merged 6 commits from downlink_logfile into main 2024-04-25 17:49:19 +02:00
Member
No description provided.
lkoester added 5 commits 2024-04-25 16:50:26 +02:00
lkoester requested review from muellerr 2024-04-25 16:50:33 +02:00
muellerr approved these changes 2024-04-25 17:10:05 +02:00
src/main.rs Outdated
@ -55,3 +56,3 @@
setup_logger().expect("setting up logging with fern failed");
let version_str = VERSION.unwrap_or("?");
println!("OPS-SAT Rust Experiment OBSW v{}", version_str);
debug!("OPS-SAT Rust Experiment OBSW v{}", version_str);
Owner

I'd leave this a println. There are corner cases where logger output ca nbe invisible, and I always want to see this line at the very least.

I'd leave this a println. There are corner cases where logger output ca nbe invisible, and I always want to see this line at the very least.
lkoester marked this conversation as resolved
src/main.rs Outdated
@ -58,3 +60,3 @@
let app_cfg = create_app_config();
println!("App Configuration: {:?}", app_cfg);
debug!("App Configuration: {:?}", app_cfg);
Owner

I'd transform this to INFO. debug is usually not visible, and this is valuable information, as long as it's not too noisy.

I'd transform this to INFO. debug is usually not visible, and this is valuable information, as long as it's not too noisy.
lkoester marked this conversation as resolved
lkoester added 1 commit 2024-04-25 17:48:53 +02:00
lkoester merged commit 2992829ccf into main 2024-04-25 17:49:19 +02:00
lkoester deleted branch downlink_logfile 2024-04-25 17:49:19 +02:00
muellerr added this to the v0.1.1 milestone 2024-04-25 20:24:17 +02:00
Sign in to join this conversation.
No description provided.