rust/ops-sat-rs
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

downlink_logfile #21

Merged
lkoester merged 6 commits from downlink_logfile into main 2024-04-25 17:49:19 +02:00
Conversation 1 Commits 6 Files Changed 8 +137 -10
lkoester commented 2024-04-25 16:50:26 +02:00
Member
Copy Link
No description provided.
lkoester added 5 commits 2024-04-25 16:50:26 +02:00
lkoester requested review from muellerr 2024-04-25 16:50:33 +02:00
muellerr approved these changes 2024-04-25 17:10:05 +02:00
src/main.rs Outdated
@ -55,3 +56,3 @@
setup_logger().expect("setting up logging with fern failed");
let version_str = VERSION.unwrap_or("?");
println!("OPS-SAT Rust Experiment OBSW v{}", version_str);
debug!("OPS-SAT Rust Experiment OBSW v{}", version_str);
muellerr commented 2024-04-25 17:08:46 +02:00
Owner
Copy Link

I'd leave this a println. There are corner cases where logger output ca nbe invisible, and I always want to see this line at the very least.

I'd leave this a println. There are corner cases where logger output ca nbe invisible, and I always want to see this line at the very least.
lkoester marked this conversation as resolved
src/main.rs Outdated
@ -58,3 +60,3 @@
let app_cfg = create_app_config();
println!("App Configuration: {:?}", app_cfg);
debug!("App Configuration: {:?}", app_cfg);
muellerr commented 2024-04-25 17:09:13 +02:00
Owner
Copy Link

I'd transform this to INFO. debug is usually not visible, and this is valuable information, as long as it's not too noisy.

I'd transform this to INFO. debug is usually not visible, and this is valuable information, as long as it's not too noisy.
lkoester marked this conversation as resolved
lkoester added 1 commit 2024-04-25 17:48:53 +02:00
lkoester merged commit 2992829ccf into main 2024-04-25 17:49:19 +02:00
lkoester deleted branch downlink_logfile 2024-04-25 17:49:19 +02:00
muellerr added this to the v0.1.1 milestone 2024-04-25 20:24:17 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
muellerr
Labels
Clear labels
api
Non-Breaking API change
b-api
Breaking API change
bug
Something is not working
concepts
Conception and ideas for new features
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone v0.1.1
Projects
Clear projects
No project
Assignees
Clear assignees
dwoodward jenkins_buildfix lkoester mohr muellerr nehlichp
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rust/ops-sat-rs#21
No description provided.
Delete Branch "downlink_logfile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?