rust/sat-rs
rust/sat-rs
5
1
Fork 0
Code Issues 9 Pull Requests Projects Releases 22 Wiki Activity

improved and unified TM sending API

Browse Source
This commit is contained in:
Robin Müller 2023-07-08 14:57:11 +02:00
parent ea6971d9b3
commit 1f2bd0fd54
Signed by: muellerr
GPG Key ID: A649FB78196E3849
7 changed files with 419 additions and 340 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
satrs-core/src/pool.rs
View File

@ -138,6 +138,16 @@ pub struct StoreAddr {
pub(crate) packet_idx: NumBlocks, pub(crate) packet_idx: NumBlocks,
} }
impl Display for StoreAddr {
fn fmt(&self, f: &mut Formatter<'_>) -> core::fmt::Result {
write!(
f,
"StoreAddr(pool index: {}, packet index: {})",
self.pool_idx, self.packet_idx
)
}
}
impl StoreAddr { impl StoreAddr {
pub const INVALID_ADDR: u32 = 0xFFFFFFFF; pub const INVALID_ADDR: u32 = 0xFFFFFFFF;

50
satrs-core/src/pus/event.rs
View File

@ -110,7 +110,7 @@ impl EventReporterBase {
) -> Result<(), EcssTmtcErrorWithSend<E>> { ) -> Result<(), EcssTmtcErrorWithSend<E>> {
let tm = self.generate_generic_event_tm(buf, subservice, time_stamp, event_id, aux_data)?; let tm = self.generate_generic_event_tm(buf, subservice, time_stamp, event_id, aux_data)?;
sender sender
.send_tm(tm) .send_tm(tm.into())
.map_err(|e| EcssTmtcErrorWithSend::SendError(e))?; .map_err(|e| EcssTmtcErrorWithSend::SendError(e))?;
self.msg_count += 1; self.msg_count += 1;
Ok(()) Ok(())
@ -243,9 +243,10 @@ mod tests {
use super::*; use super::*;
use crate::events::{EventU32, Severity}; use crate::events::{EventU32, Severity};
use crate::pus::tests::CommonTmInfo; use crate::pus::tests::CommonTmInfo;
use crate::pus::EcssSender; use crate::pus::{EcssSender, PusTmWrapper};
use crate::SenderId; use crate::SenderId;
use spacepackets::ByteConversionError; use spacepackets::ByteConversionError;
use std::cell::RefCell;
use std::collections::VecDeque; use std::collections::VecDeque;
use std::vec::Vec; use std::vec::Vec;
@ -264,7 +265,7 @@ mod tests {
#[derive(Default, Clone)] #[derive(Default, Clone)]
struct TestSender { struct TestSender {
pub service_queue: VecDeque<TmInfo>, pub service_queue: RefCell<VecDeque<TmInfo>>,
} }
impl EcssSender for TestSender { impl EcssSender for TestSender {
@ -276,21 +277,29 @@ mod tests {
impl EcssTmSenderCore for TestSender { impl EcssTmSenderCore for TestSender {
type Error = (); type Error = ();
fn send_tm(&mut self, tm: PusTm) -> Result<(), Self::Error> { fn send_tm(&self, tm: PusTmWrapper) -> Result<(), Self::Error> {
assert!(tm.source_data().is_some()); match tm {
let src_data = tm.source_data().unwrap(); PusTmWrapper::InStore(_) => {
assert!(src_data.len() >= 4); panic!("TestSender: unexpected call with address");
let event = EventU32::from(u32::from_be_bytes(src_data[0..4].try_into().unwrap())); }
let mut aux_data = Vec::new(); PusTmWrapper::Direct(tm) => {
if src_data.len() > 4 { assert!(tm.source_data().is_some());
aux_data.extend_from_slice(&src_data[4..]); let src_data = tm.source_data().unwrap();
assert!(src_data.len() >= 4);
let event =
EventU32::from(u32::from_be_bytes(src_data[0..4].try_into().unwrap()));
let mut aux_data = Vec::new();
if src_data.len() > 4 {
aux_data.extend_from_slice(&src_data[4..]);
}
self.service_queue.borrow_mut().push_back(TmInfo {
common: CommonTmInfo::new_from_tm(&tm),
event,
aux_data,
});
Ok(())
}
} }
self.service_queue.push_back(TmInfo {
common: CommonTmInfo::new_from_tm(&tm),
event,
aux_data,
});
Ok(())
} }
} }
@ -359,8 +368,9 @@ mod tests {
severity, severity,
error_data, error_data,
); );
assert_eq!(sender.service_queue.len(), 1); let mut service_queue = sender.service_queue.borrow_mut();
let tm_info = sender.service_queue.pop_front().unwrap(); assert_eq!(service_queue.len(), 1);
let tm_info = service_queue.pop_front().unwrap();
assert_eq!( assert_eq!(
tm_info.common.subservice, tm_info.common.subservice,
severity_to_subservice(severity) as u8 severity_to_subservice(severity) as u8
@ -417,7 +427,7 @@ mod tests {
let err = reporter.event_info(sender, &time_stamp_empty, event, None); let err = reporter.event_info(sender, &time_stamp_empty, event, None);
assert!(err.is_err()); assert!(err.is_err());
let err = err.unwrap_err(); let err = err.unwrap_err();
if let EcssTmtcErrorWithSend::EcssTmtcError(EcssTmtcError::ByteConversionError( if let EcssTmtcErrorWithSend::EcssTmtcError(EcssTmtcError::ByteConversion(
ByteConversionError::ToSliceTooSmall(missmatch), ByteConversionError::ToSliceTooSmall(missmatch),
)) = err )) = err
{ {

141
satrs-core/src/pus/mod.rs
View File

@ -2,6 +2,8 @@
//! //!
//! This module contains structures to make working with the PUS C standard easier. //! This module contains structures to make working with the PUS C standard easier.
//! The satrs-example application contains various usage examples of these components. //! The satrs-example application contains various usage examples of these components.
use crate::pus::verification::TcStateToken;
use crate::SenderId;
#[cfg(feature = "alloc")] #[cfg(feature = "alloc")]
use downcast_rs::{impl_downcast, Downcast}; use downcast_rs::{impl_downcast, Downcast};
#[cfg(feature = "alloc")] #[cfg(feature = "alloc")]
@ -26,10 +28,28 @@ pub mod verification;
#[cfg(feature = "alloc")] #[cfg(feature = "alloc")]
pub use alloc_mod::*; pub use alloc_mod::*;
use crate::SenderId; use crate::pool::StoreAddr;
#[cfg(feature = "std")] #[cfg(feature = "std")]
pub use std_mod::*; pub use std_mod::*;
#[derive(Debug, PartialEq, Eq, Clone)]
pub enum PusTmWrapper<'tm> {
InStore(StoreAddr),
Direct(PusTm<'tm>),
}
impl From<StoreAddr> for PusTmWrapper<'_> {
fn from(value: StoreAddr) -> Self {
Self::InStore(value)
}
}
impl<'tm> From<PusTm<'tm>> for PusTmWrapper<'tm> {
fn from(value: PusTm<'tm>) -> Self {
Self::Direct(value)
}
}
#[derive(Debug, Clone)] #[derive(Debug, Clone)]
pub enum EcssTmtcErrorWithSend<E> { pub enum EcssTmtcErrorWithSend<E> {
/// Errors related to sending the telemetry to a TMTC recipient /// Errors related to sending the telemetry to a TMTC recipient
@ -47,22 +67,22 @@ impl<E> From<EcssTmtcError> for EcssTmtcErrorWithSend<E> {
#[derive(Debug, Clone)] #[derive(Debug, Clone)]
pub enum EcssTmtcError { pub enum EcssTmtcError {
/// Errors related to the time stamp format of the telemetry /// Errors related to the time stamp format of the telemetry
TimestampError(TimestampError), Timestamp(TimestampError),
/// Errors related to byte conversion, for example insufficient buffer size for given data /// Errors related to byte conversion, for example insufficient buffer size for given data
ByteConversionError(ByteConversionError), ByteConversion(ByteConversionError),
/// Errors related to PUS packet format /// Errors related to PUS packet format
PusError(PusError), Pus(PusError),
} }
impl From<PusError> for EcssTmtcError { impl From<PusError> for EcssTmtcError {
fn from(e: PusError) -> Self { fn from(e: PusError) -> Self {
EcssTmtcError::PusError(e) EcssTmtcError::Pus(e)
} }
} }
impl From<ByteConversionError> for EcssTmtcError { impl From<ByteConversionError> for EcssTmtcError {
fn from(e: ByteConversionError) -> Self { fn from(e: ByteConversionError) -> Self {
EcssTmtcError::ByteConversionError(e) EcssTmtcError::ByteConversion(e)
} }
} }
@ -79,16 +99,17 @@ pub trait EcssSender: Send {
pub trait EcssTmSenderCore: EcssSender { pub trait EcssTmSenderCore: EcssSender {
type Error; type Error;
fn send_tm(&mut self, tm: PusTm) -> Result<(), Self::Error>; fn send_tm(&self, tm: PusTmWrapper) -> Result<(), Self::Error>;
} }
/// Generic trait for a user supplied sender object. /// Generic trait for a user supplied sender object.
/// ///
/// This sender object is responsible for sending PUS telecommands to a TC recipient. /// This sender object is responsible for sending PUS telecommands to a TC recipient. Each
/// telecommand can optionally have a token which contains its verification state.
pub trait EcssTcSenderCore: EcssSender { pub trait EcssTcSenderCore: EcssSender {
type Error; type Error;
fn send_tc(&mut self, tc: PusTc) -> Result<(), Self::Error>; fn send_tc(&self, tc: PusTc, token: Option<TcStateToken>) -> Result<(), Self::Error>;
} }
#[cfg(feature = "alloc")] #[cfg(feature = "alloc")]
@ -142,15 +163,13 @@ pub mod std_mod {
use crate::pus::verification::{ use crate::pus::verification::{
StdVerifReporterWithSender, TcStateAccepted, VerificationToken, StdVerifReporterWithSender, TcStateAccepted, VerificationToken,
}; };
use crate::pus::{EcssSender, EcssTcSenderCore, EcssTmSenderCore}; use crate::pus::{EcssSender, EcssTmSenderCore, PusTmWrapper};
use crate::tmtc::tm_helper::SharedTmStore; use crate::tmtc::tm_helper::SharedTmStore;
use crate::SenderId; use crate::SenderId;
use alloc::vec::Vec; use alloc::vec::Vec;
use spacepackets::ecss::{PusError, SerializablePusPacket}; use spacepackets::ecss::{PusError, SerializablePusPacket};
use spacepackets::tc::PusTc;
use spacepackets::time::cds::TimeProvider; use spacepackets::time::cds::TimeProvider;
use spacepackets::time::{StdTimestampError, TimeWriter}; use spacepackets::time::{StdTimestampError, TimeWriter};
use spacepackets::tm::PusTm;
use std::cell::RefCell; use std::cell::RefCell;
use std::format; use std::format;
use std::string::String; use std::string::String;
@ -158,21 +177,21 @@ pub mod std_mod {
use thiserror::Error; use thiserror::Error;
#[derive(Debug, Clone, Error)] #[derive(Debug, Clone, Error)]
pub enum MpscPusInStoreSendError { pub enum MpscTmInStoreSenderError {
#[error("RwGuard lock error")] #[error("RwGuard lock error")]
LockError, StoreLock,
#[error("Generic PUS error: {0}")] #[error("Generic PUS error: {0}")]
PusError(#[from] PusError), Pus(#[from] PusError),
#[error("Generic store error: {0}")] #[error("Generic store error: {0}")]
StoreError(#[from] StoreError), Store(#[from] StoreError),
#[error("Generic send error: {0}")] #[error("MPSC channel send error: {0}")]
SendError(#[from] mpsc::SendError<StoreAddr>), Send(#[from] mpsc::SendError<StoreAddr>),
#[error("RX handle has disconnected")] #[error("RX handle has disconnected")]
RxDisconnected(StoreAddr), RxDisconnected,
} }
#[derive(Clone)] #[derive(Clone)]
pub struct MpscTmtcInStoreSender { pub struct MpscTmInStoreSender {
id: SenderId, id: SenderId,
name: &'static str, name: &'static str,
store_helper: SharedPool, store_helper: SharedPool,
@ -180,7 +199,7 @@ pub mod std_mod {
pub ignore_poison_errors: bool, pub ignore_poison_errors: bool,
} }
impl EcssSender for MpscTmtcInStoreSender { impl EcssSender for MpscTmInStoreSender {
fn id(&self) -> SenderId { fn id(&self) -> SenderId {
self.id self.id
} }
@ -190,11 +209,11 @@ pub mod std_mod {
} }
} }
impl MpscTmtcInStoreSender { impl MpscTmInStoreSender {
pub fn send_tmtc( pub fn send_direct_tm(
&mut self, &self,
tmtc: impl SerializablePusPacket, tmtc: impl SerializablePusPacket,
) -> Result<(), MpscPusInStoreSendError> { ) -> Result<(), MpscTmInStoreSenderError> {
let operation = |mut store: RwLockWriteGuard<ShareablePoolProvider>| { let operation = |mut store: RwLockWriteGuard<ShareablePoolProvider>| {
let (addr, slice) = store.free_element(tmtc.len_packed())?; let (addr, slice) = store.free_element(tmtc.len_packed())?;
tmtc.write_to_bytes(slice)?; tmtc.write_to_bytes(slice)?;
@ -207,30 +226,28 @@ pub mod std_mod {
if self.ignore_poison_errors { if self.ignore_poison_errors {
operation(e.into_inner()) operation(e.into_inner())
} else { } else {
Err(MpscPusInStoreSendError::LockError) Err(MpscTmInStoreSenderError::StoreLock)
} }
} }
} }
} }
} }
impl EcssTmSenderCore for MpscTmtcInStoreSender { impl EcssTmSenderCore for MpscTmInStoreSender {
type Error = MpscPusInStoreSendError; type Error = MpscTmInStoreSenderError;
fn send_tm(&mut self, tm: PusTm) -> Result<(), Self::Error> { fn send_tm(&self, tm: PusTmWrapper) -> Result<(), Self::Error> {
self.send_tmtc(tm) match tm {
PusTmWrapper::InStore(addr) => self
.sender
.send(addr)
.map_err(MpscTmInStoreSenderError::Send),
PusTmWrapper::Direct(tm) => self.send_direct_tm(tm),
}
} }
} }
impl EcssTcSenderCore for MpscTmtcInStoreSender { impl MpscTmInStoreSender {
type Error = MpscPusInStoreSendError;
fn send_tc(&mut self, tc: PusTc) -> Result<(), Self::Error> {
self.send_tmtc(tc)
}
}
impl MpscTmtcInStoreSender {
pub fn new( pub fn new(
id: SenderId, id: SenderId,
name: &'static str, name: &'static str,
@ -247,13 +264,23 @@ pub mod std_mod {
} }
} }
#[derive(Debug, Clone)] #[derive(Debug, Clone, Error)]
pub enum MpscAsVecSenderError { pub enum MpscTmAsVecSenderError {
PusError(PusError), #[error("Generic PUS error: {0}")]
SendError(mpsc::SendError<Vec<u8>>), Pus(#[from] PusError),
#[error("MPSC channel send error: {0}")]
Send(#[from] mpsc::SendError<Vec<u8>>),
#[error("can not handle store addresses")]
CantSendAddr(StoreAddr),
#[error("RX handle has disconnected")]
RxDisconnected,
} }
#[derive(Debug, Clone)] /// This class can be used if frequent heap allocations during run-time are not an issue.
/// PUS TM packets will be sent around as [Vec]s. Please note that the current implementation
/// of this class can not deal with store addresses, so it is assumed that is is always
/// going to be called with direct packets.
#[derive(Clone)]
pub struct MpscTmAsVecSender { pub struct MpscTmAsVecSender {
id: SenderId, id: SenderId,
sender: mpsc::Sender<Vec<u8>>, sender: mpsc::Sender<Vec<u8>>,
@ -276,16 +303,21 @@ pub mod std_mod {
} }
impl EcssTmSenderCore for MpscTmAsVecSender { impl EcssTmSenderCore for MpscTmAsVecSender {
type Error = MpscAsVecSenderError; type Error = MpscTmAsVecSenderError;
fn send_tm(&mut self, tm: PusTm) -> Result<(), Self::Error> { fn send_tm(&self, tm: PusTmWrapper) -> Result<(), Self::Error> {
let mut vec = Vec::new(); match tm {
tm.append_to_vec(&mut vec) PusTmWrapper::InStore(addr) => Err(MpscTmAsVecSenderError::CantSendAddr(addr)),
.map_err(MpscAsVecSenderError::PusError)?; PusTmWrapper::Direct(tm) => {
self.sender let mut vec = Vec::new();
.send(vec) tm.append_to_vec(&mut vec)
.map_err(MpscAsVecSenderError::SendError)?; .map_err(MpscTmAsVecSenderError::Pus)?;
Ok(()) self.sender
.send(vec)
.map_err(MpscTmAsVecSenderError::Send)?;
Ok(())
}
}
} }
} }
@ -388,6 +420,7 @@ pub mod std_mod {
let time_provider = let time_provider =
TimeProvider::from_now_with_u16_days().map_err(PartialPusHandlingError::Time); TimeProvider::from_now_with_u16_days().map_err(PartialPusHandlingError::Time);
if let Ok(time_provider) = time_provider { if let Ok(time_provider) = time_provider {
// Can't fail, we have a buffer with the exact required size.
time_provider.write_to_bytes(&mut time_stamp).unwrap(); time_provider.write_to_bytes(&mut time_stamp).unwrap();
} else { } else {
*partial_error = Some(time_provider.unwrap_err()); *partial_error = Some(time_provider.unwrap_err());
@ -439,7 +472,7 @@ pub mod std_mod {
pub(crate) fn source_buffer_large_enough(cap: usize, len: usize) -> Result<(), EcssTmtcError> { pub(crate) fn source_buffer_large_enough(cap: usize, len: usize) -> Result<(), EcssTmtcError> {
if len > cap { if len > cap {
return Err(EcssTmtcError::ByteConversionError( return Err(EcssTmtcError::ByteConversion(
ByteConversionError::ToSliceTooSmall(SizeMissmatch { ByteConversionError::ToSliceTooSmall(SizeMissmatch {
found: cap, found: cap,
expected: len, expected: len,

6
satrs-core/src/pus/test.rs
View File

@ -116,9 +116,9 @@ mod tests {
use crate::pool::{LocalPool, PoolCfg, SharedPool}; use crate::pool::{LocalPool, PoolCfg, SharedPool};
use crate::pus::test::PusService17TestHandler; use crate::pus::test::PusService17TestHandler;
use crate::pus::verification::{ use crate::pus::verification::{
MpscVerifSender, RequestId, StdVerifReporterWithSender, VerificationReporterCfg, RequestId, StdVerifReporterWithSender, VerificationReporterCfg,
}; };
use crate::pus::PusServiceHandler; use crate::pus::{MpscTmInStoreSender, PusServiceHandler};
use crate::tmtc::tm_helper::SharedTmStore; use crate::tmtc::tm_helper::SharedTmStore;
use spacepackets::ecss::{PusPacket, SerializablePusPacket}; use spacepackets::ecss::{PusPacket, SerializablePusPacket};
use spacepackets::tc::{PusTc, PusTcSecondaryHeader}; use spacepackets::tc::{PusTc, PusTcSecondaryHeader};
@ -141,7 +141,7 @@ mod tests {
let shared_tm_store = SharedTmStore::new(tm_pool_shared.clone()); let shared_tm_store = SharedTmStore::new(tm_pool_shared.clone());
let (test_srv_tx, test_srv_rx) = mpsc::channel(); let (test_srv_tx, test_srv_rx) = mpsc::channel();
let (tm_tx, tm_rx) = mpsc::channel(); let (tm_tx, tm_rx) = mpsc::channel();
let verif_sender = MpscVerifSender::new( let verif_sender = MpscTmInStoreSender::new(
0, 0,
"verif_sender", "verif_sender",
shared_tm_store.backing_pool(), shared_tm_store.backing_pool(),

531
satrs-core/src/pus/verification.rs
View File

@ -16,8 +16,9 @@
//! use std::sync::{Arc, mpsc, RwLock}; //! use std::sync::{Arc, mpsc, RwLock};
//! use std::time::Duration; //! use std::time::Duration;
//! use satrs_core::pool::{LocalPool, PoolCfg, PoolProvider, SharedPool}; //! use satrs_core::pool::{LocalPool, PoolCfg, PoolProvider, SharedPool};
//! use satrs_core::pus::verification::{MpscVerifSender, VerificationReporterCfg, VerificationReporterWithSender}; //! use satrs_core::pus::verification::{VerificationReporterCfg, VerificationReporterWithSender};
//! use satrs_core::seq_count::SeqCountProviderSimple; //! use satrs_core::seq_count::SeqCountProviderSimple;
//! use satrs_core::pus::MpscTmInStoreSender;
//! use spacepackets::ecss::PusPacket; //! use spacepackets::ecss::PusPacket;
//! use spacepackets::SpHeader; //! use spacepackets::SpHeader;
//! use spacepackets::tc::{PusTc, PusTcSecondaryHeader}; //! use spacepackets::tc::{PusTc, PusTcSecondaryHeader};
@ -29,7 +30,7 @@
//! let pool_cfg = PoolCfg::new(vec![(10, 32), (10, 64), (10, 128), (10, 1024)]); //! let pool_cfg = PoolCfg::new(vec![(10, 32), (10, 64), (10, 128), (10, 1024)]);
//! let shared_tm_pool: SharedPool = Arc::new(RwLock::new(Box::new(LocalPool::new(pool_cfg.clone())))); //! let shared_tm_pool: SharedPool = Arc::new(RwLock::new(Box::new(LocalPool::new(pool_cfg.clone()))));
//! let (verif_tx, verif_rx) = mpsc::channel(); //! let (verif_tx, verif_rx) = mpsc::channel();
//! let sender = MpscVerifSender::new(0, "Test Sender", shared_tm_pool.clone(), verif_tx); //! let sender = MpscTmInStoreSender::new(0, "Test Sender", shared_tm_pool.clone(), verif_tx);
//! let cfg = VerificationReporterCfg::new(TEST_APID, 1, 2, 8).unwrap(); //! let cfg = VerificationReporterCfg::new(TEST_APID, 1, 2, 8).unwrap();
//! let mut reporter = VerificationReporterWithSender::new(&cfg , Box::new(sender)); //! let mut reporter = VerificationReporterWithSender::new(&cfg , Box::new(sender));
//! //!
@ -96,11 +97,8 @@ pub use spacepackets::ecss::verification::*;
pub use alloc_mod::{ pub use alloc_mod::{
VerificationReporter, VerificationReporterCfg, VerificationReporterWithSender, VerificationReporter, VerificationReporterCfg, VerificationReporterWithSender,
}; };
#[cfg(all(feature = "crossbeam", feature = "std"))]
pub use stdmod::CrossbeamVerifSender;
#[cfg(feature = "std")] #[cfg(feature = "std")]
pub use stdmod::{MpscVerifSender, SharedStdVerifReporterWithSender, StdVerifReporterWithSender}; pub use std_mod::*;
/// This is a request identifier as specified in 5.4.11.2 c. of the PUS standard. /// This is a request identifier as specified in 5.4.11.2 c. of the PUS standard.
/// ///
@ -523,7 +521,7 @@ impl VerificationReporterCore {
) -> Result<VerificationToken<TcStateAccepted>, VerificationOrSendErrorWithToken<E, TcStateNone>> ) -> Result<VerificationToken<TcStateAccepted>, VerificationOrSendErrorWithToken<E, TcStateNone>>
{ {
sender sender
.send_tm(sendable.pus_tm.take().unwrap()) .send_tm(sendable.pus_tm.take().unwrap().into())
.map_err(|e| { .map_err(|e| {
VerificationOrSendErrorWithToken( VerificationOrSendErrorWithToken(
EcssTmtcErrorWithSend::SendError(e), EcssTmtcErrorWithSend::SendError(e),
@ -539,7 +537,7 @@ impl VerificationReporterCore {
sender: &mut (impl EcssTmSenderCore<Error = E> + ?Sized), sender: &mut (impl EcssTmSenderCore<Error = E> + ?Sized),
) -> Result<(), VerificationOrSendErrorWithToken<E, TcStateNone>> { ) -> Result<(), VerificationOrSendErrorWithToken<E, TcStateNone>> {
sender sender
.send_tm(sendable.pus_tm.take().unwrap()) .send_tm(sendable.pus_tm.take().unwrap().into())
.map_err(|e| { .map_err(|e| {
VerificationOrSendErrorWithToken( VerificationOrSendErrorWithToken(
EcssTmtcErrorWithSend::SendError(e), EcssTmtcErrorWithSend::SendError(e),
@ -606,7 +604,7 @@ impl VerificationReporterCore {
VerificationOrSendErrorWithToken<E, TcStateAccepted>, VerificationOrSendErrorWithToken<E, TcStateAccepted>,
> { > {
sender sender
.send_tm(sendable.pus_tm.take().unwrap()) .send_tm(sendable.pus_tm.take().unwrap().into())
.map_err(|e| { .map_err(|e| {
VerificationOrSendErrorWithToken( VerificationOrSendErrorWithToken(
EcssTmtcErrorWithSend::SendError(e), EcssTmtcErrorWithSend::SendError(e),
@ -648,7 +646,7 @@ impl VerificationReporterCore {
sender: &mut (impl EcssTmSenderCore<Error = E> + ?Sized), sender: &mut (impl EcssTmSenderCore<Error = E> + ?Sized),
) -> Result<(), VerificationOrSendErrorWithToken<E, TcStateAccepted>> { ) -> Result<(), VerificationOrSendErrorWithToken<E, TcStateAccepted>> {
sender sender
.send_tm(sendable.pus_tm.take().unwrap()) .send_tm(sendable.pus_tm.take().unwrap().into())
.map_err(|e| { .map_err(|e| {
VerificationOrSendErrorWithToken( VerificationOrSendErrorWithToken(
EcssTmtcErrorWithSend::SendError(e), EcssTmtcErrorWithSend::SendError(e),
@ -771,7 +769,7 @@ impl VerificationReporterCore {
sender: &mut (impl EcssTmSenderCore<Error = E> + ?Sized), sender: &mut (impl EcssTmSenderCore<Error = E> + ?Sized),
) -> Result<(), VerificationOrSendErrorWithToken<E, TcState>> { ) -> Result<(), VerificationOrSendErrorWithToken<E, TcState>> {
sender sender
.send_tm(sendable.pus_tm.take().unwrap()) .send_tm(sendable.pus_tm.take().unwrap().into())
.map_err(|e| { .map_err(|e| {
VerificationOrSendErrorWithToken( VerificationOrSendErrorWithToken(
EcssTmtcErrorWithSend::SendError(e), EcssTmtcErrorWithSend::SendError(e),
@ -788,7 +786,7 @@ impl VerificationReporterCore {
sender: &mut (impl EcssTmSenderCore<Error = E> + ?Sized), sender: &mut (impl EcssTmSenderCore<Error = E> + ?Sized),
) -> Result<(), VerificationOrSendErrorWithToken<E, TcState>> { ) -> Result<(), VerificationOrSendErrorWithToken<E, TcState>> {
sender sender
.send_tm(sendable.pus_tm.take().unwrap()) .send_tm(sendable.pus_tm.take().unwrap().into())
.map_err(|e| { .map_err(|e| {
VerificationOrSendErrorWithToken( VerificationOrSendErrorWithToken(
EcssTmtcErrorWithSend::SendError(e), EcssTmtcErrorWithSend::SendError(e),
@ -1329,180 +1327,197 @@ mod alloc_mod {
} }
#[cfg(feature = "std")] #[cfg(feature = "std")]
mod stdmod { mod std_mod {
use super::alloc_mod::VerificationReporterWithSender; use crate::pus::verification::VerificationReporterWithSender;
use super::*; use crate::pus::MpscTmInStoreSenderError;
use crate::pool::{ShareablePoolProvider, SharedPool, StoreAddr}; use std::sync::{Arc, Mutex};
use crate::pus::{EcssSender, MpscPusInStoreSendError};
use crate::SenderId;
use delegate::delegate;
use spacepackets::ecss::SerializablePusPacket;
use spacepackets::tm::PusTm;
use std::sync::{mpsc, Arc, Mutex, RwLockWriteGuard};
pub type StdVerifReporterWithSender = VerificationReporterWithSender<MpscPusInStoreSendError>; // use super::alloc_mod::VerificationReporterWithSender;
// use super::*;
// use crate::pool::{ShareablePoolProvider, SharedPool, StoreAddr};
// use crate::pus::{EcssSender, MpscPusInStoreSendError, PusTmWrapper};
// use crate::SenderId;
// use delegate::delegate;
// use spacepackets::ecss::SerializablePusPacket;
// use std::sync::{mpsc, Arc, Mutex, RwLockWriteGuard};
//
pub type StdVerifReporterWithSender = VerificationReporterWithSender<MpscTmInStoreSenderError>;
pub type SharedStdVerifReporterWithSender = Arc<Mutex<StdVerifReporterWithSender>>; pub type SharedStdVerifReporterWithSender = Arc<Mutex<StdVerifReporterWithSender>>;
//
trait SendBackend: Send { // trait SendBackend: Send {
fn send(&self, addr: StoreAddr) -> Result<(), StoreAddr>; // type SendError: Debug;
} //
// fn send(&self, addr: StoreAddr) -> Result<(), Self::SendError>;
#[derive(Clone)] // }
struct StdSenderBase<S> { //
id: SenderId, // #[derive(Clone)]
name: &'static str, // struct StdSenderBase<S> {
tm_store: SharedPool, // id: SenderId,
tx: S, // name: &'static str,
pub ignore_poison_error: bool, // tm_store: SharedPool,
} // tx: S,
// pub ignore_poison_error: bool,
impl<S: SendBackend> StdSenderBase<S> { // }
pub fn new(id: SenderId, name: &'static str, tm_store: SharedPool, tx: S) -> Self { //
Self { // impl<S: SendBackend> StdSenderBase<S> {
id, // pub fn new(id: SenderId, name: &'static str, tm_store: SharedPool, tx: S) -> Self {
name, // Self {
tm_store, // id,
tx, // name,
ignore_poison_error: false, // tm_store,
} // tx,
} // ignore_poison_error: false,
} // }
// }
unsafe impl<S: Sync> Sync for StdSenderBase<S> {} // }
unsafe impl<S: Send> Send for StdSenderBase<S> {} //
// unsafe impl<S: Sync> Sync for StdSenderBase<S> {}
impl SendBackend for mpsc::Sender<StoreAddr> { // unsafe impl<S: Send> Send for StdSenderBase<S> {}
fn send(&self, addr: StoreAddr) -> Result<(), StoreAddr> { //
self.send(addr).map_err(|_| addr) // impl SendBackend for mpsc::Sender<StoreAddr> {
} // type SendError = mpsc::SendError<StoreAddr>;
} //
// fn send(&self, addr: StoreAddr) -> Result<(), Self::SendError> {
#[derive(Clone)] // self.send(addr)
pub struct MpscVerifSender { // }
base: StdSenderBase<mpsc::Sender<StoreAddr>>, // }
} //
// #[derive(Clone)]
/// Verification sender with a [mpsc::Sender] backend. // pub struct MpscVerifSender {
/// It implements the [EcssTmSenderCore] trait to be used as PUS Verification TM sender. // base: StdSenderBase<mpsc::Sender<StoreAddr>>,
impl MpscVerifSender { // }
pub fn new( //
id: SenderId, // /// Verification sender with a [mpsc::Sender] backend.
name: &'static str, // /// It implements the [EcssTmSenderCore] trait to be used as PUS Verification TM sender.
tm_store: SharedPool, // impl MpscVerifSender {
tx: mpsc::Sender<StoreAddr>, // pub fn new(
) -> Self { // id: SenderId,
Self { // name: &'static str,
base: StdSenderBase::new(id, name, tm_store, tx), // tm_store: SharedPool,
} // tx: mpsc::Sender<StoreAddr>,
} // ) -> Self {
} // Self {
// base: StdSenderBase::new(id, name, tm_store, tx),
//noinspection RsTraitImplementation // }
impl EcssSender for MpscVerifSender { // }
delegate!( // }
to self.base { //
fn id(&self) -> SenderId; // //noinspection RsTraitImplementation
fn name(&self) -> &'static str; // impl EcssSender for MpscVerifSender {
} // delegate!(
); // to self.base {
} // fn id(&self) -> SenderId;
// fn name(&self) -> &'static str;
//noinspection RsTraitImplementation // }
impl EcssTmSenderCore for MpscVerifSender { // );
type Error = MpscPusInStoreSendError; // }
//
delegate!( // //noinspection RsTraitImplementation
to self.base { // impl EcssTmSenderCore for MpscVerifSender {
fn send_tm(&mut self, tm: PusTm) -> Result<(), Self::Error>; // type Error = MpscPusInStoreSendError;
} //
); // delegate!(
} // to self.base {
// fn send_tm(&self, tm: PusTmWrapper) -> Result<(), Self::Error>;
impl SendBackend for crossbeam_channel::Sender<StoreAddr> { // }
fn send(&self, addr: StoreAddr) -> Result<(), StoreAddr> { // );
self.send(addr).map_err(|_| addr) // }
} //
} // impl SendBackend for crossbeam_channel::Sender<StoreAddr> {
// type SendError = crossbeam_channel::SendError<StoreAddr>;
/// Verification sender with a [crossbeam_channel::Sender] backend. //
/// It implements the [EcssTmSenderCore] trait to be used as PUS Verification TM sender // fn send(&self, addr: StoreAddr) -> Result<(), Self::SendError> {
#[cfg(feature = "crossbeam")] // self.send(addr)
#[derive(Clone)] // }
pub struct CrossbeamVerifSender { // }
base: StdSenderBase<crossbeam_channel::Sender<StoreAddr>>, //
} // /// Verification sender with a [crossbeam_channel::Sender] backend.
// /// It implements the [EcssTmSenderCore] trait to be used as PUS Verification TM sender
#[cfg(feature = "crossbeam")] // #[cfg(feature = "crossbeam")]
impl CrossbeamVerifSender { // #[derive(Clone)]
pub fn new( // pub struct CrossbeamVerifSender {
id: SenderId, // base: StdSenderBase<crossbeam_channel::Sender<StoreAddr>>,
name: &'static str, // }
tm_store: SharedPool, //
tx: crossbeam_channel::Sender<StoreAddr>, // #[cfg(feature = "crossbeam")]
) -> Self { // impl CrossbeamVerifSender {
Self { // pub fn new(
base: StdSenderBase::new(id, name, tm_store, tx), // id: SenderId,
} // name: &'static str,
} // tm_store: SharedPool,
} // tx: crossbeam_channel::Sender<StoreAddr>,
// ) -> Self {
//noinspection RsTraitImplementation // Self {
#[cfg(feature = "crossbeam")] // base: StdSenderBase::new(id, name, tm_store, tx),
impl EcssSender for CrossbeamVerifSender { // }
delegate!( // }
to self.base { // }
fn id(&self) -> SenderId; //
fn name(&self) -> &'static str; // //noinspection RsTraitImplementation
} // #[cfg(feature = "crossbeam")]
); // impl EcssSender for CrossbeamVerifSender {
} // delegate!(
// to self.base {
//noinspection RsTraitImplementation // fn id(&self) -> SenderId;
#[cfg(feature = "crossbeam")] // fn name(&self) -> &'static str;
impl EcssTmSenderCore for CrossbeamVerifSender { // }
type Error = MpscPusInStoreSendError; // );
// }
delegate!( //
to self.base { // //noinspection RsTraitImplementation
fn send_tm(&mut self, tm: PusTm) -> Result<(), Self::Error>; // #[cfg(feature = "crossbeam")]
} // impl EcssTmSenderCore for CrossbeamVerifSender {
); // type Error = MpscPusInStoreSendError;
} //
// delegate!(
impl<S: SendBackend + Clone + 'static> EcssSender for StdSenderBase<S> { // to self.base {
fn id(&self) -> SenderId { // fn send_tm(&mut self, tm: PusTm) -> Result<(), Self::Error>;
self.id // }
} // );
fn name(&self) -> &'static str { // }
self.name //
} // impl<S: SendBackend + Clone + 'static> EcssSender for StdSenderBase<S> {
} // fn id(&self) -> SenderId {
impl<S: SendBackend + Clone + 'static> EcssTmSenderCore for StdSenderBase<S> { // self.id
type Error = MpscPusInStoreSendError; // }
// fn name(&self) -> &'static str {
fn send_tm(&mut self, tm: PusTm) -> Result<(), Self::Error> { // self.name
let operation = |mut mg: RwLockWriteGuard<ShareablePoolProvider>| { // }
let (addr, buf) = mg.free_element(tm.len_packed())?; // }
tm.write_to_bytes(buf) // impl<S: SendBackend + Clone + 'static> EcssTmSenderCore for StdSenderBase<S> {
.map_err(MpscPusInStoreSendError::PusError)?; // type Error = MpscPusInStoreSendError;
drop(mg); //
self.tx // fn send_tm(&self, tm: PusTmWrapper) -> Result<(), Self::Error> {
.send(addr) // match tm {
.map_err(|_| MpscPusInStoreSendError::RxDisconnected(addr))?; // PusTmWrapper::InStore(addr) => {
Ok(()) // self.tx.send(addr).unwrap();
}; // Ok(())
match self.tm_store.write() { // }
Ok(lock) => operation(lock), // PusTmWrapper::Direct(tm) => {
Err(poison_error) => { // let operation = |mut mg: RwLockWriteGuard<ShareablePoolProvider>| {
if self.ignore_poison_error { // let (addr, buf) = mg.free_element(tm.len_packed())?;
operation(poison_error.into_inner()) // tm.write_to_bytes(buf)
} else { // .map_err(MpscPusInStoreSendError::Pus)?;
Err(MpscPusInStoreSendError::LockError) // drop(mg);
} // self.tx
} // .send(addr)
} // .map_err(|_| MpscPusInStoreSendError::RxDisconnected(addr))?;
} // Ok(())
} // };
// match self.tm_store.write() {
// Ok(lock) => operation(lock),
// Err(poison_error) => {
// if self.ignore_poison_error {
// operation(poison_error.into_inner())
// } else {
// Err(MpscPusInStoreSendError::StoreLock)
// }
// }
// }
// }
// }
// }
// }
} }
#[cfg(test)] #[cfg(test)]
@ -1510,11 +1525,11 @@ mod tests {
use crate::pool::{LocalPool, PoolCfg, SharedPool}; use crate::pool::{LocalPool, PoolCfg, SharedPool};
use crate::pus::tests::CommonTmInfo; use crate::pus::tests::CommonTmInfo;
use crate::pus::verification::{ use crate::pus::verification::{
EcssTmSenderCore, EcssTmtcError, FailParams, FailParamsWithStep, MpscVerifSender, EcssTmSenderCore, EcssTmtcError, FailParams, FailParamsWithStep, RequestId, TcStateNone,
RequestId, TcStateNone, VerificationReporter, VerificationReporterCfg, VerificationReporter, VerificationReporterCfg, VerificationReporterWithSender,
VerificationReporterWithSender, VerificationToken, VerificationToken,
}; };
use crate::pus::{EcssSender, EcssTmtcErrorWithSend}; use crate::pus::{EcssSender, EcssTmtcErrorWithSend, MpscTmInStoreSender, PusTmWrapper};
use crate::SenderId; use crate::SenderId;
use alloc::boxed::Box; use alloc::boxed::Box;
use alloc::format; use alloc::format;
@ -1523,6 +1538,7 @@ mod tests {
use spacepackets::tm::PusTm; use spacepackets::tm::PusTm;
use spacepackets::util::UnsignedEnum; use spacepackets::util::UnsignedEnum;
use spacepackets::{ByteConversionError, CcsdsPacket, SpHeader}; use spacepackets::{ByteConversionError, CcsdsPacket, SpHeader};
use std::cell::RefCell;
use std::collections::VecDeque; use std::collections::VecDeque;
use std::sync::{mpsc, Arc, RwLock}; use std::sync::{mpsc, Arc, RwLock};
use std::time::Duration; use std::time::Duration;
@ -1545,7 +1561,7 @@ mod tests {
#[derive(Default, Clone)] #[derive(Default, Clone)]
struct TestSender { struct TestSender {
pub service_queue: VecDeque<TmInfo>, pub service_queue: RefCell<VecDeque<TmInfo>>,
} }
impl EcssSender for TestSender { impl EcssSender for TestSender {
@ -1560,26 +1576,34 @@ mod tests {
impl EcssTmSenderCore for TestSender { impl EcssTmSenderCore for TestSender {
type Error = (); type Error = ();
fn send_tm(&mut self, tm: PusTm) -> Result<(), Self::Error> { fn send_tm(&self, tm: PusTmWrapper) -> Result<(), Self::Error> {
assert_eq!(PusPacket::service(&tm), 1); match tm {
assert!(tm.source_data().is_some()); PusTmWrapper::InStore(_) => {
let mut time_stamp = [0; 7]; panic!("TestSender: Can not deal with addresses");
time_stamp.clone_from_slice(&tm.timestamp().unwrap()[0..7]); }
let src_data = tm.source_data().unwrap(); PusTmWrapper::Direct(tm) => {
assert!(src_data.len() >= 4); assert_eq!(PusPacket::service(&tm), 1);
let req_id = RequestId::from_bytes(&src_data[0..RequestId::SIZE_AS_BYTES]).unwrap(); assert!(tm.source_data().is_some());
let mut vec = None; let mut time_stamp = [0; 7];
if src_data.len() > 4 { time_stamp.clone_from_slice(&tm.timestamp().unwrap()[0..7]);
let mut new_vec = Vec::new(); let src_data = tm.source_data().unwrap();
new_vec.extend_from_slice(&src_data[RequestId::SIZE_AS_BYTES..]); assert!(src_data.len() >= 4);
vec = Some(new_vec); let req_id =
RequestId::from_bytes(&src_data[0..RequestId::SIZE_AS_BYTES]).unwrap();
let mut vec = None;
if src_data.len() > 4 {
let mut new_vec = Vec::new();
new_vec.extend_from_slice(&src_data[RequestId::SIZE_AS_BYTES..]);
vec = Some(new_vec);
}
self.service_queue.borrow_mut().push_back(TmInfo {
common: CommonTmInfo::new_from_tm(&tm),
req_id,
additional_data: vec,
});
Ok(())
}
} }
self.service_queue.push_back(TmInfo {
common: CommonTmInfo::new_from_tm(&tm),
req_id,
additional_data: vec,
});
Ok(())
} }
} }
@ -1595,7 +1619,7 @@ mod tests {
} }
impl EcssTmSenderCore for FallibleSender { impl EcssTmSenderCore for FallibleSender {
type Error = DummyError; type Error = DummyError;
fn send_tm(&mut self, _: PusTm) -> Result<(), Self::Error> { fn send_tm(&self, _: PusTmWrapper) -> Result<(), Self::Error> {
Err(DummyError {}) Err(DummyError {})
} }
} }
@ -1672,8 +1696,9 @@ mod tests {
additional_data: None, additional_data: None,
req_id: req_id.clone(), req_id: req_id.clone(),
}; };
assert_eq!(sender.service_queue.len(), 1); let mut service_queue = sender.service_queue.borrow_mut();
let info = sender.service_queue.pop_front().unwrap(); assert_eq!(service_queue.len(), 1);
let info = service_queue.pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
} }
@ -1682,7 +1707,7 @@ mod tests {
let pool = LocalPool::new(PoolCfg::new(vec![(8, 8)])); let pool = LocalPool::new(PoolCfg::new(vec![(8, 8)]));
let shared_pool: SharedPool = Arc::new(RwLock::new(Box::new(pool))); let shared_pool: SharedPool = Arc::new(RwLock::new(Box::new(pool)));
let (tx, _) = mpsc::channel(); let (tx, _) = mpsc::channel();
let mpsc_verif_sender = MpscVerifSender::new(0, "verif_sender", shared_pool, tx); let mpsc_verif_sender = MpscTmInStoreSender::new(0, "verif_sender", shared_pool, tx);
is_send(&mpsc_verif_sender); is_send(&mpsc_verif_sender);
} }
@ -1742,8 +1767,9 @@ mod tests {
additional_data: Some([0, 2].to_vec()), additional_data: Some([0, 2].to_vec()),
req_id, req_id,
}; };
assert_eq!(sender.service_queue.len(), 1); let mut service_queue = sender.service_queue.borrow_mut();
let info = sender.service_queue.pop_front().unwrap(); assert_eq!(service_queue.len(), 1);
let info = service_queue.pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
} }
@ -1793,20 +1819,18 @@ mod tests {
let err_with_token = res.unwrap_err(); let err_with_token = res.unwrap_err();
assert_eq!(err_with_token.1, tok); assert_eq!(err_with_token.1, tok);
match err_with_token.0 { match err_with_token.0 {
EcssTmtcErrorWithSend::EcssTmtcError(EcssTmtcError::ByteConversionError(e)) => { EcssTmtcErrorWithSend::EcssTmtcError(EcssTmtcError::ByteConversion(e)) => match e {
match e { ByteConversionError::ToSliceTooSmall(missmatch) => {
ByteConversionError::ToSliceTooSmall(missmatch) => { assert_eq!(
assert_eq!( missmatch.expected,
missmatch.expected, fail_data.len() + RequestId::SIZE_AS_BYTES + fail_code.size()
fail_data.len() + RequestId::SIZE_AS_BYTES + fail_code.size() );
); assert_eq!(missmatch.found, b.rep().allowed_source_data_len());
assert_eq!(missmatch.found, b.rep().allowed_source_data_len());
}
_ => {
panic!("{}", format!("Unexpected error {:?}", e))
}
} }
} _ => {
panic!("{}", format!("Unexpected error {:?}", e))
}
},
_ => { _ => {
panic!("{}", format!("Unexpected error {:?}", err_with_token.0)) panic!("{}", format!("Unexpected error {:?}", err_with_token.0))
} }
@ -1839,13 +1863,15 @@ mod tests {
additional_data: Some([10, 0, 0, 0, 12].to_vec()), additional_data: Some([10, 0, 0, 0, 12].to_vec()),
req_id: tok.req_id, req_id: tok.req_id,
}; };
assert_eq!(sender.service_queue.len(), 1); let mut service_queue = sender.service_queue.borrow_mut();
let info = sender.service_queue.pop_front().unwrap(); assert_eq!(service_queue.len(), 1);
let info = service_queue.pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
} }
fn start_fail_check(sender: &mut TestSender, req_id: RequestId, fail_data_raw: [u8; 4]) { fn start_fail_check(sender: &mut TestSender, req_id: RequestId, fail_data_raw: [u8; 4]) {
assert_eq!(sender.service_queue.len(), 2); let mut srv_queue = sender.service_queue.borrow_mut();
assert_eq!(srv_queue.len(), 2);
let mut cmp_info = TmInfo { let mut cmp_info = TmInfo {
common: CommonTmInfo { common: CommonTmInfo {
subservice: 1, subservice: 1,
@ -1857,7 +1883,7 @@ mod tests {
additional_data: None, additional_data: None,
req_id, req_id,
}; };
let mut info = sender.service_queue.pop_front().unwrap(); let mut info = srv_queue.pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
cmp_info = TmInfo { cmp_info = TmInfo {
@ -1871,7 +1897,7 @@ mod tests {
additional_data: Some([&[22], fail_data_raw.as_slice()].concat().to_vec()), additional_data: Some([&[22], fail_data_raw.as_slice()].concat().to_vec()),
req_id, req_id,
}; };
info = sender.service_queue.pop_front().unwrap(); info = srv_queue.pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
} }
@ -1937,7 +1963,8 @@ mod tests {
additional_data: None, additional_data: None,
req_id, req_id,
}; };
let mut info = sender.service_queue.pop_front().unwrap(); let mut srv_queue = sender.service_queue.borrow_mut();
let mut info = srv_queue.pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
cmp_info = TmInfo { cmp_info = TmInfo {
common: CommonTmInfo { common: CommonTmInfo {
@ -1950,7 +1977,7 @@ mod tests {
additional_data: None, additional_data: None,
req_id, req_id,
}; };
info = sender.service_queue.pop_front().unwrap(); info = srv_queue.pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
cmp_info = TmInfo { cmp_info = TmInfo {
common: CommonTmInfo { common: CommonTmInfo {
@ -1963,7 +1990,7 @@ mod tests {
additional_data: Some([0].to_vec()), additional_data: Some([0].to_vec()),
req_id, req_id,
}; };
info = sender.service_queue.pop_front().unwrap(); info = srv_queue.pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
cmp_info = TmInfo { cmp_info = TmInfo {
common: CommonTmInfo { common: CommonTmInfo {
@ -1976,7 +2003,7 @@ mod tests {
additional_data: Some([1].to_vec()), additional_data: Some([1].to_vec()),
req_id, req_id,
}; };
info = sender.service_queue.pop_front().unwrap(); info = srv_queue.pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
} }
@ -2011,7 +2038,7 @@ mod tests {
) )
.expect("Sending step 1 success failed"); .expect("Sending step 1 success failed");
assert_eq!(empty, ()); assert_eq!(empty, ());
assert_eq!(sender.service_queue.len(), 4); assert_eq!(sender.service_queue.borrow().len(), 4);
step_success_check(&mut sender, tok.req_id); step_success_check(&mut sender, tok.req_id);
} }
@ -2037,12 +2064,12 @@ mod tests {
.expect("Sending step 1 success failed"); .expect("Sending step 1 success failed");
assert_eq!(empty, ()); assert_eq!(empty, ());
let sender: &mut TestSender = b.helper.sender.downcast_mut().unwrap(); let sender: &mut TestSender = b.helper.sender.downcast_mut().unwrap();
assert_eq!(sender.service_queue.len(), 4); assert_eq!(sender.service_queue.borrow().len(), 4);
step_success_check(sender, tok.req_id); step_success_check(sender, tok.req_id);
} }
fn check_step_failure(sender: &mut TestSender, req_id: RequestId, fail_data_raw: [u8; 4]) { fn check_step_failure(sender: &mut TestSender, req_id: RequestId, fail_data_raw: [u8; 4]) {
assert_eq!(sender.service_queue.len(), 4); assert_eq!(sender.service_queue.borrow().len(), 4);
let mut cmp_info = TmInfo { let mut cmp_info = TmInfo {
common: CommonTmInfo { common: CommonTmInfo {
subservice: 1, subservice: 1,
@ -2054,7 +2081,7 @@ mod tests {
additional_data: None, additional_data: None,
req_id, req_id,
}; };
let mut info = sender.service_queue.pop_front().unwrap(); let mut info = sender.service_queue.borrow_mut().pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
cmp_info = TmInfo { cmp_info = TmInfo {
@ -2068,7 +2095,7 @@ mod tests {
additional_data: None, additional_data: None,
req_id, req_id,
}; };
info = sender.service_queue.pop_front().unwrap(); info = sender.service_queue.borrow_mut().pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
cmp_info = TmInfo { cmp_info = TmInfo {
@ -2082,7 +2109,7 @@ mod tests {
additional_data: Some([0].to_vec()), additional_data: Some([0].to_vec()),
req_id, req_id,
}; };
info = sender.service_queue.pop_front().unwrap(); info = sender.service_queue.get_mut().pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
cmp_info = TmInfo { cmp_info = TmInfo {
@ -2104,7 +2131,7 @@ mod tests {
), ),
req_id, req_id,
}; };
info = sender.service_queue.pop_front().unwrap(); info = sender.service_queue.get_mut().pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
} }
@ -2186,7 +2213,7 @@ mod tests {
} }
fn completion_fail_check(sender: &mut TestSender, req_id: RequestId) { fn completion_fail_check(sender: &mut TestSender, req_id: RequestId) {
assert_eq!(sender.service_queue.len(), 3); assert_eq!(sender.service_queue.borrow().len(), 3);
let mut cmp_info = TmInfo { let mut cmp_info = TmInfo {
common: CommonTmInfo { common: CommonTmInfo {
@ -2199,7 +2226,7 @@ mod tests {
additional_data: None, additional_data: None,
req_id, req_id,
}; };
let mut info = sender.service_queue.pop_front().unwrap(); let mut info = sender.service_queue.get_mut().pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
cmp_info = TmInfo { cmp_info = TmInfo {
@ -2213,7 +2240,7 @@ mod tests {
additional_data: None, additional_data: None,
req_id, req_id,
}; };
info = sender.service_queue.pop_front().unwrap(); info = sender.service_queue.get_mut().pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
cmp_info = TmInfo { cmp_info = TmInfo {
@ -2227,7 +2254,7 @@ mod tests {
additional_data: Some([0, 0, 0x10, 0x20].to_vec()), additional_data: Some([0, 0, 0x10, 0x20].to_vec()),
req_id, req_id,
}; };
info = sender.service_queue.pop_front().unwrap(); info = sender.service_queue.get_mut().pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
} }
@ -2277,7 +2304,7 @@ mod tests {
} }
fn completion_success_check(sender: &mut TestSender, req_id: RequestId) { fn completion_success_check(sender: &mut TestSender, req_id: RequestId) {
assert_eq!(sender.service_queue.len(), 3); assert_eq!(sender.service_queue.borrow().len(), 3);
let cmp_info = TmInfo { let cmp_info = TmInfo {
common: CommonTmInfo { common: CommonTmInfo {
subservice: 1, subservice: 1,
@ -2289,7 +2316,7 @@ mod tests {
additional_data: None, additional_data: None,
req_id, req_id,
}; };
let mut info = sender.service_queue.pop_front().unwrap(); let mut info = sender.service_queue.borrow_mut().pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
let cmp_info = TmInfo { let cmp_info = TmInfo {
@ -2303,7 +2330,7 @@ mod tests {
additional_data: None, additional_data: None,
req_id, req_id,
}; };
info = sender.service_queue.pop_front().unwrap(); info = sender.service_queue.borrow_mut().pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
let cmp_info = TmInfo { let cmp_info = TmInfo {
common: CommonTmInfo { common: CommonTmInfo {
@ -2316,7 +2343,7 @@ mod tests {
additional_data: None, additional_data: None,
req_id, req_id,
}; };
info = sender.service_queue.pop_front().unwrap(); info = sender.service_queue.borrow_mut().pop_front().unwrap();
assert_eq!(info, cmp_info); assert_eq!(info, cmp_info);
} }
@ -2365,7 +2392,7 @@ mod tests {
Arc::new(RwLock::new(Box::new(LocalPool::new(pool_cfg.clone())))); Arc::new(RwLock::new(Box::new(LocalPool::new(pool_cfg.clone()))));
let (verif_tx, verif_rx) = mpsc::channel(); let (verif_tx, verif_rx) = mpsc::channel();
let sender = let sender =
MpscVerifSender::new(0, "Verification Sender", shared_tm_pool.clone(), verif_tx); MpscTmInStoreSender::new(0, "Verification Sender", shared_tm_pool.clone(), verif_tx);
let cfg = VerificationReporterCfg::new(TEST_APID, 1, 2, 8).unwrap(); let cfg = VerificationReporterCfg::new(TEST_APID, 1, 2, 8).unwrap();
let mut reporter = VerificationReporterWithSender::new(&cfg, Box::new(sender)); let mut reporter = VerificationReporterWithSender::new(&cfg, Box::new(sender));

11
satrs-core/tests/pus_verification.rs
View File

@ -1,17 +1,18 @@
// TODO: Refactor this to also test the STD impl using mpsc // TODO: Refactor this to also test the STD impl using mpsc
// TODO: Change back to cross-beam as soon as STD impl was added back for TM.
#[cfg(feature = "crossbeam")] #[cfg(feature = "crossbeam")]
pub mod crossbeam_test { pub mod crossbeam_test {
use hashbrown::HashMap; use hashbrown::HashMap;
use satrs_core::pool::{LocalPool, PoolCfg, PoolProvider, SharedPool}; use satrs_core::pool::{LocalPool, PoolCfg, PoolProvider, SharedPool};
use satrs_core::pus::verification::{ use satrs_core::pus::verification::{
CrossbeamVerifSender, FailParams, RequestId, VerificationReporterCfg, FailParams, RequestId, VerificationReporterCfg, VerificationReporterWithSender,
VerificationReporterWithSender,
}; };
use satrs_core::pus::MpscTmInStoreSender;
use spacepackets::ecss::{EcssEnumU16, EcssEnumU8, PusPacket, SerializablePusPacket}; use spacepackets::ecss::{EcssEnumU16, EcssEnumU8, PusPacket, SerializablePusPacket};
use spacepackets::tc::{PusTc, PusTcSecondaryHeader}; use spacepackets::tc::{PusTc, PusTcSecondaryHeader};
use spacepackets::tm::PusTm; use spacepackets::tm::PusTm;
use spacepackets::SpHeader; use spacepackets::SpHeader;
use std::sync::{Arc, RwLock}; use std::sync::{mpsc, Arc, RwLock};
use std::thread; use std::thread;
use std::time::Duration; use std::time::Duration;
@ -38,9 +39,9 @@ pub mod crossbeam_test {
Arc::new(RwLock::new(Box::new(LocalPool::new(pool_cfg.clone())))); Arc::new(RwLock::new(Box::new(LocalPool::new(pool_cfg.clone()))));
let shared_tc_pool_0 = Arc::new(RwLock::new(LocalPool::new(pool_cfg))); let shared_tc_pool_0 = Arc::new(RwLock::new(LocalPool::new(pool_cfg)));
let shared_tc_pool_1 = shared_tc_pool_0.clone(); let shared_tc_pool_1 = shared_tc_pool_0.clone();
let (tx, rx) = crossbeam_channel::bounded(5); let (tx, rx) = mpsc::channel();
let sender = let sender =
CrossbeamVerifSender::new(0, "verif_sender", shared_tm_pool.clone(), tx.clone()); MpscTmInStoreSender::new(0, "verif_sender", shared_tm_pool.clone(), tx.clone());
let mut reporter_with_sender_0 = let mut reporter_with_sender_0 =
VerificationReporterWithSender::new(&cfg, Box::new(sender)); VerificationReporterWithSender::new(&cfg, Box::new(sender));
let mut reporter_with_sender_1 = reporter_with_sender_0.clone(); let mut reporter_with_sender_1 = reporter_with_sender_0.clone();

10
satrs-example/src/main.rs
View File

@ -32,10 +32,8 @@ use satrs_core::pus::hk::Subservice as HkSubservice;
use satrs_core::pus::scheduler::PusScheduler; use satrs_core::pus::scheduler::PusScheduler;
use satrs_core::pus::scheduler_srv::PusService11SchedHandler; use satrs_core::pus::scheduler_srv::PusService11SchedHandler;
use satrs_core::pus::test::PusService17TestHandler; use satrs_core::pus::test::PusService17TestHandler;
use satrs_core::pus::verification::{ use satrs_core::pus::verification::{VerificationReporterCfg, VerificationReporterWithSender};
MpscVerifSender, VerificationReporterCfg, VerificationReporterWithSender, use satrs_core::pus::MpscTmInStoreSender;
};
use satrs_core::pus::MpscTmtcInStoreSender;
use satrs_core::seq_count::{CcsdsSimpleSeqCountProvider, SequenceCountProviderCore}; use satrs_core::seq_count::{CcsdsSimpleSeqCountProvider, SequenceCountProviderCore};
use satrs_core::spacepackets::tm::PusTmZeroCopyWriter; use satrs_core::spacepackets::tm::PusTmZeroCopyWriter;
use satrs_core::spacepackets::{ use satrs_core::spacepackets::{
@ -85,7 +83,7 @@ fn main() {
let (tc_source_tx, tc_source_rx) = channel(); let (tc_source_tx, tc_source_rx) = channel();
let (tm_funnel_tx, tm_funnel_rx) = channel(); let (tm_funnel_tx, tm_funnel_rx) = channel();
let (tm_server_tx, tm_server_rx) = channel(); let (tm_server_tx, tm_server_rx) = channel();
let verif_sender = MpscVerifSender::new( let verif_sender = MpscTmInStoreSender::new(
0, 0,
"verif_sender", "verif_sender",
tm_store.backing_pool(), tm_store.backing_pool(),
@ -271,7 +269,7 @@ fn main() {
.name("Event".to_string()) .name("Event".to_string())
.spawn(move || { .spawn(move || {
let mut timestamp: [u8; 7] = [0; 7]; let mut timestamp: [u8; 7] = [0; 7];
let mut sender = MpscTmtcInStoreSender::new( let mut sender = MpscTmInStoreSender::new(
1, 1,
"event_sender", "event_sender",
tm_store_event.backing_pool(), tm_store_event.backing_pool(),