Implementation of scheduler in pus and tmtc handler #29

Merged
muellerr merged 13 commits from pus_schedule_implementation into main 2023-02-01 13:40:49 +01:00
Member
No description provided.
lkoester added 9 commits 2023-01-27 14:03:09 +01:00
lkoester added the
enhancement
label 2023-01-27 14:03:22 +01:00
lkoester requested review from muellerr 2023-01-27 14:03:25 +01:00
lkoester changed title from Implementation of scheduler in pus and tmtc handler to WIP: Implementation of scheduler in pus and tmtc handler 2023-01-27 14:05:10 +01:00
lkoester added 1 commit 2023-01-27 15:38:14 +01:00
muellerr requested changes 2023-01-30 09:46:21 +01:00
@ -12,0 +19,4 @@
pub enum ScheduleError {
PusError(PusError),
TimeMarginTooShort(UnixTimestamp, UnixTimestamp),
NestedScheduledTC,
Owner

TC -> Tc for consistency

TC -> Tc for consistency
Author
Member

Passt

Passt
lkoester marked this conversation as resolved
@ -50,6 +134,7 @@ impl PusScheduler {
}
/// Like [Self::new], but sets the `init_current_time` parameter to the current system time.
Owner

I think this newline is problematic

I think this newline is problematic
lkoester marked this conversation as resolved
@ -121,0 +221,4 @@
) -> Result<StoreAddr, ScheduleError> {
let check_tc = PusTc::from_bytes(tc)?;
if PusPacket::service(&check_tc.0) == 11 && PusPacket::subservice(&check_tc.0) == 4 {
// TODO: should not be able to schedule a scheduled tc
Owner

TODO can be removed probably

TODO can be removed probably
lkoester marked this conversation as resolved
@ -1,3 +1,5 @@
extern crate core;
Owner

What does this do?

What does this do?
Author
Member

Not entirely sure, I think it was an IDE auto import, commented it out and everything seems to work fine so I think it can be deleted

Not entirely sure, I think it was an IDE auto import, commented it out and everything seems to work fine so I think it can be deleted
lkoester marked this conversation as resolved
lkoester added 1 commit 2023-01-30 09:51:58 +01:00
Author
Member

Still TODO: pyclient scheduler implementation

Still TODO: pyclient scheduler implementation
lkoester added 1 commit 2023-01-30 13:49:29 +01:00
lkoester changed title from WIP: Implementation of scheduler in pus and tmtc handler to Implementation of scheduler in pus and tmtc handler 2023-01-30 13:49:46 +01:00
lkoester requested review from muellerr 2023-01-30 13:50:27 +01:00
muellerr requested changes 2023-01-30 16:18:37 +01:00
muellerr left a comment
Owner

log folder in satrs-core should be removed

log folder in satrs-core should be removed
@ -8,1 +10,4 @@
use spacepackets::time::cds::DaysLen24Bits;
use spacepackets::time::{CcsdsTimeProvider, TimeReader, TimestampError, UnixTimestamp};
use std::collections::BTreeMap;
use std::dbg;
Owner

should be removed (or put behind std feature and `#[allow(unused_imports)]

should be removed (or put behind std feature and `#[allow(unused_imports)]
lkoester marked this conversation as resolved
muellerr requested changes 2023-01-30 16:20:17 +01:00
@ -276,0 +381,4 @@
.completion_success(start_token, Some(&self.time_stamp))
.expect("Error sending completion success");
//let addr = self.tc_source.tc_store.add_pus_tc().unwrap();
Owner

maybe this can be deleted as well?

maybe this can be deleted as well?
lkoester marked this conversation as resolved
@ -178,0 +202,4 @@
&mut udp_tmtc_server,
&mut tc_args,
&mut tc_buf,
//&mut tc_source,
Owner

old code can be deleted

old code can be deleted
lkoester marked this conversation as resolved
@ -183,2 +215,4 @@
udp_tmtc_server: &mut UdpTmtcServer,
tc_args: &mut TcArgs,
tc_buf: &mut [u8],
//tc_source: &mut PusTcSource,
Owner

unused code can be deleted

unused code can be deleted
lkoester marked this conversation as resolved
@ -187,0 +244,4 @@
}
Err(_) => {}
}
//.expect("error releasing tc");
Owner

can be deleted

can be deleted
lkoester marked this conversation as resolved
lkoester added 1 commit 2023-02-01 10:26:58 +01:00
lkoester requested review from muellerr 2023-02-01 10:27:15 +01:00
muellerr approved these changes 2023-02-01 13:40:35 +01:00
muellerr merged commit fac8775464 into main 2023-02-01 13:40:49 +01:00
muellerr deleted branch pus_schedule_implementation 2023-02-01 13:40:51 +01:00
muellerr added this to the satrs v0.1.0 milestone 2023-02-14 16:32:46 +01:00
Sign in to join this conversation.
No description provided.