TargetIdWithApid #63

Merged
muellerr merged 14 commits from TargetIdWithApid into main 2024-01-31 11:06:34 +01:00
Member
No description provided.
lkoester added 4 commits 2023-08-15 21:07:45 +02:00
still broken
Some checks failed
Rust/sat-rs/pipeline/head There was a failure building this commit
5aa2ec74ba
remove unused imports
Some checks failed
Rust/sat-rs/pipeline/head There was a failure building this commit
26404cdfe1
added HkUniqueId
Some checks failed
Rust/sat-rs/pipeline/head There was a failure building this commit
Rust/sat-rs/pipeline/pr-main There was a failure building this commit
a3311f102e
muellerr requested changes 2023-08-15 21:16:20 +02:00
@ -5,0 +9,4 @@
#[derive(Debug, new, Copy, Clone)]
pub struct HkUniqueId {
id: u32,
Owner

I would make the set_id (u32) a member and rename id to target_id

I would make the `set_id` (u32) a member and rename id to `target_id`
lkoester marked this conversation as resolved
@ -5,0 +19,4 @@
}
impl HkUniqueId {
pub fn id(&self) -> u32 {
Owner

target_id

`target_id`
lkoester marked this conversation as resolved
@ -5,0 +23,4 @@
self.id
}
pub fn bytes_from_target_id(&self, buf: &mut [u8], target_id: u32) -> Result<(), ()> {
Owner

I would rename this to write_to_be_bytes for consistent naming. targetID and set ID are members to they do not need to be input parameters.

Returntype probably is Result<usize, ByteConversionError>. returning the written size makes it easier to chain low level write conversions

I would rename this to `write_to_be_bytes` for consistent naming. targetID and set ID are members to they do not need to be input parameters. Returntype probably is `Result<usize, ByteConversionError>`. returning the written size makes it easier to chain low level write conversions
muellerr marked this conversation as resolved
@ -5,0 +33,4 @@
Ok(())
}
pub fn bytes_from_target_id_with_apid(&self, buf: &mut [u8], target_id: TargetIdWithApid) -> Result<(), ()> {
Owner

I'd create a constructor which constructs this type from a TargetIdWithApid and the unique ID ( u32)

I'd create a constructor which constructs this type from a `TargetIdWithApid` and the unique ID ( `u32`)
muellerr marked this conversation as resolved
@ -9,0 +69,4 @@
}
}
// #[derive(Copy, Clone, PartialEq, Eq, Debug, Hash, new)]
Owner

This can be deleted when everything works

This can be deleted when everything works
muellerr marked this conversation as resolved
@ -0,0 +16,4 @@
})
.level(log::LevelFilter::Debug)
.chain(std::io::stdout())
.chain(fern::log_file("output.log")?)
Owner

is it possible to enable file output if a certain env variable is set?

is it possible to enable file output if a certain env variable is set?
muellerr marked this conversation as resolved
muellerr added this to the satrs v0.1.0 milestone 2023-08-28 16:55:43 +02:00
muellerr added 1 commit 2023-08-29 10:22:51 +02:00
Merge remote-tracking branch 'origin/main' into TargetIdWithApid
All checks were successful
Rust/sat-rs/pipeline/pr-main This commit looks good
f8df716865
muellerr added 1 commit 2023-09-07 17:33:05 +02:00
Merge branch 'main' into TargetIdWithApid
All checks were successful
Rust/sat-rs/pipeline/pr-main This commit looks good
a8b4519748
lkoester added 1 commit 2023-09-16 16:15:27 +02:00
Merge branch 'main' into TargetIdWithApid
All checks were successful
Rust/sat-rs/pipeline/pr-main This commit looks good
c01c6d1504
muellerr added 1 commit 2023-09-26 16:00:18 +02:00
Merge branch 'main' into TargetIdWithApid
Some checks failed
Rust/sat-rs/pipeline/pr-main There was a failure building this commit
92ac91e194
muellerr added 1 commit 2024-01-29 23:38:25 +01:00
Merge remote-tracking branch 'origin/main' into TargetIdWithApid
Some checks failed
Rust/sat-rs/pipeline/pr-main There was a failure building this commit
aade7c51f2
muellerr added 1 commit 2024-01-30 23:31:51 +01:00
Merge branch 'main' into TargetIdWithApid
Some checks failed
Rust/sat-rs/pipeline/pr-main There was a failure building this commit
21edd1dcff
muellerr added 1 commit 2024-01-30 23:48:42 +01:00
all clippy fixes
All checks were successful
Rust/sat-rs/pipeline/pr-main This commit looks good
b27842c2bb
muellerr added 1 commit 2024-01-30 23:59:22 +01:00
done
All checks were successful
Rust/sat-rs/pipeline/pr-main This commit looks good
b79b5d2009
muellerr added 1 commit 2024-01-31 00:00:53 +01:00
these 2 deps are not required
All checks were successful
Rust/sat-rs/pipeline/pr-main This commit looks good
21961daba4
muellerr added 1 commit 2024-01-31 00:02:24 +01:00
ignore log file
All checks were successful
Rust/sat-rs/pipeline/pr-main This commit looks good
93fb38a9b7
muellerr approved these changes 2024-01-31 00:02:50 +01:00
muellerr merged commit a09af65396 into main 2024-01-31 11:06:34 +01:00
muellerr deleted branch TargetIdWithApid 2024-01-31 11:06:35 +01:00
Sign in to join this conversation.
No description provided.