Clonable Verification Reporter #24
muellerr
commented 2022-11-21 10:42:40 +01:00
Owner
- This update allows cloning the verification reporter, which can avoid the need of a lock across all verification reporters. The sequence count is one of the properties which might need to be synced across different threads, so a generic abstraction was used, where users can chose a synced implementation where applicable. This is basically a memory vs. lock required trade-off.
- There is the special case left where users might want to also set the APID and destination ID to different values, but I am just going to assume that requirement to be mission specific. It probably also makes a lot of sense to simply map APIDs to threads, so each thread received a reporter with the correct APID and destination IDs already set and no need to ever set the APID to another value.
- This update allows cloning the verification reporter, which can avoid the need of a lock across all verification reporters. The sequence count is one of the properties which might need to be synced across different threads, so a generic abstraction was used, where users can chose a synced implementation where applicable. This is basically a memory vs. lock required trade-off.
- There is the special case left where users might want to also set the APID and destination ID to different values, but I am just going to assume that requirement to be mission specific. It probably also makes a lot of sense to simply map APIDs to threads, so each thread received a reporter with the correct APID and destination IDs already set and no need to ever set the APID to another value.
muellerr
added 3 commits 2022-11-21 10:42:42 +01:00
trying to avoid locking whole verification reporter
43a1fb90ce
lock not required anymore
607d53942a
some docs and corrections
6b93a9fce1
muellerr
added 1 commit 2022-11-21 10:56:48 +01:00
overflow handling
e06cadd088
muellerr
merged commit b8efa8e518 into main 2022-11-21 15:02:02 +01:00
muellerr
referenced this issue from a commit 2022-11-21 15:02:02 +01:00
Merge pull request 'Clonable Verification Reporter' (#24) from clonable_verification_structs into main
muellerr
deleted branch clonable_verification_structs 2022-11-21 15:02:03 +01:00
muellerr
added this to the satrs v0.1.0 milestone 2022-12-03 13:47:20 +01:00
No reviewers
Labels
No Label
api
b-api
bug
concepts
duplicate
enhancement
help wanted
invalid
question
wontfix
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: rust/sat-rs#24
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "clonable_verification_structs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?