this check is sufficient
EIVE/eive-obsw/pipeline/pr-develop This commit looks good Details

This commit is contained in:
Robin Müller 2022-08-16 18:13:54 +02:00
parent 800cabb8a1
commit 5c32114bdb
No known key found for this signature in database
GPG Key ID: 71B58F8A3CDFA9AC
1 changed files with 1 additions and 1 deletions

View File

@ -1080,7 +1080,7 @@ class WriteMemory : public ploc::SpTcBase {
ReturnValue_t buildPacket(ccsds::SequenceFlags seqFlags, uint16_t sequenceCount, uint8_t memoryId,
uint32_t startAddress, uint16_t length, uint8_t* updateData) {
if (length > CHUNK_MAX + 1) {
if (length > CHUNK_MAX) {
sif::error << "WriteMemory::WriteMemory: Invalid length" << std::endl;
return SerializeIF::BUFFER_TOO_SHORT;
}