done

bsp_hosted/fsfwconfig/events/translateEvents.cpp

@@ -212,7 +212,8 @@ const char *SIDE_SWITCH_TRANSITION_NOT_ALLOWED_STRING = "SIDE_SWITCH_TRANSITION_
 const char *TRANSITION_OTHER_SIDE_FAILED_12900_STRING = "TRANSITION_OTHER_SIDE_FAILED_12900";
 const char *NOT_ENOUGH_DEVICES_DUAL_MODE_12901_STRING = "NOT_ENOUGH_DEVICES_DUAL_MODE_12901";
 const char *POWER_STATE_MACHINE_TIMEOUT_12902_STRING = "POWER_STATE_MACHINE_TIMEOUT_12902";
-const char *SIDE_SWITCH_TRANSITION_NOT_ALLOWED_12903_STRING = "SIDE_SWITCH_TRANSITION_NOT_ALLOWED_12903";
+const char *SIDE_SWITCH_TRANSITION_NOT_ALLOWED_12903_STRING =
+    "SIDE_SWITCH_TRANSITION_NOT_ALLOWED_12903";
 const char *CHILDREN_LOST_MODE_STRING = "CHILDREN_LOST_MODE";
 const char *GPS_FIX_CHANGE_STRING = "GPS_FIX_CHANGE";
 const char *CANT_GET_FIX_STRING = "CANT_GET_FIX";

bsp_q7s/callbacks/rwSpiCallback.cpp

@@ -6,7 +6,7 @@
 #include "fsfw/serviceinterface/ServiceInterface.h"
 #include "fsfw_hal/linux/UnixFileGuard.h"
 #include "fsfw_hal/linux/spi/SpiCookie.h"
-#include "mission/devices/RwHandler.h"
+#include "mission/acs/RwHandler.h"
 
 namespace rwSpiCallback {
 

bsp_q7s/core/ObjectFactory.cpp

@@ -1,17 +1,17 @@
 #include "ObjectFactory.h"
 
 #include <fsfw/subsystem/Subsystem.h>
+#include <linux/com/SyrlinksComHandler.h>
 #include <linux/devices/AcsBoardPolling.h>
 #include <linux/devices/ImtqPollingTask.h>
 #include <linux/devices/RwPollingTask.h>
-#include <linux/com/SyrlinksComHandler.h>
 #include <linux/devices/startracker/StrComHandler.h>
-#include <mission/devices/GyrL3gCustomHandler.h>
-#include <mission/devices/MgmLis3CustomHandler.h>
-#include <mission/devices/MgmRm3100CustomHandler.h>
+#include <mission/acs/GyrL3gCustomHandler.h>
+#include <mission/acs/MgmLis3CustomHandler.h>
+#include <mission/acs/MgmRm3100CustomHandler.h>
+#include <mission/system/acs/ImtqAssembly.h>
 #include <mission/system/fdir/StrFdir.h>
 #include <mission/system/objects/CamSwitcher.h>
-#include <mission/system/objects/ImtqAssembly.h>
 #include <mission/system/objects/StrAssembly.h>
 #include <mission/system/objects/SyrlinksAssembly.h>
 #include <mission/tmtc/LiveTmTask.h>
@@ -52,18 +52,18 @@
 #include "linux/ipcore/PdecHandler.h"
 #include "linux/ipcore/Ptme.h"
 #include "linux/ipcore/PtmeConfig.h"
-#include "mission/com/SyrlinksFdir.h"
-#include "mission/com/comModeTree.h"
 #include "mission/config/configfile.h"
 #include "mission/csp/CspCookie.h"
-#include "mission/system/fdir/AcsBoardFdir.h"
+#include "mission/system/acs/AcsBoardFdir.h"
+#include "mission/system/acs/AcsSubsystem.h"
+#include "mission/system/acs/RwAssembly.h"
+#include "mission/system/acs/SusFdir.h"
+#include "mission/system/acs/acsModeTree.h"
+#include "mission/system/com/SyrlinksFdir.h"
+#include "mission/system/com/comModeTree.h"
 #include "mission/system/fdir/GomspacePowerFdir.h"
 #include "mission/system/fdir/RtdFdir.h"
-#include "mission/system/fdir/SusFdir.h"
-#include "mission/system/objects/AcsSubsystem.h"
-#include "mission/system/objects/RwAssembly.h"
 #include "mission/system/objects/TcsBoardAssembly.h"
-#include "mission/system/tree/acsModeTree.h"
 #include "mission/system/tree/payloadModeTree.h"
 #include "mission/system/tree/tcsModeTree.h"
 #include "mission/tmtc/tmFilters.h"
@@ -75,13 +75,13 @@ using gpio::Levels;
 #if OBSW_TEST_LIBGPIOD == 1
 #include "linux/boardtest/LibgpiodTest.h"
 #endif
+#include <mission/acs/GyrAdis1650XHandler.h>
+#include <mission/acs/ImtqHandler.h>
+#include <mission/acs/rwHelpers.h>
 #include <mission/com/SyrlinksHandler.h>
-#include <mission/devices/GyrAdis1650XHandler.h>
-#include <mission/devices/ImtqHandler.h>
 #include <mission/devices/PcduHandler.h>
 #include <mission/devices/Pdu1Handler.h>
 #include <mission/devices/Pdu2Handler.h>
-#include <mission/devices/devicedefinitions/rwHelpers.h>
 #include <mission/tmtc/VirtualChannelWithQueue.h>
 
 #include <sstream>
@@ -102,6 +102,7 @@ using gpio::Levels;
 #include "fsfw_hal/linux/serial/SerialCookie.h"
 #include "fsfw_hal/linux/spi/SpiComIF.h"
 #include "fsfw_hal/linux/spi/SpiCookie.h"
+#include "mission/acs/RwHandler.h"
 #include "mission/com/CcsdsIpCoreHandler.h"
 #include "mission/com/syrlinksDefs.h"
 #include "mission/core/GenericFactory.h"
@@ -112,14 +113,13 @@ using gpio::Levels;
 #include "mission/devices/P60DockHandler.h"
 #include "mission/devices/PayloadPcduHandler.h"
 #include "mission/devices/RadiationSensorHandler.h"
-#include "mission/devices/RwHandler.h"
 #include "mission/devices/SolarArrayDeploymentHandler.h"
 #include "mission/devices/Tmp1075Handler.h"
 #include "mission/devices/devicedefinitions/GomspaceDefinitions.h"
 #include "mission/devices/devicedefinitions/Max31865Definitions.h"
 #include "mission/devices/devicedefinitions/RadSensorDefinitions.h"
 #include "mission/devices/devicedefinitions/payloadPcduDefinitions.h"
-#include "mission/system/objects/AcsBoardAssembly.h"
+#include "mission/system/acs/AcsBoardAssembly.h"
 #include "mission/tmtc/TmFunnelHandler.h"
 
 ResetArgs RESET_ARGS_GNSS;

bsp_q7s/obsw.cpp

@@ -14,7 +14,7 @@
 #include "core/scheduling.h"
 #include "fsfw/tasks/TaskFactory.h"
 #include "fsfw/version.h"
-#include "mission/acsDefs.h"
+#include "mission/acs/defs.h"
 #include "mission/com/defs.h"
 #include "mission/system/tree/system.h"
 #include "q7sConfig.h"

dummies/GyroAdisDummy.cpp

@@ -1,6 +1,6 @@
 #include "GyroAdisDummy.h"
 
-#include <mission/devices/devicedefinitions/gyroAdisHelpers.h>
+#include <mission/acs/gyroAdisHelpers.h>
 
 GyroAdisDummy::GyroAdisDummy(object_id_t objectId, object_id_t comif, CookieIF *comCookie)
     : DeviceHandlerBase(objectId, comif, comCookie), dataset(this) {}

dummies/GyroAdisDummy.h

@@ -2,7 +2,7 @@
 #define DUMMIES_GYROADISDUMMY_H_
 
 #include <fsfw/devicehandlers/DeviceHandlerBase.h>
-#include <mission/devices/devicedefinitions/gyroAdisHelpers.h>
+#include <mission/acs/gyroAdisHelpers.h>
 
 class GyroAdisDummy : public DeviceHandlerBase {
  public:

dummies/ImtqDummy.cpp

@@ -1,6 +1,6 @@
 #include "ImtqDummy.h"
 
-#include <mission/devices/devicedefinitions/imtqHelpers.h>
+#include <mission/acs/imtqHelpers.h>
 
 ImtqDummy::ImtqDummy(object_id_t objectId, object_id_t comif, CookieIF *comCookie)
     : DeviceHandlerBase(objectId, comif, comCookie) {}

dummies/RwDummy.cpp

@@ -1,6 +1,6 @@
 #include "RwDummy.h"
 
-#include <mission/devices/devicedefinitions/rwHelpers.h>
+#include <mission/acs/rwHelpers.h>
 
 RwDummy::RwDummy(object_id_t objectId, object_id_t comif, CookieIF *comCookie)
     : DeviceHandlerBase(objectId, comif, comCookie) {}

dummies/helpers.cpp

@@ -25,18 +25,18 @@
 #include <dummies/SusDummy.h>
 #include <dummies/SyrlinksDummy.h>
 #include <fsfw_hal/common/gpio/GpioIF.h>
+#include <mission/system/acs/ImtqAssembly.h>
 #include <mission/system/objects/CamSwitcher.h>
-#include <mission/system/objects/ImtqAssembly.h>
 #include <mission/system/objects/StrAssembly.h>
 #include <mission/system/objects/TcsBoardAssembly.h>
 
 #include "TemperatureSensorInserter.h"
 #include "dummies/Max31865Dummy.h"
 #include "dummies/Tmp1075Dummy.h"
-#include "mission/com/comModeTree.h"
 #include "mission/core/GenericFactory.h"
 #include "mission/devices/devicedefinitions/GomspaceDefinitions.h"
-#include "mission/system/tree/acsModeTree.h"
+#include "mission/system/acs/acsModeTree.h"
+#include "mission/system/com/comModeTree.h"
 #include "mission/system/tree/payloadModeTree.h"
 #include "mission/system/tree/tcsModeTree.h"
 

linux/ObjectFactory.cpp

@@ -11,15 +11,14 @@
 #include <linux/callbacks/gpioCallbacks.h>
 #include <linux/devices/Max31865RtdPolling.h>
 #include <linux/devices/SusPolling.h>
+#include <mission/acs/SusHandler.h>
 #include <mission/controller/AcsController.h>
 #include <mission/core/GenericFactory.h>
-#include <mission/devices/LegacySusHandler.h>
 #include <mission/devices/Max31865EiveHandler.h>
 #include <mission/devices/ScexDeviceHandler.h>
-#include <mission/devices/SusHandler.h>
+#include <mission/system/acs/SusAssembly.h>
+#include <mission/system/acs/SusFdir.h>
 #include <mission/system/fdir/RtdFdir.h>
-#include <mission/system/fdir/SusFdir.h>
-#include <mission/system/objects/SusAssembly.h>
 #include <mission/system/objects/TcsBoardAssembly.h>
 
 #include "OBSWConfig.h"
@@ -27,7 +26,7 @@
 #include "devices/addresses.h"
 #include "devices/gpioIds.h"
 #include "eive/definitions.h"
-#include "mission/system/tree/acsModeTree.h"
+#include "mission/system/acs/acsModeTree.h"
 #include "mission/system/tree/payloadModeTree.h"
 #include "mission/system/tree/tcsModeTree.h"
 

linux/devices/AcsBoardPolling.cpp

@@ -10,7 +10,7 @@
 #include <fsfw_hal/linux/UnixFileGuard.h>
 #include <fsfw_hal/linux/spi/SpiCookie.h>
 #include <fsfw_hal/linux/utility.h>
-#include <mission/devices/devicedefinitions/gyroAdisHelpers.h>
+#include <mission/acs/gyroAdisHelpers.h>
 #include <sys/ioctl.h>
 
 #include "devices/gpioIds.h"

linux/devices/AcsBoardPolling.h

@@ -7,8 +7,8 @@
 #include <fsfw/tasks/SemaphoreIF.h>
 #include <fsfw_hal/devicehandlers/devicedefinitions/mgmRm3100Helpers.h>
 #include <fsfw_hal/linux/spi/SpiComIF.h>
-#include <mission/devices/devicedefinitions/acsPolling.h>
-#include <mission/devices/devicedefinitions/gyroAdisHelpers.h>
+#include <mission/acs/acsBoardPolling.h>
+#include <mission/acs/gyroAdisHelpers.h>
 
 class AcsBoardPolling : public SystemObject,
                         public ExecutableObjectIF,

linux/devices/ImtqPollingTask.h

@@ -9,7 +9,7 @@
 #include "fsfw/devicehandlers/DeviceCommunicationIF.h"
 #include "fsfw/objectmanager/SystemObject.h"
 #include "fsfw/tasks/ExecutableObjectIF.h"
-#include "mission/devices/devicedefinitions/imtqHelpers.h"
+#include "mission/acs/imtqHelpers.h"
 
 class ImtqPollingTask : public SystemObject,
                         public ExecutableObjectIF,

linux/devices/RwPollingTask.cpp

@@ -11,7 +11,7 @@
 #include <unistd.h>
 
 #include "devConf.h"
-#include "mission/devices/devicedefinitions/rwHelpers.h"
+#include "mission/acs/rwHelpers.h"
 
 RwPollingTask::RwPollingTask(object_id_t objectId, const char* spiDev, GpioIF& gpioIF)
     : SystemObject(objectId), spiDev(spiDev), gpioIF(gpioIF) {

linux/devices/RwPollingTask.h

@@ -9,7 +9,7 @@
 #include <fsfw_hal/linux/spi/SpiComIF.h>
 #include <fsfw_hal/linux/spi/SpiCookie.h>
 
-#include "mission/devices/devicedefinitions/rwHelpers.h"
+#include "mission/acs/rwHelpers.h"
 
 class RwCookie : public SpiCookie {
   friend class RwPollingTask;

linux/devices/SusPolling.h

@@ -8,7 +8,7 @@
 #include <fsfw_hal/linux/spi/SpiComIF.h>
 
 #include "devices/addresses.h"
-#include "mission/devices/devicedefinitions/acsPolling.h"
+#include "mission/acs/acsBoardPolling.h"
 
 class SusPolling : public SystemObject, public ExecutableObjectIF, public DeviceCommunicationIF {
  public:

linux/fsfwconfig/events/translateEvents.cpp

@@ -212,7 +212,8 @@ const char *SIDE_SWITCH_TRANSITION_NOT_ALLOWED_STRING = "SIDE_SWITCH_TRANSITION_
 const char *TRANSITION_OTHER_SIDE_FAILED_12900_STRING = "TRANSITION_OTHER_SIDE_FAILED_12900";
 const char *NOT_ENOUGH_DEVICES_DUAL_MODE_12901_STRING = "NOT_ENOUGH_DEVICES_DUAL_MODE_12901";
 const char *POWER_STATE_MACHINE_TIMEOUT_12902_STRING = "POWER_STATE_MACHINE_TIMEOUT_12902";
-const char *SIDE_SWITCH_TRANSITION_NOT_ALLOWED_12903_STRING = "SIDE_SWITCH_TRANSITION_NOT_ALLOWED_12903";
+const char *SIDE_SWITCH_TRANSITION_NOT_ALLOWED_12903_STRING =
+    "SIDE_SWITCH_TRANSITION_NOT_ALLOWED_12903";
 const char *CHILDREN_LOST_MODE_STRING = "CHILDREN_LOST_MODE";
 const char *GPS_FIX_CHANGE_STRING = "GPS_FIX_CHANGE";
 const char *CANT_GET_FIX_STRING = "CANT_GET_FIX";

mission/CMakeLists.txt

@@ -11,5 +11,4 @@ add_subdirectory(csp)
 add_subdirectory(cfdp)
 add_subdirectory(config)
 
-target_sources(${LIB_EIVE_MISSION} PRIVATE acsDefs.cpp payloadDefs.cpp
-                                           trace.cpp)
+target_sources(${LIB_EIVE_MISSION} PRIVATE payloadDefs.cpp trace.cpp)

mission/acs/CMakeLists.txt

@@ -0,0 +1,13 @@
+target_sources(
+  ${LIB_EIVE_MISSION}
+  PRIVATE GyrAdis1650XHandler.cpp
+          GyrL3gCustomHandler.cpp
+          ImtqHandler.cpp
+          MgmLis3CustomHandler.cpp
+          MgmRm3100CustomHandler.cpp
+          RwHandler.cpp
+          SusHandler.cpp
+          gyroAdisHelpers.cpp
+          imtqHelpers.cpp
+          rwHelpers.cpp
+          defs.cpp)

mission/acs/GyrAdis1650XHandler.cpp

@@ -1,8 +1,8 @@
-#include "mission/devices/GyrAdis1650XHandler.h"
+#include "GyrAdis1650XHandler.h"
 
 #include "fsfw/action/HasActionsIF.h"
 #include "fsfw/datapool/PoolReadGuard.h"
-#include "mission/devices/devicedefinitions/acsPolling.h"
+#include "mission/acs/acsBoardPolling.h"
 
 GyrAdis1650XHandler::GyrAdis1650XHandler(object_id_t objectId, object_id_t deviceCommunication,
                                          CookieIF *comCookie, adis1650x::Type type)

mission/acs/GyrAdis1650XHandler.h

@@ -1,8 +1,8 @@
 #ifndef MISSION_DEVICES_GYROADIS16507HANDLER_H_
 #define MISSION_DEVICES_GYROADIS16507HANDLER_H_
 
-#include <mission/devices/devicedefinitions/acsPolling.h>
-#include <mission/devices/devicedefinitions/gyroAdisHelpers.h>
+#include <mission/acs/acsBoardPolling.h>
+#include <mission/acs/gyroAdisHelpers.h>
 
 #include "FSFWConfig.h"
 #include "OBSWConfig.h"

mission/acs/GyrL3gCustomHandler.cpp

@@ -1,10 +1,10 @@
 
-#include <mission/devices/GyrL3gCustomHandler.h>
+#include <mission/acs/GyrL3gCustomHandler.h>
+#include <mission/acs/acsBoardPolling.h>
 
 #include <cmath>
 
 #include "fsfw/datapool/PoolReadGuard.h"
-#include "mission/devices/devicedefinitions/acsPolling.h"
 
 GyrL3gCustomHandler::GyrL3gCustomHandler(object_id_t objectId, object_id_t deviceCommunication,
                                          CookieIF *comCookie, uint32_t transitionDelayMs)

mission/acs/GyrL3gCustomHandler.h

@@ -4,7 +4,7 @@
 #include <fsfw/devicehandlers/DeviceHandlerBase.h>
 #include <fsfw/globalfunctions/PeriodicOperationDivider.h>
 #include <fsfw_hal/devicehandlers/devicedefinitions/gyroL3gHelpers.h>
-#include <mission/devices/devicedefinitions/acsPolling.h>
+#include <mission/acs/acsBoardPolling.h>
 
 /**
  * @brief 	Device Handler for the L3GD20H gyroscope sensor

mission/acs/ImtqHandler.cpp

@@ -20,7 +20,7 @@
 #include <fsfw/tasks/TaskFactory.h>
 #include <fsfw/timemanager/Countdown.h>
 #include <fsfw/timemanager/clockDefinitions.h>
-#include <mission/devices/ImtqHandler.h>
+#include <mission/acs/ImtqHandler.h>
 
 #include <cmath>
 #include <fsfw/datapoollocal/LocalPoolVariable.tpp>

mission/acs/ImtqHandler.h

@@ -2,7 +2,7 @@
 #define MISSION_DEVICES_IMTQHANDLER_H_
 
 #include <fsfw/devicehandlers/DeviceHandlerBase.h>
-#include <mission/devices/devicedefinitions/imtqHelpers.h>
+#include <mission/acs/imtqHelpers.h>
 #include <string.h>
 
 #include "events/subsystemIdRanges.h"

mission/acs/MgmLis3CustomHandler.cpp

@@ -1,4 +1,4 @@
-#include <mission/devices/MgmLis3CustomHandler.h>
+#include "MgmLis3CustomHandler.h"
 
 #include <cmath>
 

mission/acs/MgmLis3CustomHandler.h

@@ -5,7 +5,7 @@
 
 #include "fsfw/devicehandlers/DeviceHandlerBase.h"
 #include "fsfw/globalfunctions/PeriodicOperationDivider.h"
-#include "mission/devices/devicedefinitions/acsPolling.h"
+#include "mission/acs/acsBoardPolling.h"
 
 class PeriodicOperationDivider;
 

mission/acs/MgmRm3100CustomHandler.cpp

@@ -1,4 +1,4 @@
-#include <mission/devices/MgmRm3100CustomHandler.h>
+#include "MgmRm3100CustomHandler.h"
 
 #include "fsfw/datapool/PoolReadGuard.h"
 #include "fsfw/devicehandlers/DeviceHandlerMessage.h"

mission/acs/MgmRm3100CustomHandler.h

@@ -5,7 +5,7 @@
 
 #include "fsfw/devicehandlers/DeviceHandlerBase.h"
 #include "fsfw/globalfunctions/PeriodicOperationDivider.h"
-#include "mission/devices/devicedefinitions/acsPolling.h"
+#include "mission/acs/acsBoardPolling.h"
 
 /**
  * @brief 	Device Handler for the RM3100 geomagnetic magnetometer sensor

mission/acs/RwHandler.h

@@ -3,7 +3,7 @@
 
 #include <fsfw/devicehandlers/DeviceHandlerBase.h>
 #include <fsfw_hal/common/gpio/gpioDefinitions.h>
-#include <mission/devices/devicedefinitions/rwHelpers.h>
+#include <mission/acs/rwHelpers.h>
 #include <string.h>
 
 #include "events/subsystemIdRanges.h"

mission/acs/SusHandler.h

@@ -6,7 +6,7 @@
 
 #include "fsfw/devicehandlers/DeviceHandlerBase.h"
 #include "fsfw/globalfunctions/PeriodicOperationDivider.h"
-#include "mission/devices/devicedefinitions/acsPolling.h"
+#include "mission/acs/acsBoardPolling.h"
 #include "mission/devices/devicedefinitions/susMax1227Helpers.h"
 
 class SusHandler : public DeviceHandlerBase {

mission/acs/defs.cpp

@@ -1,4 +1,4 @@
-#include "acsDefs.h"
+#include "defs.h"
 
 const char* acs::getModeStr(AcsMode mode) {
   static const char* modeStr = "UNKNOWN";

mission/com/CMakeLists.txt

@@ -1,4 +1,2 @@
-target_sources(
-  ${LIB_EIVE_MISSION}
-  PRIVATE SyrlinksHandler.cpp ComSubsystem.cpp SyrlinksFdir.cpp comModeTree.cpp
-          CcsdsIpCoreHandler.cpp SyrlinksAssembly.cpp)
+target_sources(${LIB_EIVE_MISSION} PRIVATE SyrlinksHandler.cpp
+                                           CcsdsIpCoreHandler.cpp)

mission/controller/AcsController.cpp

@@ -1,7 +1,7 @@
 #include "AcsController.h"
 
 #include <fsfw/datapool/PoolReadGuard.h>
-#include <mission/acsDefs.h>
+#include <mission/acs/defs.h>
 #include <mission/config/torquer.h>
 
 AcsController::AcsController(object_id_t objectId)

mission/controller/AcsController.h

@@ -9,8 +9,8 @@
 #include <fsfw/parameters/ReceivesParameterMessagesIF.h>
 #include <fsfw_hal/devicehandlers/MgmLIS3MDLHandler.h>
 #include <fsfw_hal/devicehandlers/MgmRM3100Handler.h>
-#include <mission/devices/devicedefinitions/imtqHelpers.h>
-#include <mission/devices/devicedefinitions/rwHelpers.h>
+#include <mission/acs/imtqHelpers.h>
+#include <mission/acs/rwHelpers.h>
 #include <mission/devices/devicedefinitions/susMax1227Helpers.h>
 #include <mission/trace.h>
 

mission/controller/ThermalController.cpp

@@ -3,16 +3,16 @@
 #include <bsp_q7s/core/CoreDefinitions.h>
 #include <fsfw/datapool/PoolReadGuard.h>
 #include <fsfw/thermal/ThermalComponentIF.h>
+#include <fsfw_hal/devicehandlers/devicedefinitions/gyroL3gHelpers.h>
 #include <fsfw_hal/devicehandlers/devicedefinitions/mgmLis3Helpers.h>
 #include <linux/devices/devicedefinitions/StarTrackerDefinitions.h>
+#include <mission/acs/gyroAdisHelpers.h>
+#include <mission/acs/imtqHelpers.h>
+#include <mission/acs/rwHelpers.h>
 #include <mission/com/syrlinksDefs.h>
 #include <mission/devices/devicedefinitions/BpxBatteryDefinitions.h>
 #include <mission/devices/devicedefinitions/GomspaceDefinitions.h>
-#include <mission/devices/devicedefinitions/GyroL3GD20Definitions.h>
-#include <mission/devices/devicedefinitions/gyroAdisHelpers.h>
-#include <mission/devices/devicedefinitions/imtqHelpers.h>
 #include <mission/devices/devicedefinitions/payloadPcduDefinitions.h>
-#include <mission/devices/devicedefinitions/rwHelpers.h>
 #include <objects/systemObjectList.h>
 
 ThermalController::ThermalController(object_id_t objectId, HeaterHandler& heater)

mission/controller/ThermalController.h

@@ -8,15 +8,15 @@
 #include <fsfw_hal/devicehandlers/devicedefinitions/gyroL3gHelpers.h>
 #include <fsfw_hal/devicehandlers/devicedefinitions/mgmLis3Helpers.h>
 #include <linux/devices/devicedefinitions/StarTrackerDefinitions.h>
+#include <mission/acs/gyroAdisHelpers.h>
+#include <mission/acs/imtqHelpers.h>
+#include <mission/acs/rwHelpers.h>
 #include <mission/com/syrlinksDefs.h>
 #include <mission/controller/controllerdefinitions/ThermalControllerDefinitions.h>
 #include <mission/devices/devicedefinitions/BpxBatteryDefinitions.h>
 #include <mission/devices/devicedefinitions/Max31865Definitions.h>
 #include <mission/devices/devicedefinitions/Tmp1075Definitions.h>
-#include <mission/devices/devicedefinitions/gyroAdisHelpers.h>
-#include <mission/devices/devicedefinitions/imtqHelpers.h>
 #include <mission/devices/devicedefinitions/payloadPcduDefinitions.h>
-#include <mission/devices/devicedefinitions/rwHelpers.h>
 #include <mission/devices/devicedefinitions/susMax1227Helpers.h>
 
 #include <list>

mission/controller/acs/SensorValues.h

@@ -3,12 +3,12 @@
 
 #include <fsfw_hal/devicehandlers/MgmLIS3MDLHandler.h>
 #include <fsfw_hal/devicehandlers/MgmRM3100Handler.h>
+#include <fsfw_hal/devicehandlers/devicedefinitions/gyroL3gHelpers.h>
 #include <linux/devices/devicedefinitions/StarTrackerDefinitions.h>
+#include <mission/acs/gyroAdisHelpers.h>
+#include <mission/acs/imtqHelpers.h>
+#include <mission/acs/rwHelpers.h>
 #include <mission/devices/devicedefinitions/GPSDefinitions.h>
-#include <mission/devices/devicedefinitions/GyroL3GD20Definitions.h>
-#include <mission/devices/devicedefinitions/gyroAdisHelpers.h>
-#include <mission/devices/devicedefinitions/imtqHelpers.h>
-#include <mission/devices/devicedefinitions/rwHelpers.h>
 #include <mission/devices/devicedefinitions/susMax1227Helpers.h>
 
 namespace ACS {

mission/core/GenericFactory.cpp

@@ -29,9 +29,9 @@
 #include <mission/devices/HeaterHandler.h>
 #include <mission/devices/devicedefinitions/GomspaceDefinitions.h>
 #include <mission/persistentTmStoreDefs.h>
-#include <mission/system/objects/AcsBoardAssembly.h>
-#include <mission/system/objects/RwAssembly.h>
-#include <mission/system/objects/SusAssembly.h>
+#include <mission/system/acs/AcsBoardAssembly.h>
+#include <mission/system/acs/RwAssembly.h>
+#include <mission/system/acs/SusAssembly.h>
 #include <mission/system/objects/TcsBoardAssembly.h>
 #include <mission/tmtc/CfdpTmFunnel.h>
 #include <mission/tmtc/PersistentTmStore.h>
@@ -46,8 +46,8 @@
 #include "eive/definitions.h"
 #include "fsfw/pus/Service11TelecommandScheduling.h"
 #include "mission/cfdp/Config.h"
-#include "mission/system/objects/RwAssembly.h"
-#include "mission/system/tree/acsModeTree.h"
+#include "mission/system/acs/RwAssembly.h"
+#include "mission/system/acs/acsModeTree.h"
 #include "mission/system/tree/tcsModeTree.h"
 #include "mission/tmtc/tmFilters.h"
 #include "objects/systemObjectList.h"

mission/core/pollingSeqTables.cpp

@@ -4,7 +4,7 @@
 #include <fsfw/objectmanager/ObjectManagerIF.h>
 #include <fsfw/serviceinterface/ServiceInterfaceStream.h>
 #include <fsfw/tasks/FixedTimeslotTaskIF.h>
-#include <mission/devices/devicedefinitions/imtqHelpers.h>
+#include <mission/acs/imtqHelpers.h>
 
 #include "OBSWConfig.h"
 #include "eive/definitions.h"

mission/devices/CMakeLists.txt

@@ -8,18 +8,10 @@ target_sources(
           Pdu1Handler.cpp
           Pdu2Handler.cpp
           ACUHandler.cpp
-          Max31865PT1000Handler.cpp
           Max31865EiveHandler.cpp
-          ImtqHandler.cpp
           HeaterHandler.cpp
           RadiationSensorHandler.cpp
-          GyrAdis1650XHandler.cpp
-          GyrL3gCustomHandler.cpp
-          MgmRm3100CustomHandler.cpp
-          MgmLis3CustomHandler.cpp
-          RwHandler.cpp
           max1227.cpp
-          SusHandler.cpp
           PayloadPcduHandler.cpp
           SolarArrayDeploymentHandler.cpp
           ScexDeviceHandler.cpp)

mission/devices/PayloadPcduHandler.h

@@ -11,8 +11,8 @@
 #include "fsfw_hal/common/gpio/GpioIF.h"
 #include "mission/devices/devicedefinitions/payloadPcduDefinitions.h"
 #include "mission/memory/SdCardMountedIF.h"
-#include "mission/system/objects/DualLanePowerStateMachine.h"
-#include "mission/system/objects/definitions.h"
+#include "mission/powerDefs.h"
+#include "mission/system/DualLanePowerStateMachine.h"
 
 #ifdef FSFW_OSAL_LINUX
 class SpiComIF;

mission/devices/devicedefinitions/CMakeLists.txt

@@ -1,2 +1 @@
-target_sources(${LIB_EIVE_MISSION} PRIVATE ScexDefinitions.cpp rwHelpers.cpp
-                                           imtqHelpers.cpp gyroAdisHelpers.cpp)
+target_sources(${LIB_EIVE_MISSION} PRIVATE ScexDefinitions.cpp)

mission/devices/devicedefinitions/GyroL3GD20Definitions.h

@@ -1,130 +0,0 @@
-#ifndef MISSION_DEVICES_DEVICEDEFINITIONS_GYROL3GD20DEFINITIONS_H_
-#define MISSION_DEVICES_DEVICEDEFINITIONS_GYROL3GD20DEFINITIONS_H_
-
-#include <fsfw/datapoollocal/StaticLocalDataSet.h>
-#include <fsfw/devicehandlers/DeviceHandlerIF.h>
-
-#include <cstdint>
-
-namespace l3gd20h {
-
-/* Actual size is 15 but we round up a bit */
-static constexpr size_t MAX_BUFFER_SIZE = 16;
-
-static constexpr uint8_t READ_MASK = 0b1000'0000;
-
-static constexpr uint8_t AUTO_INCREMENT_MASK = 0b0100'0000;
-
-static constexpr uint8_t WHO_AM_I_REG = 0b0000'1111;
-static constexpr uint8_t WHO_AM_I_VAL = 0b1101'0111;
-
-/*------------------------------------------------------------------------*/
-/* Control registers */
-/*------------------------------------------------------------------------*/
-static constexpr uint8_t CTRL_REG_1 = 0b0010'0000;
-static constexpr uint8_t CTRL_REG_2 = 0b0010'0001;
-static constexpr uint8_t CTRL_REG_3 = 0b0010'0010;
-static constexpr uint8_t CTRL_REG_4 = 0b0010'0011;
-static constexpr uint8_t CTRL_REG_5 = 0b0010'0100;
-
-/* Register 1 */
-static constexpr uint8_t SET_DR_1 = 1 << 7;
-static constexpr uint8_t SET_DR_0 = 1 << 6;
-static constexpr uint8_t SET_BW_1 = 1 << 5;
-static constexpr uint8_t SET_BW_0 = 1 << 4;
-static constexpr uint8_t SET_POWER_NORMAL_MODE = 1 << 3;
-static constexpr uint8_t SET_Z_ENABLE = 1 << 2;
-static constexpr uint8_t SET_X_ENABLE = 1 << 1;
-static constexpr uint8_t SET_Y_ENABLE = 1;
-
-static constexpr uint8_t CTRL_REG_1_VAL =
-    SET_POWER_NORMAL_MODE | SET_Z_ENABLE | SET_Y_ENABLE | SET_X_ENABLE;
-
-/* Register 2 */
-static constexpr uint8_t EXTERNAL_EDGE_ENB = 1 << 7;
-static constexpr uint8_t LEVEL_SENSITIVE_TRIGGER = 1 << 6;
-static constexpr uint8_t SET_HPM_1 = 1 << 5;
-static constexpr uint8_t SET_HPM_0 = 1 << 4;
-static constexpr uint8_t SET_HPCF_3 = 1 << 3;
-static constexpr uint8_t SET_HPCF_2 = 1 << 2;
-static constexpr uint8_t SET_HPCF_1 = 1 << 1;
-static constexpr uint8_t SET_HPCF_0 = 1;
-
-static constexpr uint8_t CTRL_REG_2_VAL = 0b0000'0000;
-
-/* Register 3 */
-static constexpr uint8_t CTRL_REG_3_VAL = 0b0000'0000;
-
-/* Register 4 */
-static constexpr uint8_t SET_BNU = 1 << 7;
-static constexpr uint8_t SET_BLE = 1 << 6;
-static constexpr uint8_t SET_FS_1 = 1 << 5;
-static constexpr uint8_t SET_FS_0 = 1 << 4;
-static constexpr uint8_t SET_IMP_ENB = 1 << 3;
-static constexpr uint8_t SET_SELF_TEST_ENB_1 = 1 << 2;
-static constexpr uint8_t SET_SELF_TEST_ENB_0 = 1 << 1;
-static constexpr uint8_t SET_SPI_IF_SELECT = 1;
-
-/* Enable big endian data format */
-static constexpr uint8_t CTRL_REG_4_VAL = SET_BLE;
-
-/* Register 5 */
-static constexpr uint8_t SET_REBOOT_MEM = 1 << 7;
-static constexpr uint8_t SET_FIFO_ENB = 1 << 6;
-
-static constexpr uint8_t CTRL_REG_5_VAL = 0b0000'0000;
-
-/* Possible range values in degrees per second (DPS). */
-static constexpr uint16_t RANGE_DPS_00 = 245;
-static constexpr uint16_t RANGE_DPS_01 = 500;
-static constexpr uint16_t RANGE_DPS_11 = 2000;
-
-static constexpr uint8_t READ_START = CTRL_REG_1;
-static constexpr size_t READ_LEN = 14;
-
-/* Indexing */
-static constexpr uint8_t REFERENCE_IDX = 6;
-static constexpr uint8_t TEMPERATURE_IDX = 7;
-static constexpr uint8_t STATUS_IDX = 8;
-static constexpr uint8_t OUT_X_H = 9;
-static constexpr uint8_t OUT_X_L = 10;
-static constexpr uint8_t OUT_Y_H = 11;
-static constexpr uint8_t OUT_Y_L = 12;
-static constexpr uint8_t OUT_Z_H = 13;
-static constexpr uint8_t OUT_Z_L = 14;
-
-/*------------------------------------------------------------------------*/
-/* Device Handler specific */
-/*------------------------------------------------------------------------*/
-static constexpr DeviceCommandId_t READ_REGS = 0;
-static constexpr DeviceCommandId_t CONFIGURE_CTRL_REGS = 1;
-static constexpr DeviceCommandId_t READ_CTRL_REGS = 2;
-
-static constexpr uint32_t GYRO_DATASET_ID = READ_REGS;
-
-enum GyroPoolIds : lp_id_t { ANG_VELOC_X, ANG_VELOC_Y, ANG_VELOC_Z, TEMPERATURE };
-
-}  // namespace l3gd20h
-
-class GyroPrimaryDataset : public StaticLocalDataSet<5> {
- public:
-  /** Constructor  for data users like controllers */
-  GyroPrimaryDataset(object_id_t mgmId)
-      : StaticLocalDataSet(sid_t(mgmId, l3gd20h::GYRO_DATASET_ID)) {
-    setAllVariablesReadOnly();
-  }
-
-  /* Angular velocities in degrees per second (DPS) */
-  lp_var_t<float> angVelocX = lp_var_t<float>(sid.objectId, l3gd20h::ANG_VELOC_X, this);
-  lp_var_t<float> angVelocY = lp_var_t<float>(sid.objectId, l3gd20h::ANG_VELOC_Y, this);
-  lp_var_t<float> angVelocZ = lp_var_t<float>(sid.objectId, l3gd20h::ANG_VELOC_Z, this);
-  lp_var_t<float> temperature = lp_var_t<float>(sid.objectId, l3gd20h::TEMPERATURE, this);
-
- private:
-  friend class GyroHandlerL3GD20H;
-  /** Constructor  for the data creator */
-  GyroPrimaryDataset(HasLocalDataPoolIF* hkOwner)
-      : StaticLocalDataSet(hkOwner, l3gd20h::GYRO_DATASET_ID) {}
-};
-
-#endif /* MISSION_DEVICES_DEVICEDEFINITIONS_GYROL3GD20DEFINITIONS_H_ */

mission/sysDefs.h

@@ -1,7 +1,8 @@
 #ifndef MISSION_SYSDEFS_H_
 #define MISSION_SYSDEFS_H_
 
-#include "acsDefs.h"
+#include "acs/defs.h"
+
 namespace satsystem {
 
 enum Mode : Mode_t { BOOT = 5, SAFE = acs::AcsMode::SAFE, PTG_IDLE = acs::AcsMode::PTG_IDLE };

mission/system/CMakeLists.txt

@@ -1,3 +1,7 @@
 add_subdirectory(objects)
 add_subdirectory(tree)
+add_subdirectory(acs)
+add_subdirectory(com)
 add_subdirectory(fdir)
+
+target_sources(${LIB_EIVE_MISSION} PRIVATE DualLanePowerStateMachine.cpp)

mission/system/DualLanePowerStateMachine.h

@@ -5,7 +5,7 @@
 #include <fsfw/modes/HasModesIF.h>
 #include <mission/system/objects/PowerStateMachineBase.h>
 
-#include "definitions.h"
+#include "mission/powerDefs.h"
 
 class AssemblyBase;
 class PowerSwitchIF;

mission/system/acs/AcsBoardAssembly.h

@@ -6,8 +6,8 @@
 #include <fsfw_hal/common/gpio/gpioDefinitions.h>
 
 #include "DualLaneAssemblyBase.h"
-#include "DualLanePowerStateMachine.h"
 #include "eive/eventSubsystemIds.h"
+#include "mission/system/DualLanePowerStateMachine.h"
 
 struct AcsBoardHelper {
   AcsBoardHelper(object_id_t mgm0Id, object_id_t mgm1Id, object_id_t mgm2Id, object_id_t mgm3Id,

mission/system/acs/AcsSubsystem.cpp

@@ -4,7 +4,7 @@
 #include <fsfw/ipc/QueueFactory.h>
 
 #include "fsfw/modes/ModeMessage.h"
-#include "mission/acsDefs.h"
+#include "mission/acs/defs.h"
 
 AcsSubsystem::AcsSubsystem(object_id_t setObjectId, uint32_t maxNumberOfSequences,
                            uint32_t maxNumberOfTables)

mission/system/acs/CMakeLists.txt

@@ -0,0 +1,11 @@
+target_sources(
+  ${LIB_EIVE_MISSION}
+  PRIVATE AcsBoardAssembly.cpp
+          AcsSubsystem.cpp
+          DualLaneAssemblyBase.cpp
+          ImtqAssembly.cpp
+          RwAssembly.cpp
+          SusAssembly.cpp
+          AcsBoardFdir.cpp
+          acsModeTree.cpp
+          SusFdir.cpp)

mission/system/acs/DualLaneAssemblyBase.h

@@ -2,7 +2,7 @@
 #define MISSION_SYSTEM_DUALLANEASSEMBLYBASE_H_
 
 #include <fsfw/devicehandlers/AssemblyBase.h>
-#include <mission/system/objects/DualLanePowerStateMachine.h>
+#include <mission/system/DualLanePowerStateMachine.h>
 
 /**
  * @brief   Encapsulates assemblies which are also responsible for dual lane power switching

mission/system/acs/acsModeTree.cpp

@@ -9,9 +9,9 @@
 #include <optional>
 
 #include "eive/objects.h"
-#include "mission/acsDefs.h"
-#include "mission/system/objects/definitions.h"
-#include "util.h"
+#include "mission/acs/defs.h"
+#include "mission/powerDefs.h"
+#include "mission/system/tree/util.h"
 
 AcsSubsystem satsystem::acs::ACS_SUBSYSTEM(objects::ACS_SUBSYSTEM, 12, 24);
 

mission/system/acs/acsModeTree.h

@@ -1,4 +1,4 @@
-#include <mission/system/objects/AcsSubsystem.h>
+#include <mission/system/acs/AcsSubsystem.h>
 
 namespace satsystem {
 namespace acs {

mission/system/com/CMakeLists.txt

@@ -0,0 +1,3 @@
+target_sources(
+  ${LIB_EIVE_MISSION} PRIVATE comModeTree.cpp ComSubsystem.cpp
+                              SyrlinksAssembly.cpp SyrlinksFdir.cpp)

mission/system/com/comModeTree.cpp

@@ -1,7 +1,8 @@
+#include "comModeTree.h"
+
 #include <fsfw/modes/HasModesIF.h>
 #include <fsfw/returnvalues/returnvalue.h>
 #include <fsfw/subsystem/Subsystem.h>
-#include <mission/com/comModeTree.h>
 
 #include "eive/objects.h"
 #include "mission/com/defs.h"

mission/system/com/comModeTree.h

@@ -2,7 +2,8 @@
 #define MISSION_SYSTEM_TREE_COMMODETREE_H_
 
 #include <fsfw/devicehandlers/DeviceHandlerIF.h>
-#include <mission/com/ComSubsystem.h>
+
+#include "ComSubsystem.h"
 
 namespace satsystem {
 

mission/system/fdir/CMakeLists.txt

@@ -1,3 +1,2 @@
-target_sources(
-  ${LIB_EIVE_MISSION} PRIVATE AcsBoardFdir.cpp RtdFdir.cpp StrFdir.cpp
-                              SusFdir.cpp GomspacePowerFdir.cpp)
+target_sources(${LIB_EIVE_MISSION} PRIVATE RtdFdir.cpp StrFdir.cpp
+                                           GomspacePowerFdir.cpp)

mission/system/fdir/StrFdir.cpp

@@ -1,6 +1,6 @@
 #include "StrFdir.h"
 
-#include "mission/acsDefs.h"
+#include "mission/acs/defs.h"
 
 StrFdir::StrFdir(object_id_t strObject)
     : DeviceHandlerFailureIsolation(strObject, objects::NO_OBJECT) {}

mission/system/objects/CMakeLists.txt

@@ -2,16 +2,9 @@ target_sources(
   ${LIB_EIVE_MISSION}
   PRIVATE EiveSystem.cpp
           CamSwitcher.cpp
-          AcsSubsystem.cpp
           TcsSubsystem.cpp
           PayloadSubsystem.cpp
-          AcsBoardAssembly.cpp
-          ImtqAssembly.cpp
           Stack5VHandler.cpp
-          SusAssembly.cpp
-          RwAssembly.cpp
-          DualLanePowerStateMachine.cpp
           StrAssembly.cpp
           PowerStateMachineBase.cpp
-          DualLaneAssemblyBase.cpp
           TcsBoardAssembly.cpp)

mission/system/objects/EiveSystem.cpp

@@ -3,7 +3,7 @@
 #include <eive/objects.h>
 #include <fsfw/events/EventManager.h>
 #include <fsfw/ipc/QueueFactory.h>
-#include <mission/acsDefs.h>
+#include <mission/acs/defs.h>
 
 EiveSystem::EiveSystem(object_id_t setObjectId, uint32_t maxNumberOfSequences,
                        uint32_t maxNumberOfTables)

mission/system/objects/PowerStateMachineBase.h

@@ -5,7 +5,7 @@
 #include <fsfw/power/PowerSwitchIF.h>
 #include <fsfw/timemanager/Countdown.h>
 
-#include "definitions.h"
+#include "mission/powerDefs.h"
 
 class PowerStateMachineBase {
  public:

mission/system/tree/CMakeLists.txt

@@ -1,2 +1,2 @@
-target_sources(${LIB_EIVE_MISSION} PRIVATE acsModeTree.cpp payloadModeTree.cpp
-                                           tcsModeTree.cpp system.cpp util.cpp)
+target_sources(${LIB_EIVE_MISSION} PRIVATE payloadModeTree.cpp tcsModeTree.cpp
+                                           system.cpp util.cpp)

mission/system/tree/payloadModeTree.cpp

@@ -8,8 +8,8 @@
 #include "eive/objects.h"
 #include "mission/devices/devicedefinitions/payloadPcduDefinitions.h"
 #include "mission/payloadDefs.h"
+#include "mission/powerDefs.h"
 #include "mission/system/objects/PayloadSubsystem.h"
-#include "mission/system/objects/definitions.h"
 #include "util.h"
 
 namespace {

mission/system/tree/system.cpp

@@ -2,13 +2,13 @@
 
 #include <fsfw/devicehandlers/DeviceHandlerIF.h>
 #include <fsfw/subsystem/Subsystem.h>
-#include <mission/acsDefs.h>
-#include <mission/com/comModeTree.h>
+#include <mission/acs/defs.h>
 #include <mission/sysDefs.h>
+#include <mission/system/com/comModeTree.h>
 
-#include "acsModeTree.h"
 #include "eive/objects.h"
 #include "mission/com/defs.h"
+#include "mission/system/acs/acsModeTree.h"
 #include "payloadModeTree.h"
 #include "tcsModeTree.h"
 #include "util.h"