Merge pull request 'always dump data into the VC' (#646) from always-dump-into-vc into v2.1.0-dev

Reviewed-on: #646

CHANGELOG.md

@@ -46,6 +46,9 @@ will consitute of a breaking change warranting a new major release:
 - TM store dumpes will not be cancelled anymore if the transmitter is off. The dump can be cancelled
   with an OFF command, and the PTME is perfectly capable of dumping without the transmitter being
   on.
+- Transmitter state is not taken into account anymore for writing into the PTME. The PTME should
+  be perfectly capable of generating a valid CADU, even when the transmitter is not ON for any
+  reason.
 
 ## Added
 

mission/com/VirtualChannel.cpp

@@ -11,10 +11,7 @@ ReturnValue_t VirtualChannel::sendNextTm(const uint8_t* data, size_t size) {
 }
 
 ReturnValue_t VirtualChannel::write(const uint8_t* data, size_t size) {
-  if (txOn) {
-    return ptme.writeToVc(vcId, data, size);
-  }
-  return returnvalue::OK;
+  return ptme.writeToVc(vcId, data, size);
 }
 
 uint8_t VirtualChannel::getVcid() const { return vcId; }
@@ -22,10 +19,6 @@ uint8_t VirtualChannel::getVcid() const { return vcId; }
 const char* VirtualChannel::getName() const { return vcName.c_str(); }
 
 bool VirtualChannel::isBusy() const {
-  // Data is discarded, so channel is not busy.
-  if (not txOn) {
-    return false;
-  }
   return ptme.isBusy(vcId);
 }