deleted comments fromm ThermalController
Some checks failed
EIVE/eive-obsw/pipeline/pr-develop There was a failure building this commit

This commit is contained in:
Irini Kosmidou 2023-01-28 22:51:51 +01:00
parent d432443545
commit fa7281794a
3 changed files with 16 additions and 21 deletions

View File

@ -24,6 +24,7 @@
#include "devices/addresses.h"
#include "devices/gpioIds.h"
#include "eive/definitions.h"
#include "mission/controller/ThermalController.h"
#include "mission/system/tree/acsModeTree.h"
#include "mission/system/tree/payloadModeTree.h"
#include "mission/system/tree/tcsModeTree.h"
@ -348,8 +349,8 @@ void ObjectFactory::createScexComponents(std::string uartDev, PowerSwitchIF* pwr
scexHandler->connectModeTreeParent(satsystem::pl::SUBSYSTEM);
}
void ObjectFactory::createThermalController() {
auto* tcsCtrl = new ThermalController(objects::THERMAL_CONTROLLER);
void ObjectFactory::createThermalController(HeaterHandler& heaterHandler) {
auto* tcsCtrl = new ThermalController(objects::THERMAL_CONTROLLER, heaterHandler);
tcsCtrl->connectModeTreeParent(satsystem::tcs::SUBSYSTEM);
}

View File

@ -36,4 +36,5 @@ AcsController* createAcsController(bool connectSubsystem);
void addTmtcIpCoresToFunnels(CcsdsIpCoreHandler& ipCoreHandler, PusTmFunnel& pusFunnel,
CfdpTmFunnel& cfdpFunnel);
void createThermalController(HeaterHandler& heaterHandler);
} // namespace ObjectFactory

View File

@ -108,7 +108,6 @@ void ThermalController::performControlOperation() {
deviceTemperatures.commit();
}
// TODO: Heater control
ctrlCameraBody();
ctrlAcsBoard();
ctrlMgt();
@ -984,7 +983,6 @@ void ThermalController::copyDevices() {
}
void ThermalController::ctrlAcsBoard() {
// TODO: check sensor 4; A:MGM1(int); B: MGM3(int)
heater::Switchers switchNr = heater::HEATER_2_ACS_BRD;
heater::Switchers redSwitchNr = heater::HEATER_0_OBC_BRD;
chooseHeater(switchNr, redSwitchNr);
@ -1008,9 +1006,8 @@ void ThermalController::ctrlAcsBoard() {
}
void ThermalController::ctrlMgt() {
// TODO: use heaterReq
PoolReadGuard pg(&imtqThermalSet);
ThermalComponentIF::StateRequest heaterReq =
auto heaterReq =
static_cast<ThermalComponentIF::StateRequest>(imtqThermalSet.heaterRequest.value);
if (heaterReq == ThermalComponentIF::STATE_REQUEST_OPERATIONAL) {
@ -1034,7 +1031,6 @@ void ThermalController::ctrlMgt() {
}
triggerEvent(NO_VALID_SENSOR_TEMPERATURE, switchNr);
sensorTempAvailable = false;
}
if (sensorTempAvailable) {
ctrlHeater(switchNr, redSwitchNr, &mgtLimits);
@ -1055,9 +1051,9 @@ void ThermalController::ctrlRw() {
if (sensorTemperatures.sensor_rw1.isValid()) {
sensorTemp = sensorTemperatures.sensor_rw1.value;
} else if (deviceTemperatures.rw1.isValid()) {
sensorTemp = deviceTemperatures.rw1.value;
sensorTemp = static_cast<float>(deviceTemperatures.rw1.value);
} else if (deviceTemperatures.rw4.isValid()) {
sensorTemp = deviceTemperatures.rw4.value;
sensorTemp = static_cast<float>(deviceTemperatures.rw4.value);
} else if (sensorTemperatures.sensor_dro.isValid()) {
sensorTemp = sensorTemperatures.sensor_dro.value;
} else {
@ -1073,9 +1069,9 @@ void ThermalController::ctrlRw() {
// RW2
sensorTempAvailable = true;
if (deviceTemperatures.rw2.isValid()) {
sensorTemp = deviceTemperatures.rw2.value;
sensorTemp = static_cast<float>(deviceTemperatures.rw2.value);
} else if (deviceTemperatures.rw3.isValid()) {
sensorTemp = deviceTemperatures.rw3.value;
sensorTemp = static_cast<float>(deviceTemperatures.rw3.value);
} else if (sensorTemperatures.sensor_rw1.isValid()) {
sensorTemp = sensorTemperatures.sensor_rw1.value;
} else if (sensorTemperatures.sensor_dro.isValid()) {
@ -1093,9 +1089,9 @@ void ThermalController::ctrlRw() {
// RW3
sensorTempAvailable = true;
if (deviceTemperatures.rw3.isValid()) {
sensorTemp = deviceTemperatures.rw3.value;
sensorTemp = static_cast<float>(deviceTemperatures.rw3.value);
} else if (deviceTemperatures.rw4.isValid()) {
sensorTemp = deviceTemperatures.rw4.value;
sensorTemp = static_cast<float>(deviceTemperatures.rw4.value);
} else if (sensorTemperatures.sensor_rw1.isValid()) {
sensorTemp = sensorTemperatures.sensor_rw1.value;
} else if (sensorTemperatures.sensor_dro.isValid()) {
@ -1113,9 +1109,9 @@ void ThermalController::ctrlRw() {
// RW4
sensorTempAvailable = true;
if (deviceTemperatures.rw4.isValid()) {
sensorTemp = deviceTemperatures.rw4.value;
sensorTemp = static_cast<float>(deviceTemperatures.rw4.value);
} else if (deviceTemperatures.rw1.isValid()) {
sensorTemp = deviceTemperatures.rw1.value;
sensorTemp = static_cast<float>(deviceTemperatures.rw1.value);
} else if (sensorTemperatures.sensor_rw1.isValid()) {
sensorTemp = sensorTemperatures.sensor_rw1.value;
} else if (sensorTemperatures.sensor_dro.isValid()) {
@ -1170,7 +1166,6 @@ void ThermalController::ctrlSBandTransceiver() {
sensorTemperatures.sensor_4k_camera, &sBandTransceiverLimits);
}
void ThermalController::ctrlPcduP60Board() {
// TODO: remove sensor3
ctrlComponentTemperature(heater::HEATER_3_PCDU_PDU, heater::HEATER_2_ACS_BRD,
deviceTemperatures.temp1P60dock, deviceTemperatures.temp2P60dock,
deviceTemperatures.temp2P60dock, &pcduP60BoardLimits);
@ -1185,8 +1180,8 @@ void ThermalController::ctrlPcduAcu() {
if (heaterAvailable) {
sensorTempAvailable = true;
if (deviceTemperatures.acu.isValid()) { // TODO: how to check the different values
sensorTemp = deviceTemperatures.acu.value[0]; // TODO: check if right
if (deviceTemperatures.acu.isValid()) {
sensorTemp = deviceTemperatures.acu.value[0];
} else if (deviceTemperatures.acu.isValid()) {
sensorTemp = deviceTemperatures.acu.value[1];
} else if (sensorTemperatures.sensor_acu.isValid()) {
@ -1197,7 +1192,6 @@ void ThermalController::ctrlPcduAcu() {
}
triggerEvent(NO_VALID_SENSOR_TEMPERATURE, switchNr);
sensorTempAvailable = false;
}
if (sensorTempAvailable) {
ctrlHeater(switchNr, redSwitchNr, &pcduAcuLimits);
@ -1206,7 +1200,6 @@ void ThermalController::ctrlPcduAcu() {
}
void ThermalController::ctrlPcduPdu() {
// TODO: remove sensor3
ctrlComponentTemperature(heater::HEATER_3_PCDU_PDU, heater::HEATER_2_ACS_BRD,
deviceTemperatures.pdu1, deviceTemperatures.pdu2,
deviceTemperatures.pdu2, &pcduPduLimits);
@ -1295,7 +1288,6 @@ void ThermalController::ctrlHeater(heater::Switchers switchNr, heater::Switchers
struct TempLimits* tempLimit) {
// Heater off
if (not heaterHandler.checkSwitchState(switchNr)) {
// TODO: check if OP
if (sensorTemp < (*tempLimit).opLowerLimit) {
heaterHandler.switchHeater(switchNr, HeaterHandler::SwitchState::ON);
}
@ -1363,6 +1355,7 @@ void ThermalController::ctrlComponentTemperature(heater::Switchers switchNr,
}
}
}
void ThermalController::chooseOf4Sensors(heater::Switchers switchNr, const lp_float_t& sensor1,
const lp_float_t& sensor2, const lp_float_t& sensor3,
const lp_float_t& sensor4) {